Received: from makus.postgresql.org (makus.postgresql.org [98.129.198.125])
	by mail.postgresql.org (Postfix) with ESMTP id 58D0E1DCB2B1
	for <pgsql-hackers@postgresql.org>;
	Mon, 27 Feb 2012 17:22:23 -0400 (AST)
Received: from acidenitrix.villemain.org ([91.121.90.165])
	by makus.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <dimitri@2ndQuadrant.fr>) id 1S281W-0004Pi-9u
	for pgsql-hackers@postgresql.org; Mon, 27 Feb 2012 21:22:22 +0000
Received: from 89-158-241-83.rev.dartybox.com ([89.158.241.83]
	helo=DimIMac.local) by acidenitrix.villemain.org with esmtpsa
	(TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69)
	(envelope-from <dimitri@2ndQuadrant.fr>)
	id 1S281I-0003dn-Uc; Mon, 27 Feb 2012 22:22:08 +0100
Received: by DimIMac.local (Postfix, from userid 501)
	id 357953BAD4D5; Mon, 27 Feb 2012 22:22:03 +0100 (CET)
From: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dimitri Fontaine <dimitri@2ndQuadrant.fr>, Thom Brown <thom@linux.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Command Triggers, patch v11
Organization: 2ndQuadrant
References: <m24nufq466.fsf@2ndQuadrant.fr>
	<CAA-aLv5H5_ALMRZFatX-wDEz1meMvQVJOsBBFTYox65jzAoN5Q@mail.gmail.com>
	<m2y5rrktqi.fsf@2ndQuadrant.fr>
	<CAA-aLv6kfradv_+LVC=TyS=UR3PD2vuMsS++A8BbvSW9H6mQ_g@mail.gmail.com>
	<CAA-aLv4_dfsAKS_AfReYw86KTkskhDDWycMc+Jb0vprc-OjnsA@mail.gmail.com>
	<CAA-aLv5i8tOyCivP6fYNgMUL2bi3atxdX-RBh791G7jr=ehGmA@mail.gmail.com>
	<CAA-aLv6AUdGFBA4=qkKExHxSiJ3fybV71S=KHGP2uNgJ2OV7uA@mail.gmail.com>
	<CAA-aLv6qDiz3pdxwZwMk_ABmERSm1sOCfZ4CMiy4qVJZYb=o6g@mail.gmail.com>
	<CAA-aLv7G0WLrQ3fgZ76DybrEmgGriJ-+otgsf6TyOrEcJfWcFw@mail.gmail.com>
	<CAA-aLv5aEwUVQ1zOCNvDzzPTZ71Z5BGSuZ5+LKWTktbUz_3tYw@mail.gmail.com>
	<m2zkc5of8k.fsf@2ndQuadrant.fr>
	<CAA-aLv5tuh9RKNmgCnxWr8jdUOi0EeYix32GC2Pxvr=7DUD+JQ@mail.gmail.com>
	<CAA-aLv7ba=+0G_5Qs97u-5yBGvK=iHAGdR=8P7q9CiBT8hW8Jg@mail.gmail.com>
	<m2ipis2hum.fsf@2ndQuadrant.fr> <18852.1330376038@sss.pgh.pa.us>
User-Mail-Address: dimitri@2ndQuadrant.fr
Date: Mon, 27 Feb 2012 22:22:03 +0100
In-Reply-To: <18852.1330376038@sss.pgh.pa.us> (Tom Lane's message of "Mon, 27
	Feb 2012 15:53:58 -0500")
Message-ID: <m24nucvuo4.fsf@2ndQuadrant.fr>
User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.93 (darwin)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Pg-Spam-Score: -1.9 (-)
X-Archive-Number: 201202/1341
X-Sequence-Number: 203705

Tom Lane <tgl@sss.pgh.pa.us> writes:
> FWIW, I agree with Thom on this.  If we do it as you suggest, I
> confidently predict that it will be less than a year before we seriously
> regret it.  Given all the discussion around this, it's borderline insane
> to believe that the set of parameters to be passed to command triggers
> is nailed down and won't need to change in the future.

I agree with the analysis=E2=80=A6

> As for special coding of support, it hardly seems onerous when every
> language that has triggers at all has got some provision for the
> existing trigger parameters.  A bit of copying and pasting should get
> the job done.

But had been (too easily) convinced not to take that route.  You changed
my mind already, I'll see about changing the code too tomorrow (a cold
is having me out of steam for tonight).

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support