From: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Robert Haas <robertmhaas@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Event Triggers: adding information
Organization: 2ndQuadrant
References: <m2txrsdzxa.fsf@2ndQuadrant.fr> <m2zk1j9c44.fsf@2ndQuadrant.fr>
	<CA+Tgmob6kmAySE5yXvd3uE9LifHunufMg9iU3GmbJ5bpGPiHjQ@mail.gmail.com>
	<m2k3sbe51z.fsf@2ndQuadrant.fr>
	<CA+TgmoZjOACnHOKrz-eucj3FJXrYJzA-_yjSqajOQR8qkjCi=w@mail.gmail.com>
	<m2bodi55yn.fsf@2ndQuadrant.fr>
	<CA+TgmoZTxXGAkoyQD0aNOyju1X19SnVfk7KV9fsJCv63bS-C4g@mail.gmail.com>
	<1356840827.20017.15.camel@vanquo.pezone.net>
User-Mail-Address: dimitri@2ndQuadrant.fr
Date: Sun, 30 Dec 2012 13:18:32 +0100
In-Reply-To: <1356840827.20017.15.camel@vanquo.pezone.net> (Peter Eisentraut's
	message of "Sat, 29 Dec 2012 23:13:47 -0500")
Message-ID: <m28v8fn36v.fsf@2ndQuadrant.fr>
User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2 (darwin)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--=-=-=
Content-Type: text/plain

Hi,

Peter Eisentraut <peter_e@gmx.net> writes:
> There is a new compiler warning coming from this, I believe:

I don't get this warning here, at least not in -O2, and I did forget to
make maintainer-clean then rebuild with -O0 just in case gcc is now
complaining about something else. I wish this situation could be fixed.

Now, this warning needs to be fixed, too, and here's a patch for that.

Thanks, regards,
-- 
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=copy-warning-fix.patch

diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c
index 31a0288..00f859e 100644
--- a/src/backend/commands/copy.c
+++ b/src/backend/commands/copy.c
@@ -750,7 +750,7 @@ DoCopy(const CopyStmt *stmt, const char *queryString, uint64 *processed)
 	bool		is_from = stmt->is_from;
 	bool		pipe = (stmt->filename == NULL);
 	Relation	rel;
-	Oid         relid;
+	Oid         relid = InvalidOid;
 
 	/* Disallow file COPY except to superusers. */
 	if (!pipe && !superuser())

--=-=-=
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--=-=-=--