Received: from magus.postgresql.org (magus.postgresql.org [87.238.57.229]) by mail.postgresql.org (Postfix) with ESMTP id 4E9411DCB2B6 for ; Mon, 27 Feb 2012 15:32:14 -0400 (AST) Received: from acidenitrix.villemain.org ([91.121.90.165]) by magus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1S26Il-0006Vc-MM for pgsql-hackers@postgresql.org; Mon, 27 Feb 2012 19:32:13 +0000 Received: from 89-158-241-83.rev.dartybox.com ([89.158.241.83] helo=DimIMac.local) by acidenitrix.villemain.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1S26IZ-0002Az-B2; Mon, 27 Feb 2012 20:31:51 +0100 Received: by DimIMac.local (Postfix, from userid 501) id A781A3BAAAB5; Mon, 27 Feb 2012 20:31:45 +0100 (CET) From: Dimitri Fontaine To: Thom Brown Cc: Dimitri Fontaine , PostgreSQL Hackers Subject: Re: Command Triggers, patch v11 Organization: 2ndQuadrant References: User-Mail-Address: dimitri@2ndQuadrant.fr Date: Mon, 27 Feb 2012 20:31:45 +0100 In-Reply-To: (Thom Brown's message of "Sun, 26 Feb 2012 23:24:31 +0000") Message-ID: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.93 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Pg-Spam-Score: -1.9 (-) X-Archive-Number: 201202/1329 X-Sequence-Number: 203693 Thom Brown writes: > I've got a question regarding the function signatures required for > command triggers, and apologies if it's already been discussed to > death (I didn't see all the original conversations around this). > These differ from regular trigger functions which don't require any > arguments, and instead use special variables. Why aren't we doing the > same for command triggers? So instead of having the parameters Basically so that we don't have to special code support for each and every language out there. > Disadvantages are that there's more maintenance overhead for > supporting multiple languages using special variables. Lots of, so I've been told, enough of it for not taking this choice seriously. I'll admit I didn't personally looked at what it would entail implementation wise. Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support