Received: from makus.postgresql.org (makus.postgresql.org [98.129.198.125])
	by mail.postgresql.org (Postfix) with ESMTP id A0B608E3529
	for <pgsql-hackers@postgresql.org>;
	Sat,  3 Mar 2012 10:35:23 -0400 (AST)
Received: from acidenitrix.villemain.org ([91.121.90.165])
	by makus.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <dimitri@2ndQuadrant.fr>) id 1S3q3N-0002ZF-Df
	for pgsql-hackers@postgresql.org; Sat, 03 Mar 2012 14:35:22 +0000
Received: from 89-158-241-83.rev.dartybox.com ([89.158.241.83]
	helo=DimIMac.local) by acidenitrix.villemain.org with esmtpsa
	(TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69)
	(envelope-from <dimitri@2ndQuadrant.fr>)
	id 1S3q39-0003zO-Tn; Sat, 03 Mar 2012 15:35:07 +0100
Received: by DimIMac.local (Postfix, from userid 501)
	id 878DB3C2B2FF; Sat,  3 Mar 2012 15:35:00 +0100 (CET)
From: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
To: Thom Brown <thom@linux.com>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>,
	Robert Haas <robertmhaas@gmail.com>,
	Kevin Grittner <Kevin.Grittner@wicourts.gov>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Command Triggers, patch v11
Organization: 2ndQuadrant
References: <m24nufq466.fsf@2ndQuadrant.fr>
	<CAA-aLv5H5_ALMRZFatX-wDEz1meMvQVJOsBBFTYox65jzAoN5Q@mail.gmail.com>
	<CAA-aLv4w9B27QP17zU-osme58gks0yEH7j8p5p1tKCWp2oq_Hw@mail.gmail.com>
	<CAA-aLv6Was-jZmigbH3_eLH3eqsEUPpf-p7FT2s1FjBdXAbeNA@mail.gmail.com>
	<CAA-aLv7=+b+CiaDrWi7bKBtnW=jMarVC1HpB0a+erTKP3B=5Zw@mail.gmail.com>
	<CAA-aLv4jkA-s9y+bW_53zfz0Zt2azULQ2dppQYoRRpWmW2fvNw@mail.gmail.com>
	<m28vjo2hlm.fsf@2ndQuadrant.fr>
	<CAA-aLv5zuJC2RtOPu_=-XOhJFROWLA7P=dtVHgHSdRp5wEzkjQ@mail.gmail.com>
	<4965.1330441437@sss.pgh.pa.us>
	<4F4C99AD0200002500045C72@gw.wicourts.gov>
	<CA+TgmoZkgpzFkw2odrog1r6x2Wwqwk+mQizbFR6zoQbTk6BArQ@mail.gmail.com>
	<m2hay56bo9.fsf@2ndQuadrant.fr>
	<CAA-aLv7rKY2i-uezD_=3fxu1QqnV1nHBkj71avWQzOqzWxrTHw@mail.gmail.com>
User-Mail-Address: dimitri@2ndQuadrant.fr
Date: Sat, 03 Mar 2012 15:34:59 +0100
In-Reply-To: 
 <CAA-aLv7rKY2i-uezD_=3fxu1QqnV1nHBkj71avWQzOqzWxrTHw@mail.gmail.com>
	(Thom Brown's message of "Sat, 3 Mar 2012 14:03:01 +0000")
Message-ID: <m2obsd3g8c.fsf@2ndQuadrant.fr>
User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.93 (darwin)
MIME-Version: 1.0
Content-Type: text/plain
X-Pg-Spam-Score: -1.9 (-)
X-Archive-Number: 201203/114
X-Sequence-Number: 203996

Thom Brown <thom@linux.com> writes:
> problem.  It was the DROP COMMAND TRIGGER statement that garnered
> comment, as it makes more sense to drop the entire trigger than
> individual commands for that trigger.

What you're saying here is that a single command could have more than
one command attached to it, and what I understand Tom, Robert and Kevin
are saying is that any given command trigger should only be attached to
a single command.

If we wanted to be more consistent we would need to have a way to attach
the same trigger to both BEFORE and AFTER the command, as of now you
need two triggers here.

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support