From: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
To: Thom Brown <thom@linux.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Event Triggers: adding information
Organization: 2ndQuadrant
References: <m2txrsdzxa.fsf@2ndQuadrant.fr> <m27go1ot1a.fsf@2ndQuadrant.fr>
	<20130104205251.GB9191@alvh.no-ip.org> <m28v88pqin.fsf@2ndQuadrant.fr>
	<20130109165829.GB4490@alvh.no-ip.org>
	<CA+TgmobykpymdGyfbCDEfS6+-50X-AKYTdK88fjMS4-mY5SBdw@mail.gmail.com>
	<m2ehhkrfqk.fsf@2ndQuadrant.fr>
	<CA+TgmobfeB_YpgMv5NjW52tG36Hg_DY=jq0XDkE5zwCstPQ4pg@mail.gmail.com>
	<m2pq14m7sx.fsf@2ndQuadrant.fr>
	<CA+TgmoYEW583z+oisToCYQMz2grzpavdXrCi3-W2D_+nucVhzQ@mail.gmail.com>
	<m2k3rbhh79.fsf@2ndQuadrant.fr>
	<CA+TgmoZYFhn=DyenBLr8KUZXYHtgjo-O8YE-7y61WKR6F05UQA@mail.gmail.com>
	<m21udesaz3.fsf@2ndQuadrant.fr>
	<CA+TgmoZPhj6Rw-DottwresCJnOmRewbOxp2AABwyxP2k7vZf-Q@mail.gmail.com>
	<m2622pmnnn.fsf@2ndQuadrant.fr>
	<CAA-aLv6Q4rtYyGYqp3e6qrikG0azxSYPigydBwwMgk=eBjeawQ@mail.gmail.com>
	<m21uddjqi1.fsf@2ndQuadrant.fr>
	<CAA-aLv4BbPRCNdao_RVa2TNaW8kZxiScTLx5xCuDMnfgPWmXHA@mail.gmail.com>
	<m2ip6pi8dn.fsf@2ndQuadrant.fr>
	<CAA-aLv4QKJvLZvpyWi2ORpxeY01kvwe+W3gy2k6L6rFEvibQ=A@mail.gmail.com>
	<CAA-aLv5S+uooLiv6w5CQZ4TzUSL0hFaDeF5OBRBt=8WMx0DTBg@mail.gmail.com>
User-Mail-Address: dimitri@2ndQuadrant.fr
Date: Tue, 22 Jan 2013 17:53:07 +0100
In-Reply-To: 
 <CAA-aLv5S+uooLiv6w5CQZ4TzUSL0hFaDeF5OBRBt=8WMx0DTBg@mail.gmail.com>
	(Thom Brown's message of "Tue, 22 Jan 2013 16:28:07 +0000")
Message-ID: <m2r4ldf9cc.fsf@2ndQuadrant.fr>
User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2 (darwin)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Thom Brown <thom@linux.com> writes:
> ALTER INDEX is missing from the event trigger matrix.
>
> When renaming a column on a foreign table, tg_tag reports 'ALTER
> TABLE' instead of 'ALTER FOREIGN TABLE'.  It doesn't do this for any
> other ALTER FOREIGN TABLE operation, including altering, adding or
> dropping a column.

Will see about that later, thanks for reporting.

> DROP OWNED BY doesn't fire any type of event trigger.  Is this right?

It's currently being discussed.

> And also I can't get ddl_command_end to do anything:

Due to a bug in the form of a stray & in the patch that got commited,
and that I fixed this morning:

  http://www.postgresql.org/message-id/m2vcapl7tl.fsf@2ndQuadrant.fr

> Also, I'm assuming the 'ANY COMMAND' special tag is supposed to be
> removed?

Yes, just omit the WHEN clause for the TAG.

Regards,
-- 
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers