Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1Txx61-0004fD-0b for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Jan 2013 09:58:17 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.72) (envelope-from ) id 1Txx5z-0007DO-Uq for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Jan 2013 09:58:15 +0000 Received: from magus.postgresql.org ([87.238.57.229]) by malur.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1Txx5y-0007DJ-Nr for pgsql-hackers@postgresql.org; Wed, 23 Jan 2013 09:58:14 +0000 Received: from acidenitrix.villemain.org ([91.121.90.165]) by magus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1Txx5s-0001zB-Jg for pgsql-hackers@postgresql.org; Wed, 23 Jan 2013 09:58:14 +0000 Received: from [89.157.243.170] (helo=Dimitris-MacBook-Air.local) by acidenitrix.villemain.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Txx5p-0005UB-GI; Wed, 23 Jan 2013 10:58:05 +0100 From: Dimitri Fontaine To: Robert Haas Cc: Alvaro Herrera , PostgreSQL Hackers Subject: Re: Event Triggers: adding information Organization: 2ndQuadrant References: <20130104205251.GB9191@alvh.no-ip.org> <20130109165829.GB4490@alvh.no-ip.org> User-Mail-Address: dimitri@2ndQuadrant.fr Date: Wed, 23 Jan 2013 10:57:52 +0100 In-Reply-To: (Robert Haas's message of "Tue, 22 Jan 2013 21:55:14 -0500") Message-ID: User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Robert Haas writes: > I think these new regression tests are no good, because I doubt that > the number of recursive calls that can fit into any given amount of > stack space is guaranteed to be the same on all platforms. I have > committed the bug fixes themselves, however. Thanks for commiting the fixes. About the regression tests, I think you're right, but then I can't see how to include such a test. Maybe you could add the other one, though? > I wasn't entirely happy with your proposed documentation so I'm > attaching a counter-proposal. My specific complaints are (1) telling > people that event triggers are run in a savepoint seems a little too > abstract; I have attempted to make the consequences more concrete; (2) > RAISE EXCEPTION is PL/pgsql specific and not the only possible reason > for an error; I have attempted to be more generic; and (3) in the > process of fiddling with this, I noticed that the ddl_command_end > documentation can, I believe, be made both shorter and more clear by > turning it into a rider on the previous paragraph. > > Comments? +1 for this version, thanks. -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers