agora inbox for pgsql-hackers@postgresql.orghelp / color / mirror / Atom feed
[PATCH v7 4/6] Handle pg_get_constraintdef default args in system_functions.sql 390+ messages / 2 participants [nested] [flat]
* [PATCH v7 4/6] Handle pg_get_constraintdef default args in system_functions.sql @ 2025-12-09 18:59 Mark Wong <markwkm@gmail.com> 0 siblings, 0 replies; 390+ messages in thread From: Mark Wong @ 2025-12-09 18:59 UTC (permalink / raw) Modernize pg_get_constraintdef to use proargdefaults to handle the optional pretty argument. --- src/backend/utils/adt/ruleutils.c | 17 ----------------- src/include/catalog/pg_proc.dat | 8 +++----- 2 files changed, 3 insertions(+), 22 deletions(-) diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c index 55926ec15e0..2d39bce7fd7 100644 --- a/src/backend/utils/adt/ruleutils.c +++ b/src/backend/utils/adt/ruleutils.c @@ -2420,23 +2420,6 @@ pg_get_partconstrdef_string(Oid partitionId, char *aliasname) */ Datum pg_get_constraintdef(PG_FUNCTION_ARGS) -{ - Oid constraintId = PG_GETARG_OID(0); - int prettyFlags; - char *res; - - prettyFlags = PRETTYFLAG_INDENT; - - res = pg_get_constraintdef_worker(constraintId, false, prettyFlags, true); - - if (res == NULL) - PG_RETURN_NULL(); - - PG_RETURN_TEXT_P(string_to_text(res)); -} - -Datum -pg_get_constraintdef_ext(PG_FUNCTION_ARGS) { Oid constraintId = PG_GETARG_OID(0); bool pretty = PG_GETARG_BOOL(1); diff --git a/src/include/catalog/pg_proc.dat b/src/include/catalog/pg_proc.dat index dfedf5c2851..39139fd9e3b 100644 --- a/src/include/catalog/pg_proc.dat +++ b/src/include/catalog/pg_proc.dat @@ -4006,9 +4006,6 @@ { oid => '1662', descr => 'trigger description', proname => 'pg_get_triggerdef', provolatile => 's', prorettype => 'text', proargtypes => 'oid', prosrc => 'pg_get_triggerdef' }, -{ oid => '1387', descr => 'constraint description', - proname => 'pg_get_constraintdef', provolatile => 's', prorettype => 'text', - proargtypes => 'oid', prosrc => 'pg_get_constraintdef' }, { oid => '1716', descr => 'deparse an encoded expression', proname => 'pg_get_expr', provolatile => 's', prorettype => 'text', proargtypes => 'pg_node_tree oid', prosrc => 'pg_get_expr' }, @@ -8604,9 +8601,10 @@ proname => 'pg_get_indexdef', provolatile => 's', prorettype => 'text', proargtypes => 'oid int4 bool', proargnames => '{index,column,pretty}', proargdefaults => '{0,false}', prosrc => 'pg_get_indexdef' }, -{ oid => '2508', descr => 'constraint description with pretty-print option', +{ oid => '2508', descr => 'constraint description', proname => 'pg_get_constraintdef', provolatile => 's', prorettype => 'text', - proargtypes => 'oid bool', prosrc => 'pg_get_constraintdef_ext' }, + proargtypes => 'oid bool', proargnames => '{constraint,pretty}', + proargdefaults => '{false}', prosrc => 'pg_get_constraintdef' }, { oid => '8760', descr => 'get DDL to recreate a role', proname => 'pg_get_role_ddl', provariadic => 'text', proisstrict => 'f', provolatile => 's', proretset => 't', prorows => '10', prorettype => 'text', -- 2.52.0 --GzYugJnip6WHHvTk Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=v7-0005-Handle-pg_get_expr-default-args-in-system_functio.patch ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid @ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 390+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw) --- src/backend/commands/cluster.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index af47354e382..29440fb75cd 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * Whether we could read new record or not, keep checking if * 'lsn_upto' was specified. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) { SpinLockAcquire(&shared->mutex); lsn_upto = shared->lsn_upto; @@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, done = shared->done; SpinLockRelease(&shared->mutex); } - if (!XLogRecPtrIsInvalid(lsn_upto) && + if (XLogRecPtrIsValid(lsn_upto) && ctx->reader->EndRecPtr >= lsn_upto) break; @@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx, * If lsn_upto is valid, WAL records having LSN lower than that * should already have been flushed to disk. */ - if (XLogRecPtrIsInvalid(lsn_upto)) + if (!XLogRecPtrIsValid(lsn_upto)) timeout = 100L; res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH, ctx->reader->EndRecPtr + 1, @@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg) * anything in the shared memory until we have serialized the snapshot. */ SpinLockAcquire(&shared->mutex); - Assert(XLogRecPtrIsInvalid(shared->lsn_upto)); + Assert(!XLogRecPtrIsValid(shared->lsn_upto)); sfs = &shared->sfs; SpinLockRelease(&shared->mutex); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0005-document-store_change-somewhat-more.nocfbot.txt" ^ permalink raw reply [nested|flat] 390+ messages in thread
end of thread, other threads:[~2026-03-12 15:09 UTC | newest] Thread overview: 390+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-12-09 18:59 [PATCH v7 4/6] Handle pg_get_constraintdef default args in system_functions.sql Mark Wong <markwkm@gmail.com> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de> 2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox