[PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()

agora inbox for pgsql-hackers@postgresql.org  
help / color / mirror / Atom feed

[PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
210+ messages / 2 participants
[nested] [flat]

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v3 1/4] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

LGTM.



^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer()
@ 2025-09-02 15:00  Melanie Plageman <melanieplageman@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Melanie Plageman @ 2025-09-02 15:00 UTC (permalink / raw)

@@ -731,6 +741,13 @@ StrategyRejectBuffer(BufferAccessStrategy
strategy, BufferDesc *buf, bool from_r
         strategy->buffers[strategy->current] !=3D BufferDescriptorGetBuffe=
r(buf))
         return false;

+    buf_state =3D LockBufHdr(buf);
+    lsn =3D BufferGetLSN(buf);
+    UnlockBufHdr(buf, buf_state);
+
+    if (!XLogNeedsFlush(lsn))
+        return true;

I think this should return false.

I am planning to review the other patches later and this is for the
first patch only.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 210+ messages in thread

* [PATCH v3 2/7] Handle pg_get_ruledef default args in system_functions.sql
@ 2025-12-08 23:41  Mark Wong <markwkm@gmail.com>
  0 siblings, 0 replies; 210+ messages in thread

From: Mark Wong @ 2025-12-08 23:41 UTC (permalink / raw)

Modernize pg_get_ruledef to use CREATE OR REPLACE FUNCTION to handle the
optional pretty argument.
---
 src/backend/catalog/system_functions.sql |  7 +++++++
 src/backend/utils/adt/ruleutils.c        | 18 ------------------
 src/include/catalog/pg_proc.dat          |  5 +----
 src/include/catalog/pg_retired.dat       |  2 ++
 4 files changed, 10 insertions(+), 22 deletions(-)

diff --git a/src/backend/catalog/system_functions.sql b/src/backend/catalog/system_functions.sql
index eb9e31ae1bf..3aad2fbf8f3 100644
--- a/src/backend/catalog/system_functions.sql
+++ b/src/backend/catalog/system_functions.sql
@@ -657,6 +657,13 @@ LANGUAGE INTERNAL
 STRICT VOLATILE PARALLEL UNSAFE
 AS 'pg_replication_origin_session_setup';
 
+CREATE OR REPLACE FUNCTION
+  pg_get_ruledef(rule oid, pretty bool DEFAULT false)
+RETURNS TEXT
+LANGUAGE INTERNAL
+PARALLEL SAFE
+AS 'pg_get_ruledef';
+
 --
 -- The default permissions for functions mean that anyone can execute them.
 -- A number of functions shouldn't be executable by just anyone, but rather
diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c
index 033b625f3fc..3733212fe0a 100644
--- a/src/backend/utils/adt/ruleutils.c
+++ b/src/backend/utils/adt/ruleutils.c
@@ -558,24 +558,6 @@ static void get_json_table_nested_columns(TableFunc *tf, JsonTablePlan *plan,
  */
 Datum
 pg_get_ruledef(PG_FUNCTION_ARGS)
-{
-	Oid			ruleoid = PG_GETARG_OID(0);
-	int			prettyFlags;
-	char	   *res;
-
-	prettyFlags = PRETTYFLAG_INDENT;
-
-	res = pg_get_ruledef_worker(ruleoid, prettyFlags);
-
-	if (res == NULL)
-		PG_RETURN_NULL();
-
-	PG_RETURN_TEXT_P(string_to_text(res));
-}
-
-
-Datum
-pg_get_ruledef_ext(PG_FUNCTION_ARGS)
 {
 	Oid			ruleoid = PG_GETARG_OID(0);
 	bool		pretty = PG_GETARG_BOOL(1);
diff --git a/src/include/catalog/pg_proc.dat b/src/include/catalog/pg_proc.dat
index 894b6a1b6d6..2a3362567a7 100644
--- a/src/include/catalog/pg_proc.dat
+++ b/src/include/catalog/pg_proc.dat
@@ -3961,9 +3961,6 @@
   proargtypes => 'oid oid', prosrc => 'oidge' },
 
 # System-view support functions
-{ oid => '1573', descr => 'source text of a rule',
-  proname => 'pg_get_ruledef', provolatile => 's', prorettype => 'text',
-  proargtypes => 'oid', prosrc => 'pg_get_ruledef' },
 { oid => '1640', descr => 'select statement of a view',
   proname => 'pg_get_viewdef', provolatile => 's', proparallel => 'r',
   prorettype => 'text', proargtypes => 'text',
@@ -8508,7 +8505,7 @@
 # System-view support functions with pretty-print option
 { oid => '2504', descr => 'source text of a rule with pretty-print option',
   proname => 'pg_get_ruledef', provolatile => 's', prorettype => 'text',
-  proargtypes => 'oid bool', prosrc => 'pg_get_ruledef_ext' },
+  proargtypes => 'oid bool', prosrc => 'pg_get_ruledef' },
 { oid => '2505',
   descr => 'select statement of a view with pretty-print option',
   proname => 'pg_get_viewdef', provolatile => 's', proparallel => 'r',
diff --git a/src/include/catalog/pg_retired.dat b/src/include/catalog/pg_retired.dat
index 413b68ad1cd..a3ce10c7f62 100644
--- a/src/include/catalog/pg_retired.dat
+++ b/src/include/catalog/pg_retired.dat
@@ -17,4 +17,6 @@
 # At the same time, it may be good to be reminded what procedure was associated
 # with it.
 
+{ oid => '1573', proname => 'pg_get_ruledef' }
+
 ]
-- 
2.43.0


--zd8Z8rlPOcTi77n/
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v3-0003-Handle-pg_get_viewdef-default-args-in-system_func.patch"



^ permalink  raw  reply  [nested|flat] 210+ messages in thread

end of thread, other threads:[~2025-12-08 23:41 UTC | newest]

Thread overview: 210+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v3 1/4] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-09-02 15:00 [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() Melanie Plageman <melanieplageman@gmail.com>
2025-12-08 23:41 [PATCH v3 2/7] Handle pg_get_ruledef default args in system_functions.sql Mark Wong <markwkm@gmail.com>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox