agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feed[PATCH 14/19] Move libpq_pipeline test into src/interfaces/libpq.
357+ messages / 2 participants
[nested] [flat]
* [PATCH 14/19] Move libpq_pipeline test into src/interfaces/libpq.
@ 2022-02-24 16:27 Andres Freund <andres@anarazel.de>
0 siblings, 0 replies; 357+ messages in thread
From: Andres Freund @ 2022-02-24 16:27 UTC (permalink / raw)
https://www.postgresql.org/message-id/20220227014626.vi7g7km554gmoape%40alap3.anarazel.de
ci-os-only: windows
---
.../libpq/t/002_pipeline.pl} | 2 +-
src/interfaces/libpq/test/.gitignore | 1 +
src/interfaces/libpq/test/Makefile | 2 +-
.../libpq/test}/libpq_pipeline.c | 0
.../test}/traces/disallowed_in_pipeline.trace | 0
.../libpq/test}/traces/multi_pipelines.trace | 0
.../libpq/test}/traces/nosync.trace | 0
.../libpq/test}/traces/pipeline_abort.trace | 0
.../libpq/test}/traces/prepared.trace | 0
.../libpq/test}/traces/simple_pipeline.trace | 0
.../libpq/test}/traces/singlerow.trace | 0
.../libpq/test}/traces/transaction.trace | 0
src/test/modules/Makefile | 1 -
src/test/modules/libpq_pipeline/.gitignore | 5 ----
src/test/modules/libpq_pipeline/Makefile | 25 -------------------
src/test/modules/libpq_pipeline/README | 1 -
src/tools/msvc/Mkvcbuild.pm | 5 ++--
17 files changed, 6 insertions(+), 36 deletions(-)
rename src/{test/modules/libpq_pipeline/t/001_libpq_pipeline.pl => interfaces/libpq/t/002_pipeline.pl} (95%)
rename src/{test/modules/libpq_pipeline => interfaces/libpq/test}/libpq_pipeline.c (100%)
rename src/{test/modules/libpq_pipeline => interfaces/libpq/test}/traces/disallowed_in_pipeline.trace (100%)
rename src/{test/modules/libpq_pipeline => interfaces/libpq/test}/traces/multi_pipelines.trace (100%)
rename src/{test/modules/libpq_pipeline => interfaces/libpq/test}/traces/nosync.trace (100%)
rename src/{test/modules/libpq_pipeline => interfaces/libpq/test}/traces/pipeline_abort.trace (100%)
rename src/{test/modules/libpq_pipeline => interfaces/libpq/test}/traces/prepared.trace (100%)
rename src/{test/modules/libpq_pipeline => interfaces/libpq/test}/traces/simple_pipeline.trace (100%)
rename src/{test/modules/libpq_pipeline => interfaces/libpq/test}/traces/singlerow.trace (100%)
rename src/{test/modules/libpq_pipeline => interfaces/libpq/test}/traces/transaction.trace (100%)
delete mode 100644 src/test/modules/libpq_pipeline/.gitignore
delete mode 100644 src/test/modules/libpq_pipeline/Makefile
delete mode 100644 src/test/modules/libpq_pipeline/README
diff --git a/src/test/modules/libpq_pipeline/t/001_libpq_pipeline.pl b/src/interfaces/libpq/t/002_pipeline.pl
similarity index 95%
rename from src/test/modules/libpq_pipeline/t/001_libpq_pipeline.pl
rename to src/interfaces/libpq/t/002_pipeline.pl
index e79980469b4..799462b799f 100644
--- a/src/test/modules/libpq_pipeline/t/001_libpq_pipeline.pl
+++ b/src/interfaces/libpq/t/002_pipeline.pl
@@ -50,7 +50,7 @@ for my $testname (@tests)
my $result;
my $inputdir = "$ENV{'TESTDIR'}/test";
- $expected = slurp_file_eval("$inputdir/$testname.trace");
+ $expected = slurp_file_eval("$inputdir/traces/$testname.trace");
next unless $expected ne "";
$result = slurp_file_eval($traceout);
next unless $result ne "";
diff --git a/src/interfaces/libpq/test/.gitignore b/src/interfaces/libpq/test/.gitignore
index 6ba78adb678..5c1a281d679 100644
--- a/src/interfaces/libpq/test/.gitignore
+++ b/src/interfaces/libpq/test/.gitignore
@@ -1,2 +1,3 @@
/libpq_testclient
/libpq_uri_regress
+/libpq_pipeline
diff --git a/src/interfaces/libpq/test/Makefile b/src/interfaces/libpq/test/Makefile
index d8e5ae824f2..b8f27f965ee 100644
--- a/src/interfaces/libpq/test/Makefile
+++ b/src/interfaces/libpq/test/Makefile
@@ -11,7 +11,7 @@ endif
override CPPFLAGS := -I$(libpq_srcdir) $(CPPFLAGS)
LDFLAGS_INTERNAL += $(libpq_pgport)
-PROGRAMS = libpq_testclient libpq_uri_regress
+PROGRAMS = libpq_testclient libpq_uri_regress libpq_pipeline
all: $(PROGRAMS)
diff --git a/src/test/modules/libpq_pipeline/libpq_pipeline.c b/src/interfaces/libpq/test/libpq_pipeline.c
similarity index 100%
rename from src/test/modules/libpq_pipeline/libpq_pipeline.c
rename to src/interfaces/libpq/test/libpq_pipeline.c
diff --git a/src/test/modules/libpq_pipeline/traces/disallowed_in_pipeline.trace b/src/interfaces/libpq/test/traces/disallowed_in_pipeline.trace
similarity index 100%
rename from src/test/modules/libpq_pipeline/traces/disallowed_in_pipeline.trace
rename to src/interfaces/libpq/test/traces/disallowed_in_pipeline.trace
diff --git a/src/test/modules/libpq_pipeline/traces/multi_pipelines.trace b/src/interfaces/libpq/test/traces/multi_pipelines.trace
similarity index 100%
rename from src/test/modules/libpq_pipeline/traces/multi_pipelines.trace
rename to src/interfaces/libpq/test/traces/multi_pipelines.trace
diff --git a/src/test/modules/libpq_pipeline/traces/nosync.trace b/src/interfaces/libpq/test/traces/nosync.trace
similarity index 100%
rename from src/test/modules/libpq_pipeline/traces/nosync.trace
rename to src/interfaces/libpq/test/traces/nosync.trace
diff --git a/src/test/modules/libpq_pipeline/traces/pipeline_abort.trace b/src/interfaces/libpq/test/traces/pipeline_abort.trace
similarity index 100%
rename from src/test/modules/libpq_pipeline/traces/pipeline_abort.trace
rename to src/interfaces/libpq/test/traces/pipeline_abort.trace
diff --git a/src/test/modules/libpq_pipeline/traces/prepared.trace b/src/interfaces/libpq/test/traces/prepared.trace
similarity index 100%
rename from src/test/modules/libpq_pipeline/traces/prepared.trace
rename to src/interfaces/libpq/test/traces/prepared.trace
diff --git a/src/test/modules/libpq_pipeline/traces/simple_pipeline.trace b/src/interfaces/libpq/test/traces/simple_pipeline.trace
similarity index 100%
rename from src/test/modules/libpq_pipeline/traces/simple_pipeline.trace
rename to src/interfaces/libpq/test/traces/simple_pipeline.trace
diff --git a/src/test/modules/libpq_pipeline/traces/singlerow.trace b/src/interfaces/libpq/test/traces/singlerow.trace
similarity index 100%
rename from src/test/modules/libpq_pipeline/traces/singlerow.trace
rename to src/interfaces/libpq/test/traces/singlerow.trace
diff --git a/src/test/modules/libpq_pipeline/traces/transaction.trace b/src/interfaces/libpq/test/traces/transaction.trace
similarity index 100%
rename from src/test/modules/libpq_pipeline/traces/transaction.trace
rename to src/interfaces/libpq/test/traces/transaction.trace
diff --git a/src/test/modules/Makefile b/src/test/modules/Makefile
index 9090226daa0..d3d18ab0d4a 100644
--- a/src/test/modules/Makefile
+++ b/src/test/modules/Makefile
@@ -10,7 +10,6 @@ SUBDIRS = \
delay_execution \
dummy_index_am \
dummy_seclabel \
- libpq_pipeline \
plsample \
snapshot_too_old \
spgist_name_ops \
diff --git a/src/test/modules/libpq_pipeline/.gitignore b/src/test/modules/libpq_pipeline/.gitignore
deleted file mode 100644
index 3a11e786b83..00000000000
--- a/src/test/modules/libpq_pipeline/.gitignore
+++ /dev/null
@@ -1,5 +0,0 @@
-# Generated subdirectories
-/log/
-/results/
-/tmp_check/
-/libpq_pipeline
diff --git a/src/test/modules/libpq_pipeline/Makefile b/src/test/modules/libpq_pipeline/Makefile
deleted file mode 100644
index 65acc3e997e..00000000000
--- a/src/test/modules/libpq_pipeline/Makefile
+++ /dev/null
@@ -1,25 +0,0 @@
-# src/test/modules/libpq_pipeline/Makefile
-
-PGFILEDESC = "libpq_pipeline - test program for pipeline execution"
-PGAPPICON = win32
-
-PROGRAM = libpq_pipeline
-OBJS = $(WIN32RES) libpq_pipeline.o
-
-NO_INSTALL = 1
-
-PG_CPPFLAGS = -I$(libpq_srcdir)
-PG_LIBS_INTERNAL += $(libpq_pgport)
-
-TAP_TESTS = 1
-
-ifdef USE_PGXS
-PG_CONFIG = pg_config
-PGXS := $(shell $(PG_CONFIG) --pgxs)
-include $(PGXS)
-else
-subdir = src/test/modules/libpq_pipeline
-top_builddir = ../../../..
-include $(top_builddir)/src/Makefile.global
-include $(top_srcdir)/contrib/contrib-global.mk
-endif
diff --git a/src/test/modules/libpq_pipeline/README b/src/test/modules/libpq_pipeline/README
deleted file mode 100644
index d8174dd579a..00000000000
--- a/src/test/modules/libpq_pipeline/README
+++ /dev/null
@@ -1 +0,0 @@
-Test programs and libraries for libpq
diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm
index 1de77075724..1a3064e9ab4 100644
--- a/src/tools/msvc/Mkvcbuild.pm
+++ b/src/tools/msvc/Mkvcbuild.pm
@@ -37,13 +37,14 @@ my @unlink_on_exit;
# Set of variables for modules in contrib/ and src/test/modules/
my $contrib_defines = {};
my @contrib_uselibpq = ();
-my @contrib_uselibpgport = ('libpq_uri_regress', 'libpq_testclient');
-my @contrib_uselibpgcommon = ();
+my @contrib_uselibpgport = ('libpq_uri_regress', 'libpq_testclient', 'libpq_pipeline');
+my @contrib_uselibpgcommon = ('libpq_pipeline');
my $contrib_extralibs = { 'libpq_pipeline' => ['ws2_32.lib'] };
my $contrib_extraincludes = {};
my $contrib_extrasource = {
'libpq_uri_regress' => ['src/interfaces/libpq/test/libpq_uri_regress.c'],
'libpq_testclient' => ['src/interfaces/libpq/test/libpq_testclient.c'],
+ 'libpq_pipeline' => ['src/interfaces/libpq/test/libpq_pipeline.c'],
};
my @contrib_excludes = (
'bool_plperl', 'commit_ts',
--
2.17.1
--Sw7tCqrGA+HQ0/zt
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0015-msvc-do-not-install-libpq-test-tools-by-default.patch"
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 357+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
--dnohjpfxulhc3bo3--
^ permalink raw reply [nested|flat] 357+ messages in thread
end of thread, other threads:[~2026-07-05 12:10 UTC | newest]
Thread overview: 357+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-02-24 16:27 [PATCH 14/19] Move libpq_pipeline test into src/interfaces/libpq. Andres Freund <andres@anarazel.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox