agora inbox for [email protected]  

help / color / mirror / Atom feed

Removing unneeded self joins
991+ messages / 10 participants
[nested] [flat]

* Removing unneeded self joins
@ 2018-05-16 15:43  Alexander Kuzmenkov <[email protected]>
  0 siblings, 3 replies; 991+ messages in thread

From: Alexander Kuzmenkov @ 2018-05-16 15:43 UTC (permalink / raw)
  To: pgsql-hackers

Hi hackers,

There is a join optimization we don't do -- removing inner join of a 
table with itself on a unique column. Such joins are generated by 
various ORMs, so from time to time our customers ask us to look into 
this. Most recently, it was discussed on the list in relation to an 
article comparing the optimizations that some DBMS make [1].

I started to explore what can be done about this. Attached is a proof of 
concept patch. It works for some simple cases:

create table tt(a int primary key, b text);
explain select p.* from tt p join (select * from tt where b ~~ 'a%') q 
on p.a = q.a;

                       QUERY PLAN
──────────────────────────────────────────────────────
  Seq Scan on tt p  (cost=0.00..25.88 rows=6 width=36)
    Filter: (b ~~ 'a%'::text)

It also works for semi-joins like `explain select p.* from tt p where 
exists (select * from tt where b ~~ 'a%' and a = p.a);`. This requires a 
preparatory step of reducing unique semi joins to inner joins, and we 
already do this (reduce_unique_semijoin).


What this patch tries to do is to remove these inner joins when a single 
join is being planned (populate_joinrel_with_paths). The main entry 
point is reduce_self_unique_join. First, it proves that both input 
relations are uniquely constrained by the same index given the 
particular join clauses. We already have a way to find such indexes 
(relation_has_unique_index_for), so I was able to reuse this. What I'm 
not sure about is how to properly remove the join after that. For now, I 
just pretend that the join relation being built is the outer baserel, 
add to it the restrictions from the inner relation, and then plan it as 
usual. Maybe there is a less hacky way to do it? I've seen elsewhere a 
suggestion to use an AppendPath for a similar purpose, but here we can't 
just use the outer relation we've already planned because the 
restriction list is different.

I'd be glad to hear your thoughts on this.

[1] 
https://www.postgresql.org/message-id/flat/CAMjNa7cC4X9YR-vAJS-jSYCajhRDvJQnN7m2sLH1wLh-_Z2bsw%40mai...

-- 
Alexander Kuzmenkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company



Attachments:

  [text/x-patch] remove-self-join-v1.patch (18.3K, ../../[email protected]/2-remove-self-join-v1.patch)
  download | inline diff:
diff --git a/src/backend/optimizer/path/allpaths.c b/src/backend/optimizer/path/allpaths.c
index 477b9f7..334793c 100644
--- a/src/backend/optimizer/path/allpaths.c
+++ b/src/backend/optimizer/path/allpaths.c
@@ -76,13 +76,9 @@ static void set_rel_size(PlannerInfo *root, RelOptInfo *rel,
 			 Index rti, RangeTblEntry *rte);
 static void set_rel_pathlist(PlannerInfo *root, RelOptInfo *rel,
 				 Index rti, RangeTblEntry *rte);
-static void set_plain_rel_size(PlannerInfo *root, RelOptInfo *rel,
-				   RangeTblEntry *rte);
 static void create_plain_partial_paths(PlannerInfo *root, RelOptInfo *rel);
 static void set_rel_consider_parallel(PlannerInfo *root, RelOptInfo *rel,
 						  RangeTblEntry *rte);
-static void set_plain_rel_pathlist(PlannerInfo *root, RelOptInfo *rel,
-					   RangeTblEntry *rte);
 static void set_tablesample_rel_size(PlannerInfo *root, RelOptInfo *rel,
 						 RangeTblEntry *rte);
 static void set_tablesample_rel_pathlist(PlannerInfo *root, RelOptInfo *rel,
@@ -366,7 +362,7 @@ set_rel_size(PlannerInfo *root, RelOptInfo *rel,
 				else
 				{
 					/* Plain relation */
-					set_plain_rel_size(root, rel, rte);
+					set_plain_rel_size(root, rel);
 				}
 				break;
 			case RTE_SUBQUERY:
@@ -449,7 +445,7 @@ set_rel_pathlist(PlannerInfo *root, RelOptInfo *rel,
 				else
 				{
 					/* Plain relation */
-					set_plain_rel_pathlist(root, rel, rte);
+					set_plain_rel_pathlist(root, rel);
 				}
 				break;
 			case RTE_SUBQUERY:
@@ -516,8 +512,8 @@ set_rel_pathlist(PlannerInfo *root, RelOptInfo *rel,
  * set_plain_rel_size
  *	  Set size estimates for a plain relation (no subquery, no inheritance)
  */
-static void
-set_plain_rel_size(PlannerInfo *root, RelOptInfo *rel, RangeTblEntry *rte)
+void
+set_plain_rel_size(PlannerInfo *root, RelOptInfo *rel)
 {
 	/*
 	 * Test any partial indexes of rel for applicability.  We must do this
@@ -691,8 +687,8 @@ set_rel_consider_parallel(PlannerInfo *root, RelOptInfo *rel,
  * set_plain_rel_pathlist
  *	  Build access paths for a plain relation (no subquery, no inheritance)
  */
-static void
-set_plain_rel_pathlist(PlannerInfo *root, RelOptInfo *rel, RangeTblEntry *rte)
+void
+set_plain_rel_pathlist(PlannerInfo *root, RelOptInfo *rel)
 {
 	Relids		required_outer;
 
diff --git a/src/backend/optimizer/path/indxpath.c b/src/backend/optimizer/path/indxpath.c
index f295558..d79b3c7 100644
--- a/src/backend/optimizer/path/indxpath.c
+++ b/src/backend/optimizer/path/indxpath.c
@@ -2961,7 +2961,7 @@ ec_member_matches_indexcol(PlannerInfo *root, RelOptInfo *rel,
 }
 
 /*
- * relation_has_unique_index_for
+ * relation_get_unique_index_for
  *	  Determine whether the relation provably has at most one row satisfying
  *	  a set of equality conditions, because the conditions constrain all
  *	  columns of some unique index.
@@ -2982,8 +2982,8 @@ ec_member_matches_indexcol(PlannerInfo *root, RelOptInfo *rel,
  * this routine automatically adds in any usable baserestrictinfo clauses.
  * (Note that the passed-in restrictlist will be destructively modified!)
  */
-bool
-relation_has_unique_index_for(PlannerInfo *root, RelOptInfo *rel,
+IndexOptInfo *
+relation_get_unique_index_for(PlannerInfo *root, RelOptInfo *rel,
 							  List *restrictlist,
 							  List *exprlist, List *oprlist)
 {
@@ -2993,7 +2993,7 @@ relation_has_unique_index_for(PlannerInfo *root, RelOptInfo *rel,
 
 	/* Short-circuit if no indexes... */
 	if (rel->indexlist == NIL)
-		return false;
+		return NULL;
 
 	/*
 	 * Examine the rel's restriction clauses for usable var = const clauses
@@ -3034,7 +3034,7 @@ relation_has_unique_index_for(PlannerInfo *root, RelOptInfo *rel,
 
 	/* Short-circuit the easy case */
 	if (restrictlist == NIL && exprlist == NIL)
-		return false;
+		return NULL;
 
 	/* Examine each index of the relation ... */
 	foreach(ic, rel->indexlist)
@@ -3131,10 +3131,10 @@ relation_has_unique_index_for(PlannerInfo *root, RelOptInfo *rel,
 
 		/* Matched all columns of this index? */
 		if (c == ind->ncolumns)
-			return true;
+			return ind;
 	}
 
-	return false;
+	return NULL;
 }
 
 /*
diff --git a/src/backend/optimizer/path/joinrels.c b/src/backend/optimizer/path/joinrels.c
index 7008e13..d57ac82 100644
--- a/src/backend/optimizer/path/joinrels.c
+++ b/src/backend/optimizer/path/joinrels.c
@@ -15,11 +15,15 @@
 #include "postgres.h"
 
 #include "miscadmin.h"
+#include "nodes/nodeFuncs.h"
 #include "optimizer/clauses.h"
 #include "optimizer/joininfo.h"
 #include "optimizer/pathnode.h"
 #include "optimizer/paths.h"
+#include "optimizer/plancat.h"
+#include "optimizer/predtest.h"
 #include "optimizer/prep.h"
+#include "optimizer/restrictinfo.h"
 #include "partitioning/partbounds.h"
 #include "utils/lsyscache.h"
 #include "utils/memutils.h"
@@ -747,6 +751,240 @@ make_join_rel(PlannerInfo *root, RelOptInfo *rel1, RelOptInfo *rel2)
 	return joinrel;
 }
 
+static bool
+has_relation_reference_walker(Node *node, void *context)
+{
+	if (node == NULL)
+		return false;
+
+	if (IsA(node, Var))
+		return ((Var *) node)->varno == (Index) (intptr_t) context;
+
+	return expression_tree_walker(node, has_relation_reference_walker, context);
+}
+
+static bool
+has_relation_reference(PathTarget *target, Index relid)
+{
+	return has_relation_reference_walker((Node *) target->exprs,
+										 (void *) (intptr_t) relid);
+}
+
+static bool
+set_varno_walker(Node *node, void *context)
+{
+	if (node == NULL)
+		return false;
+
+	if (IsA(node, Var))
+		((Var *) node)->varno = (Index) (intptr_t) context;
+
+	return expression_tree_walker(node, set_varno_walker, context);
+}
+
+static void
+set_varno(Expr *target, Index relid)
+{
+	set_varno_walker((Node *) target, (void*) (intptr_t) relid);
+}
+
+static inline bool
+clause_sides_match_join(RestrictInfo *rinfo, RelOptInfo *outerrel,
+						RelOptInfo *innerrel)
+{
+	if (bms_is_subset(rinfo->left_relids, outerrel->relids) &&
+		bms_is_subset(rinfo->right_relids, innerrel->relids))
+	{
+		/* lefthand side is outer */
+		rinfo->outer_is_left = true;
+		return true;
+	}
+	else if (bms_is_subset(rinfo->left_relids, innerrel->relids) &&
+			 bms_is_subset(rinfo->right_relids, outerrel->relids))
+	{
+		/* righthand side is outer */
+		rinfo->outer_is_left = false;
+		return true;
+	}
+	return false;				/* no good for these input relations */
+}
+
+static void
+init_simple_rel(PlannerInfo *root, RelOptInfo *rel, Index relid)
+{
+	RangeTblEntry *rte;
+
+	/* Fetch RTE for relation */
+	rte = root->simple_rte_array[relid];
+	Assert(rte != NULL);
+
+	rel->reloptkind = RELOPT_BASEREL;
+	rel->rtekind = rte->rtekind;
+	rel->rows = 0;
+	rel->relid = relid;
+
+	/* min_attr, max_attr, attr_needed, attr_widths are set below */
+
+	/* Check type of rtable entry */
+	switch (rte->rtekind)
+	{
+		case RTE_RELATION:
+			/* Table --- retrieve statistics from the system catalogs */
+			get_relation_info(root, rte->relid, rte->inh, rel);
+			break;
+		case RTE_SUBQUERY:
+		case RTE_FUNCTION:
+		case RTE_TABLEFUNC:
+		case RTE_VALUES:
+		case RTE_CTE:
+		case RTE_NAMEDTUPLESTORE:
+
+			/*
+			 * Subquery, function, tablefunc, values list, CTE, or ENR --- set
+			 * up attr range and arrays
+			 *
+			 * Note: 0 is included in range to support whole-row Vars
+			 */
+			rel->min_attr = 0;
+			rel->max_attr = list_length(rte->eref->colnames);
+			rel->attr_needed = (Relids *)
+				palloc0((rel->max_attr - rel->min_attr + 1) * sizeof(Relids));
+			rel->attr_widths = (int32 *)
+				palloc0((rel->max_attr - rel->min_attr + 1) * sizeof(int32));
+			break;
+		default:
+			elog(ERROR, "unrecognized RTE kind: %d",
+				 (int) rte->rtekind);
+			break;
+	}
+}
+
+static IndexOptInfo *
+get_inner_unique_index(PlannerInfo *root, RelOptInfo *innerRel,
+							 RelOptInfo *outerRel, List *restrictlist)
+{
+	ListCell *lc;
+	List *rl = list_copy(restrictlist);
+	foreach(lc, rl)
+	{
+		if (!clause_sides_match_join((RestrictInfo *) lfirst(lc),
+									 outerRel, innerRel))
+			return NULL;
+	}
+
+	return relation_get_unique_index_for(root, innerRel, rl, 0, 0);
+}
+
+/*
+ * This function optimizes out an inner join of a relation to itself on a
+ * unique column. When the inner relation is not referenced by the targetlist,
+ * we can transfer the filters from the inner relation to the outer one, and
+ * scan it instead of joining.
+ */
+static bool
+reduce_self_unique_join(PlannerInfo *root, RelOptInfo *outerrel,
+						RelOptInfo *innerrel, RelOptInfo *joinrel,
+						List *restrictlist)
+{
+	List *mergedRinfos;
+	ListCell *lc;
+	IndexOptInfo *outeridx, *inneridx;
+	Bitmapset *oldRelids = joinrel->relids;
+
+	outeridx = get_inner_unique_index(root, outerrel, innerrel, restrictlist);
+	if (!outeridx)
+		return false;
+
+	/*
+	 * Join can be reduced only if the unique constraint is immediate.
+	 * Otherwise, the constraint does not always hold inside a transaction.
+	 */
+	if (!outeridx->immediate)
+		return false;
+
+	inneridx = get_inner_unique_index(root, innerrel, outerrel, restrictlist);
+	if (!inneridx)
+		return false;
+
+	/* We must have the same unique index for both relations. */
+	if (outeridx->indexoid != inneridx->indexoid)
+		return false;
+
+	/* A sanity check: this is the same index on the same relation. */
+	Assert(root->simple_rte_array[outerrel->relid]->relid
+			== root->simple_rte_array[innerrel->relid]->relid);
+
+	/*
+	 * If some columns of the inner relation are in the target list,
+	 * we have to keep it.
+	 */
+	if (has_relation_reference(joinrel->reltarget, innerrel->relid))
+		return false;
+
+	/*
+	 * All the necessary conditions hold and we can change the join
+	 * into a scan on the outer relation. First, append the filters
+	 * from inner relation to the outer.
+	 */
+	mergedRinfos = list_copy(outerrel->baserestrictinfo);
+	foreach(lc, innerrel->baserestrictinfo)
+	{
+		RestrictInfo *oldRinfo = lfirst_node(RestrictInfo, lc);
+		RestrictInfo *newRinfo;
+		Expr *newClause;
+
+		if (is_redundant_derived_clause(oldRinfo, mergedRinfos))
+			continue;			/* derived from same EquivalenceClass */
+
+		newClause = copyObject(oldRinfo->clause);
+		set_varno(newClause, outerrel->relid);
+
+		/*
+		 * !!!FIXME This check doesn't work, because predicate_implied_by
+		 * uses equal() to compare Var nodes. For the Vars transfered from
+		 * another relation, some parameters such as varoattno and location
+		 * are different. They are not meaningful for the purposes of
+		 * Maybe just don't compare them?
+		 */
+		if (!contain_mutable_functions((Node *) newClause)
+			&& predicate_implied_by(list_make1(newClause), mergedRinfos,
+								 /* weak = */ false ))
+			continue;			/* provably implied by r1 */
+
+		/*
+		 * Make a new rinfo instead of copying, because it has quite a few
+		 * internal fields that depend on relid.
+		 */
+		newRinfo = make_restrictinfo(newClause,
+								  oldRinfo->is_pushed_down,
+								  oldRinfo->outerjoin_delayed,
+								  oldRinfo->pseudoconstant,
+								  oldRinfo->security_level,
+								  bms_make_singleton(outerrel->relid) /* required relids */,
+								  NULL /* outer relids */,
+								  oldRinfo->nullable_relids);
+		mergedRinfos = lappend(mergedRinfos, newRinfo);
+	}
+
+	/*
+	 * Pretend that the join relation is a base relation, and
+	 * plan it as usual.
+	 */
+	init_simple_rel(root, joinrel, outerrel->relid);
+
+	joinrel->baserestrictinfo = mergedRinfos;
+	joinrel->relids = bms_make_singleton(joinrel->relid);
+
+	set_plain_rel_size(root, joinrel);
+	set_plain_rel_pathlist(root, joinrel);
+
+	joinrel->relids = oldRelids;
+
+	elog(LOG, "Removed self join.");
+
+	return true;
+}
+
 /*
  * populate_joinrel_with_paths
  *	  Add paths to the given joinrel for given pair of joining relations. The
@@ -786,6 +1024,10 @@ populate_joinrel_with_paths(PlannerInfo *root, RelOptInfo *rel1,
 				mark_dummy_rel(joinrel);
 				break;
 			}
+
+			if (reduce_self_unique_join(root, rel1, rel2, joinrel, restrictlist))
+				break;
+
 			add_paths_to_joinrel(root, joinrel, rel1, rel2,
 								 JOIN_INNER, sjinfo,
 								 restrictlist);
diff --git a/src/backend/optimizer/plan/analyzejoins.c b/src/backend/optimizer/plan/analyzejoins.c
index 0e73f9c..128af10 100644
--- a/src/backend/optimizer/plan/analyzejoins.c
+++ b/src/backend/optimizer/plan/analyzejoins.c
@@ -601,7 +601,7 @@ rel_supports_distinctness(PlannerInfo *root, RelOptInfo *rel)
 		 * reference to unique indexes.  Make sure there's at least one
 		 * suitable unique index.  It must be immediately enforced, and if
 		 * it's a partial index, it must match the query.  (Keep these
-		 * conditions in sync with relation_has_unique_index_for!)
+		 * conditions in sync with relation_get_unique_index_for!)
 		 */
 		ListCell   *lc;
 
@@ -658,10 +658,10 @@ rel_is_distinct_for(PlannerInfo *root, RelOptInfo *rel, List *clause_list)
 	{
 		/*
 		 * Examine the indexes to see if we have a matching unique index.
-		 * relation_has_unique_index_for automatically adds any usable
+		 * relation_get_unique_index_for automatically adds any usable
 		 * restriction clauses for the rel, so we needn't do that here.
 		 */
-		if (relation_has_unique_index_for(root, rel, clause_list, NIL, NIL))
+		if (relation_get_unique_index_for(root, rel, clause_list, NIL, NIL))
 			return true;
 	}
 	else if (rel->rtekind == RTE_SUBQUERY)
diff --git a/src/backend/optimizer/plan/createplan.c b/src/backend/optimizer/plan/createplan.c
index 0317763..bc9741a 100644
--- a/src/backend/optimizer/plan/createplan.c
+++ b/src/backend/optimizer/plan/createplan.c
@@ -4593,9 +4593,17 @@ fix_indexqual_references(PlannerInfo *root, IndexPath *index_path)
 			 * Check to see if the indexkey is on the right; if so, commute
 			 * the clause.  The indexkey should be the side that refers to
 			 * (only) the base relation.
+			 *
+			 * index->rel->relids can be a multi-bit set, so the check
+			 * cannot be simplified to a plain comparison. The multi-bit
+			 * relids are produced by the unique inner join removal, see
+			 * reduce_self_unique_join().
 			 */
-			if (!bms_equal(rinfo->left_relids, index->rel->relids))
+			if (!bms_is_empty(rinfo->right_relids)
+				&& bms_is_subset(rinfo->right_relids, index->rel->relids))
+			{
 				CommuteOpExpr(op);
+			}
 
 			/*
 			 * Now replace the indexkey expression with an index Var.
diff --git a/src/backend/optimizer/util/pathnode.c b/src/backend/optimizer/util/pathnode.c
index e190ad4..c65474f 100644
--- a/src/backend/optimizer/util/pathnode.c
+++ b/src/backend/optimizer/util/pathnode.c
@@ -1583,7 +1583,7 @@ create_unique_path(PlannerInfo *root, RelOptInfo *rel, Path *subpath,
 	 * clauses for the rel, as well.
 	 */
 	if (rel->rtekind == RTE_RELATION && sjinfo->semi_can_btree &&
-		relation_has_unique_index_for(root, rel, NIL,
+		relation_get_unique_index_for(root, rel, NIL,
 									  sjinfo->semi_rhs_exprs,
 									  sjinfo->semi_operators))
 	{
diff --git a/src/include/optimizer/paths.h b/src/include/optimizer/paths.h
index cafde30..d2f8bcb 100644
--- a/src/include/optimizer/paths.h
+++ b/src/include/optimizer/paths.h
@@ -50,6 +50,8 @@ extern PGDLLIMPORT join_search_hook_type join_search_hook;
 
 extern RelOptInfo *make_one_rel(PlannerInfo *root, List *joinlist);
 extern void set_dummy_rel_pathlist(RelOptInfo *rel);
+extern void set_plain_rel_size(PlannerInfo *root, RelOptInfo *rel);
+extern void set_plain_rel_pathlist(PlannerInfo *root, RelOptInfo *rel);
 extern RelOptInfo *standard_join_search(PlannerInfo *root, int levels_needed,
 					 List *initial_rels);
 
@@ -71,7 +73,7 @@ extern void debug_print_rel(PlannerInfo *root, RelOptInfo *rel);
  *	  routines to generate index paths
  */
 extern void create_index_paths(PlannerInfo *root, RelOptInfo *rel);
-extern bool relation_has_unique_index_for(PlannerInfo *root, RelOptInfo *rel,
+extern IndexOptInfo *relation_get_unique_index_for(PlannerInfo *root, RelOptInfo *rel,
 							  List *restrictlist,
 							  List *exprlist, List *oprlist);
 extern bool indexcol_is_bool_constant_for_query(IndexOptInfo *index,
diff --git a/src/test/regress/expected/join.out b/src/test/regress/expected/join.out
index cbc882d..7f3691f 100644
--- a/src/test/regress/expected/join.out
+++ b/src/test/regress/expected/join.out
@@ -2918,6 +2918,65 @@ where nt3.id = 1 and ss2.b3;
 (1 row)
 
 --
+-- test removal of semi or inner joins on unique columns
+-- !!!FIXME check coverage
+--
+analyze nt1;
+explain (costs off)
+select a.* from nt1 a
+join (select * from nt1 where a1) b on a.id = b.id;
+    QUERY PLAN     
+-------------------
+ Seq Scan on nt1 a
+   Filter: a1
+(2 rows)
+
+explain (costs off)
+select a.* from nt1 a
+where exists (select * from nt1 where id = a.id) and id < 2;
+     QUERY PLAN     
+--------------------
+ Seq Scan on nt1 a
+   Filter: (id < 2)
+(2 rows)
+
+explain (costs off)
+select a.* from nt1 a
+where exists (select * from nt1 where id = a.id and id < 2);
+     QUERY PLAN     
+--------------------
+ Seq Scan on nt1 a
+   Filter: (id < 2)
+(2 rows)
+
+explain (costs off)
+select a.* from nt1 a
+where exists (select * from nt1 where id = a.id) and a1;
+    QUERY PLAN     
+-------------------
+ Seq Scan on nt1 a
+   Filter: a1
+(2 rows)
+
+explain (costs off)
+select a.* from nt1 a
+where exists (select * from nt1 where id = a.id and a1);
+    QUERY PLAN     
+-------------------
+ Seq Scan on nt1 a
+   Filter: a1
+(2 rows)
+
+explain (costs off)
+select a.* from nt1 a
+where exists (select * from nt1 where id = a.id and a1) and id < 2;
+         QUERY PLAN          
+-----------------------------
+ Seq Scan on nt1 a
+   Filter: (a1 AND (id < 2))
+(2 rows)
+
+--
 -- test case where a PlaceHolderVar is propagated into a subquery
 --
 explain (costs off)
diff --git a/src/test/regress/sql/join.sql b/src/test/regress/sql/join.sql
index 86c6d5b..1fc6a02 100644
--- a/src/test/regress/sql/join.sql
+++ b/src/test/regress/sql/join.sql
@@ -851,6 +851,36 @@ from nt3 as nt3
 where nt3.id = 1 and ss2.b3;
 
 --
+-- test removal of semi or inner joins on unique columns
+-- !!!FIXME check coverage
+--
+analyze nt1;
+
+explain (costs off)
+select a.* from nt1 a
+join (select * from nt1 where a1) b on a.id = b.id;
+
+explain (costs off)
+select a.* from nt1 a
+where exists (select * from nt1 where id = a.id) and id < 2;
+
+explain (costs off)
+select a.* from nt1 a
+where exists (select * from nt1 where id = a.id and id < 2);
+
+explain (costs off)
+select a.* from nt1 a
+where exists (select * from nt1 where id = a.id) and a1;
+
+explain (costs off)
+select a.* from nt1 a
+where exists (select * from nt1 where id = a.id and a1);
+
+explain (costs off)
+select a.* from nt1 a
+where exists (select * from nt1 where id = a.id and a1) and id < 2;
+
+--
 -- test case where a PlaceHolderVar is propagated into a subquery
 --
 


^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 16:08  Tom Lane <[email protected]>
  parent: Alexander Kuzmenkov <[email protected]>
  2 siblings, 1 reply; 991+ messages in thread

From: Tom Lane @ 2018-05-16 16:08 UTC (permalink / raw)
  To: Alexander Kuzmenkov <[email protected]>; +Cc: pgsql-hackers

Alexander Kuzmenkov <[email protected]> writes:
> There is a join optimization we don't do -- removing inner join of a 
> table with itself on a unique column. Such joins are generated by 
> various ORMs, so from time to time our customers ask us to look into 
> this. Most recently, it was discussed on the list in relation to an 
> article comparing the optimizations that some DBMS make [1].

This is the sort of thing that I always wonder why the customers don't
ask the ORM to stop generating such damfool queries.  Its *expensive*
for us to clean up after their stupidity; almost certainly, it would
take far fewer cycles, net, for them to be a bit smarter in the first
place.

			regards, tom lane




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 16:26  Robert Haas <[email protected]>
  parent: Tom Lane <[email protected]>
  0 siblings, 2 replies; 991+ messages in thread

From: Robert Haas @ 2018-05-16 16:26 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: Alexander Kuzmenkov <[email protected]>; pgsql-hackers

On Wed, May 16, 2018 at 12:08 PM, Tom Lane <[email protected]> wrote:
> Alexander Kuzmenkov <[email protected]> writes:
>> There is a join optimization we don't do -- removing inner join of a
>> table with itself on a unique column. Such joins are generated by
>> various ORMs, so from time to time our customers ask us to look into
>> this. Most recently, it was discussed on the list in relation to an
>> article comparing the optimizations that some DBMS make [1].
>
> This is the sort of thing that I always wonder why the customers don't
> ask the ORM to stop generating such damfool queries.  Its *expensive*
> for us to clean up after their stupidity; almost certainly, it would
> take far fewer cycles, net, for them to be a bit smarter in the first
> place.

The trouble, of course, is that the customer didn't write the ORM,
likely has no idea how it works, and doesn't want to run a modified
version of it even if they do.  If the queries run faster on other
systems than they do on PostgreSQL, we get dinged -- not unjustly.

Also, I'm not sure that I believe that it's always easy to avoid
generating such queries.  I mean, this case is trivial so it's easy to
say, well, just rewrite the query.  But suppose that I have a fact
table over which I've created two views, each of which performs
various joins between the fact table and various lookup tables.  My
queries are such that I normally need the joins in just one of these
two views and not the other to fetch the information I care about.
But every once in a while I need to run a report that involves pulling
every column possible.  The obvious solution is to join the views on
the underlying table's primary key, but then you get this problem.  Of
course there's a workaround: define a third view that does both sets
of joins-to-lookup-tables.  But that starts to feel like you're
handholding the database; surely it's the database's job to optimize
queries, not the user's.

It's been about 10 years since I worked as a web developer, but I do
remember hitting this kind of problem from time to time and I'd really
like to see us do something about it.  I wish we could optimize away
inner joins, too, for similar reasons.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 18:58  Andres Freund <[email protected]>
  parent: Robert Haas <[email protected]>
  1 sibling, 1 reply; 991+ messages in thread

From: Andres Freund @ 2018-05-16 18:58 UTC (permalink / raw)
  To: Robert Haas <[email protected]>; +Cc: Tom Lane <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

Hi,

On 2018-05-16 12:26:48 -0400, Robert Haas wrote:
> Also, I'm not sure that I believe that it's always easy to avoid
> generating such queries.

Yea. There's obviously plenty cases where ORMs just want to make the
database hurt. But especially when building a join between a number of
tables based on various fields, it's not going to be easy for the ORM to
figure out which ones can be safely omitted. It'd need similar
optimization as we'd have to do, without having the infrastructure core
PG has.  And then there's, as you say, views etc...

Greetings,

Andres Freund




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 20:04  Simon Riggs <[email protected]>
  parent: Robert Haas <[email protected]>
  1 sibling, 1 reply; 991+ messages in thread

From: Simon Riggs @ 2018-05-16 20:04 UTC (permalink / raw)
  To: Robert Haas <[email protected]>; +Cc: Tom Lane <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

On 16 May 2018 at 11:26, Robert Haas <[email protected]> wrote:
> On Wed, May 16, 2018 at 12:08 PM, Tom Lane <[email protected]> wrote:
>> Alexander Kuzmenkov <[email protected]> writes:
>>> There is a join optimization we don't do -- removing inner join of a
>>> table with itself on a unique column. Such joins are generated by
>>> various ORMs, so from time to time our customers ask us to look into
>>> this. Most recently, it was discussed on the list in relation to an
>>> article comparing the optimizations that some DBMS make [1].
>>
>> This is the sort of thing that I always wonder why the customers don't
>> ask the ORM to stop generating such damfool queries.  Its *expensive*
>> for us to clean up after their stupidity; almost certainly, it would
>> take far fewer cycles, net, for them to be a bit smarter in the first
>> place.
>
> The trouble, of course, is that the customer didn't write the ORM,
> likely has no idea how it works, and doesn't want to run a modified
> version of it even if they do.  If the queries run faster on other
> systems than they do on PostgreSQL, we get dinged -- not unjustly.
>
> Also, I'm not sure that I believe that it's always easy to avoid
> generating such queries.  I mean, this case is trivial so it's easy to
> say, well, just rewrite the query.  But suppose that I have a fact
> table over which I've created two views, each of which performs
> various joins between the fact table and various lookup tables.  My
> queries are such that I normally need the joins in just one of these
> two views and not the other to fetch the information I care about.
> But every once in a while I need to run a report that involves pulling
> every column possible.  The obvious solution is to join the views on
> the underlying table's primary key, but then you get this problem.  Of
> course there's a workaround: define a third view that does both sets
> of joins-to-lookup-tables.  But that starts to feel like you're
> handholding the database; surely it's the database's job to optimize
> queries, not the user's.
>
> It's been about 10 years since I worked as a web developer, but I do
> remember hitting this kind of problem from time to time and I'd really
> like to see us do something about it.  I wish we could optimize away
> inner joins, too, for similar reasons.

I agree with everything you say.

What I would add is that I've seen cases where the extra joins do NOT
hurt performance, so the extra CPU used to remove the join hurts more
than the benefit of removing it. Yes, we tried it.

More advanced optimizations should only be applied when we've assessed
that the likely run time is high enough to make it worth investing in
further optimization.

-- 
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 20:10  Tom Lane <[email protected]>
  parent: Simon Riggs <[email protected]>
  0 siblings, 1 reply; 991+ messages in thread

From: Tom Lane @ 2018-05-16 20:10 UTC (permalink / raw)
  To: Simon Riggs <[email protected]>; +Cc: Robert Haas <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

Simon Riggs <[email protected]> writes:
> What I would add is that I've seen cases where the extra joins do NOT
> hurt performance, so the extra CPU used to remove the join hurts more
> than the benefit of removing it. Yes, we tried it.

Interesting.  The concern I had was more about the cost imposed on every
query to detect self-joins and try to prove them useless, even in queries
where no benefit ensues.  It's possible that we can get that down to the
point where it's negligible; but this says that even the successful-proof
case has to be very cheap.

			regards, tom lane




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 20:36  Jonathan S. Katz <[email protected]>
  parent: Andres Freund <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Jonathan S. Katz @ 2018-05-16 20:36 UTC (permalink / raw)
  To: Andres Freund <[email protected]>; +Cc: Robert Haas <[email protected]>; Tom Lane <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers


> On May 16, 2018, at 1:58 PM, Andres Freund <[email protected]> wrote:
> 
> Hi,
> 
> On 2018-05-16 12:26:48 -0400, Robert Haas wrote:
>> Also, I'm not sure that I believe that it's always easy to avoid
>> generating such queries.
> 
> Yea. There's obviously plenty cases where ORMs just want to make the
> database hurt. But especially when building a join between a number of
> tables based on various fields, it's not going to be easy for the ORM to
> figure out which ones can be safely omitted. It'd need similar
> optimization as we'd have to do, without having the infrastructure core
> PG has.  And then there's, as you say, views etc…

Are there specific examples of what the ORM code is that generated
the SQL? I’m more curious to see what people are writing that
generates such code. As earlier mentioned we could always report back
to the specific ORM maintainer(s) such examples and see if they could
tweak.

Jonathan



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 20:44  Simon Riggs <[email protected]>
  parent: Tom Lane <[email protected]>
  0 siblings, 1 reply; 991+ messages in thread

From: Simon Riggs @ 2018-05-16 20:44 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: Robert Haas <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

On 16 May 2018 at 15:10, Tom Lane <[email protected]> wrote:
> Simon Riggs <[email protected]> writes:
>> What I would add is that I've seen cases where the extra joins do NOT
>> hurt performance, so the extra CPU used to remove the join hurts more
>> than the benefit of removing it. Yes, we tried it.
>
> Interesting.  The concern I had was more about the cost imposed on every
> query to detect self-joins and try to prove them useless, even in queries
> where no benefit ensues.  It's possible that we can get that down to the
> point where it's negligible; but this says that even the successful-proof
> case has to be very cheap.

What I was advocating was an approach that varies according to the
query cost, so we don't waste time trying to tune the heck out of OLTP
queries, but for larger queries we might take a more considered
approach.

For advanced optimizations that are costly to check for, skip the
check if we are already below a cost threshold. The threshold would be
a heuristic that varies according to the cost of the check.

I realise that in this case we wouldn't know the full query cost until
we've done join planning, so we would need some lower bound estimate
to check whether its worth trying to remove joins.

-- 
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 20:45  David Rowley <[email protected]>
  parent: Alexander Kuzmenkov <[email protected]>
  2 siblings, 2 replies; 991+ messages in thread

From: David Rowley @ 2018-05-16 20:45 UTC (permalink / raw)
  To: Alexander Kuzmenkov <[email protected]>; +Cc: pgsql-hackers

On 17 May 2018 at 03:43, Alexander Kuzmenkov <[email protected]> wrote:
> I'd be glad to hear your thoughts on this.

(I only glanced at the patch)

I've thought and discussed this before on this list. I think the
arguments for and against it were much the same as you've received
already. If you trawl through the archives you'll see my argument for
matches quite closely to Robert regarding the nested-views. I
personally experienced this issue in my previous job, although it was
not with PostgreSQL.

I think it's worth doing this providing that we can fast-path out
quickly enough in cases where we can't possibly remove anything.
Likely the success of this patch depends on how quick that fast-path
is.



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 20:48  David Rowley <[email protected]>
  parent: Simon Riggs <[email protected]>
  0 siblings, 2 replies; 991+ messages in thread

From: David Rowley @ 2018-05-16 20:48 UTC (permalink / raw)
  To: Simon Riggs <[email protected]>; +Cc: Tom Lane <[email protected]>; Robert Haas <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

On 17 May 2018 at 08:44, Simon Riggs <[email protected]> wrote:
> What I was advocating was an approach that varies according to the
> query cost, so we don't waste time trying to tune the heck out of OLTP
> queries, but for larger queries we might take a more considered
> approach.

That's tricky. If we do this, it should be done before Path
generation, so not much is known about the costs in those case.

Perhaps something can be done by looking at the number of relpages,
but I've no idea what that would be. Perhaps we need to see how costly
this operation is first before we try to think of ways to only apply
it conditionally?

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 21:31  Alexander Kuzmenkov <[email protected]>
  parent: David Rowley <[email protected]>
  1 sibling, 0 replies; 991+ messages in thread

From: Alexander Kuzmenkov @ 2018-05-16 21:31 UTC (permalink / raw)
  To: David Rowley <[email protected]>; +Cc: pgsql-hackers

David,

Many thanks for the detailed explanation. I'll try to code it up and 
measure how much overhead it introduces.

-- 
Alexander Kuzmenkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company





^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 21:41  Thomas Munro <[email protected]>
  parent: Alexander Kuzmenkov <[email protected]>
  2 siblings, 1 reply; 991+ messages in thread

From: Thomas Munro @ 2018-05-16 21:41 UTC (permalink / raw)
  To: Alexander Kuzmenkov <[email protected]>; +Cc: pgsql-hackers

On Thu, May 17, 2018 at 3:43 AM, Alexander Kuzmenkov
<[email protected]> wrote:
> There is a join optimization we don't do -- removing inner join of a table
> with itself on a unique column. Such joins are generated by various ORMs, so
> from time to time our customers ask us to look into this. Most recently, it
> was discussed on the list in relation to an article comparing the
> optimizations that some DBMS make [1].
>
> ...
>
> I'd be glad to hear your thoughts on this.

+1

Some thoughts:

There might be some interesting corner cases involving self-joins in
UPDATE/DELETE statements, and also FOR UPDATE etc.  Those can result
in some surprising results in a self-join (one side is subject to EPQ
and the other isn't) which I think might be changed by your patch
(though I didn't try it or read the patch very closely).

IIUC in DB2 (the clear winner at join elimination in the article you
mentioned), you get these sorts of things by default (optimisation
level 5 includes it), but not if you SET CURRENT QUERY OPTIMIZATION =
3 as many articles recommend for OLTP work.  I think it's interesting
that they provide that knob rather than something automatic, and
interesting that there is one linear knob to classify your workload
rather than N knobs for N optimisations.

-- 
Thomas Munro
http://www.enterprisedb.com




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 22:02  Andres Freund <[email protected]>
  parent: David Rowley <[email protected]>
  1 sibling, 0 replies; 991+ messages in thread

From: Andres Freund @ 2018-05-16 22:02 UTC (permalink / raw)
  To: David Rowley <[email protected]>; +Cc: Simon Riggs <[email protected]>; Tom Lane <[email protected]>; Robert Haas <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

HI,

On 2018-05-17 08:48:58 +1200, David Rowley wrote:
> On 17 May 2018 at 08:44, Simon Riggs <[email protected]> wrote:
> > What I was advocating was an approach that varies according to the
> > query cost, so we don't waste time trying to tune the heck out of OLTP
> > queries, but for larger queries we might take a more considered
> > approach.
> 
> That's tricky. If we do this, it should be done before Path
> generation, so not much is known about the costs in those case.
> 
> Perhaps something can be done by looking at the number of relpages,
> but I've no idea what that would be. Perhaps we need to see how costly
> this operation is first before we try to think of ways to only apply
> it conditionally?

I'm also not buying that this isn't a benefit in OLTP in general. Sure,
for a single query RTT costs are going to dominate, but if you use
prepared statements the costs are going to pay of over multiple
executions.  Even just avoiding initializing unnecessary executor nodes
shows up in profiles.

Greetings,

Andres Freund




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 22:13  Tom Lane <[email protected]>
  parent: David Rowley <[email protected]>
  1 sibling, 2 replies; 991+ messages in thread

From: Tom Lane @ 2018-05-16 22:13 UTC (permalink / raw)
  To: David Rowley <[email protected]>; +Cc: Simon Riggs <[email protected]>; Robert Haas <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

David Rowley <[email protected]> writes:
> On 17 May 2018 at 08:44, Simon Riggs <[email protected]> wrote:
>> What I was advocating was an approach that varies according to the
>> query cost, so we don't waste time trying to tune the heck out of OLTP
>> queries, but for larger queries we might take a more considered
>> approach.

> That's tricky. If we do this, it should be done before Path
> generation, so not much is known about the costs in those case.

Yeah.  It'd have to be a very heuristic thing that doesn't account
for much beyond the number of relations in the query, and maybe their
sizes --- although I don't think we even know the latter at the
point where join removal would be desirable.  (And note that one of
the desirable benefits of join removal is not having to find out the
sizes of removed rels ... so just swapping that around doesn't appeal.)

			regards, tom lane




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 22:24  David Rowley <[email protected]>
  parent: Tom Lane <[email protected]>
  1 sibling, 1 reply; 991+ messages in thread

From: David Rowley @ 2018-05-16 22:24 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: Simon Riggs <[email protected]>; Robert Haas <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

On 17 May 2018 at 10:13, Tom Lane <[email protected]> wrote:
> Yeah.  It'd have to be a very heuristic thing that doesn't account
> for much beyond the number of relations in the query, and maybe their
> sizes --- although I don't think we even know the latter at the
> point where join removal would be desirable.  (And note that one of
> the desirable benefits of join removal is not having to find out the
> sizes of removed rels ... so just swapping that around doesn't appeal.)

There's probably some argument for delaying obtaining the relation
size until after join removal and probably partition pruning too, but
it's currently done well before that in build_simple_rel, where the
RelOptInfo is built.


-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 22:37  Tom Lane <[email protected]>
  parent: Thomas Munro <[email protected]>
  0 siblings, 2 replies; 991+ messages in thread

From: Tom Lane @ 2018-05-16 22:37 UTC (permalink / raw)
  To: Thomas Munro <[email protected]>; +Cc: Alexander Kuzmenkov <[email protected]>; pgsql-hackers

Thomas Munro <[email protected]> writes:
> IIUC in DB2 (the clear winner at join elimination in the article you
> mentioned), you get these sorts of things by default (optimisation
> level 5 includes it), but not if you SET CURRENT QUERY OPTIMIZATION =
> 3 as many articles recommend for OLTP work.  I think it's interesting
> that they provide that knob rather than something automatic, and
> interesting that there is one linear knob to classify your workload
> rather than N knobs for N optimisations.

There's a lot to be said for that type of approach, as opposed to trying
to drive it off some necessarily-very-inexact preliminary estimate of
query cost.  For example, the mere fact that you're joining giant tables
doesn't in itself suggest that extra efforts in query optimization will be
repaid.  (If anything, it seems more likely that the user would've avoided
silliness like useless self-joins in such a case.)

A different line of thought is that, to me, the most intellectually
defensible rationale for efforts like const-simplification and join
removal is that opportunities for those things can arise after view
expansion, even in queries where the original query text didn't seem
to contain anything extraneous.  (Robert and Andres alluded to this
upthread, but not very clearly.)  So maybe we could track how much
the query got changed during rewriting, and use that to drive the
planner's decisions about how hard to work later on.  But I'm not
very sure that this'd be superior to having a user-visible knob.

			regards, tom lane




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 22:44  Andres Freund <[email protected]>
  parent: Tom Lane <[email protected]>
  1 sibling, 0 replies; 991+ messages in thread

From: Andres Freund @ 2018-05-16 22:44 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: Thomas Munro <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

On 2018-05-16 18:37:11 -0400, Tom Lane wrote:
> Thomas Munro <[email protected]> writes:
> > IIUC in DB2 (the clear winner at join elimination in the article you
> > mentioned), you get these sorts of things by default (optimisation
> > level 5 includes it), but not if you SET CURRENT QUERY OPTIMIZATION =
> > 3 as many articles recommend for OLTP work.  I think it's interesting
> > that they provide that knob rather than something automatic, and
> > interesting that there is one linear knob to classify your workload
> > rather than N knobs for N optimisations.
> 
> There's a lot to be said for that type of approach, as opposed to trying
> to drive it off some necessarily-very-inexact preliminary estimate of
> query cost.  For example, the mere fact that you're joining giant tables
> doesn't in itself suggest that extra efforts in query optimization will be
> repaid.  (If anything, it seems more likely that the user would've avoided
> silliness like useless self-joins in such a case.)

For prepared statements we could also start making more expensive
optimizations after the first execution, when we know how long the query
took / how expensive it was (also, if we had a plan cache...).

Greetings,

Andres Freund




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 22:45  David Rowley <[email protected]>
  parent: Tom Lane <[email protected]>
  1 sibling, 0 replies; 991+ messages in thread

From: David Rowley @ 2018-05-16 22:45 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: Thomas Munro <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

On 17 May 2018 at 10:37, Tom Lane <[email protected]> wrote:
> Thomas Munro <[email protected]> writes:
>> IIUC in DB2 (the clear winner at join elimination in the article you
>> mentioned), you get these sorts of things by default (optimisation
>> level 5 includes it), but not if you SET CURRENT QUERY OPTIMIZATION =
>> 3 as many articles recommend for OLTP work.  I think it's interesting
>> that they provide that knob rather than something automatic, and
>> interesting that there is one linear knob to classify your workload
>> rather than N knobs for N optimisations.
>
> There's a lot to be said for that type of approach, as opposed to trying
> to drive it off some necessarily-very-inexact preliminary estimate of
> query cost.  For example, the mere fact that you're joining giant tables
> doesn't in itself suggest that extra efforts in query optimization will be
> repaid.  (If anything, it seems more likely that the user would've avoided
> silliness like useless self-joins in such a case.)
>
> A different line of thought is that, to me, the most intellectually
> defensible rationale for efforts like const-simplification and join
> removal is that opportunities for those things can arise after view
> expansion, even in queries where the original query text didn't seem
> to contain anything extraneous.  (Robert and Andres alluded to this
> upthread, but not very clearly.)  So maybe we could track how much
> the query got changed during rewriting, and use that to drive the
> planner's decisions about how hard to work later on.  But I'm not
> very sure that this'd be superior to having a user-visible knob.

This seems like a good line of thought.  Perhaps a knob is a good
first step, then maybe having the ability to set that knob to
"automatic" is something to aspire for later.

I don't think Alexander should work on this as part of this patch
though. Perhaps we can re-evaluate when Alexander posts some planner
benchmarks from the patch.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 22:55  Tom Lane <[email protected]>
  parent: David Rowley <[email protected]>
  0 siblings, 2 replies; 991+ messages in thread

From: Tom Lane @ 2018-05-16 22:55 UTC (permalink / raw)
  To: David Rowley <[email protected]>; +Cc: Simon Riggs <[email protected]>; Robert Haas <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

David Rowley <[email protected]> writes:
> On 17 May 2018 at 10:13, Tom Lane <[email protected]> wrote:
>> Yeah.  It'd have to be a very heuristic thing that doesn't account
>> for much beyond the number of relations in the query, and maybe their
>> sizes --- although I don't think we even know the latter at the
>> point where join removal would be desirable.  (And note that one of
>> the desirable benefits of join removal is not having to find out the
>> sizes of removed rels ... so just swapping that around doesn't appeal.)

> There's probably some argument for delaying obtaining the relation
> size until after join removal and probably partition pruning too, but
> it's currently done well before that in build_simple_rel, where the
> RelOptInfo is built.

Yeah, but that's something we ought to fix someday; IMO it's an artifact
of having wedged in remove_useless_joins without doing the extensive
refactoring that'd be needed to do it at a more desirable time.  I don't
want to build user-visible behavior that's dependent on doing that wrong.

(But wait a second ... we could improve this without quite that much work:
instead of doing estimate_rel_size immediately during get_relation_info,
couldn't it be left until the set_base_rel_sizes pass?  Since
RelationGetNumberOfBlocks involves kernel calls, skipping it for removed
rels seems worth doing.)

			regards, tom lane




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-16 23:00  Andres Freund <[email protected]>
  parent: Tom Lane <[email protected]>
  1 sibling, 1 reply; 991+ messages in thread

From: Andres Freund @ 2018-05-16 23:00 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: David Rowley <[email protected]>; Simon Riggs <[email protected]>; Robert Haas <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

On 2018-05-16 18:55:41 -0400, Tom Lane wrote:
> David Rowley <[email protected]> writes:
> > On 17 May 2018 at 10:13, Tom Lane <[email protected]> wrote:
> >> Yeah.  It'd have to be a very heuristic thing that doesn't account
> >> for much beyond the number of relations in the query, and maybe their
> >> sizes --- although I don't think we even know the latter at the
> >> point where join removal would be desirable.  (And note that one of
> >> the desirable benefits of join removal is not having to find out the
> >> sizes of removed rels ... so just swapping that around doesn't appeal.)
> 
> > There's probably some argument for delaying obtaining the relation
> > size until after join removal and probably partition pruning too, but
> > it's currently done well before that in build_simple_rel, where the
> > RelOptInfo is built.
> 
> Yeah, but that's something we ought to fix someday; IMO it's an artifact
> of having wedged in remove_useless_joins without doing the extensive
> refactoring that'd be needed to do it at a more desirable time.  I don't
> want to build user-visible behavior that's dependent on doing that wrong.

My patch that introduced a radix tree buffer mapping also keeps an
accurate relation size in memory, making it far cheaper to use. While I
depriorized the patchset for the moment (I'll post what I'm working on
first soon), that should address some of the cost till then.

Wonder if we shouldn't just cache an estimated relation size in the
relcache entry till then. For planning purposes we don't need to be
accurate, and usually activity that drastically expands relation size
will trigger relcache activity before long. Currently there's plenty
workloads where the lseeks(SEEK_END) show up pretty prominently.

Greetings,

Andres Freund




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-17 01:33  David Rowley <[email protected]>
  parent: Tom Lane <[email protected]>
  1 sibling, 0 replies; 991+ messages in thread

From: David Rowley @ 2018-05-17 01:33 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: Simon Riggs <[email protected]>; Robert Haas <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

On 17 May 2018 at 10:55, Tom Lane <[email protected]> wrote:
> David Rowley <[email protected]> writes:
>> There's probably some argument for delaying obtaining the relation
>> size until after join removal and probably partition pruning too, but
>> it's currently done well before that in build_simple_rel, where the
>> RelOptInfo is built.
>
> Yeah, but that's something we ought to fix someday; IMO it's an artifact
> of having wedged in remove_useless_joins without doing the extensive
> refactoring that'd be needed to do it at a more desirable time.  I don't
> want to build user-visible behavior that's dependent on doing that wrong.
>
> (But wait a second ... we could improve this without quite that much work:
> instead of doing estimate_rel_size immediately during get_relation_info,
> couldn't it be left until the set_base_rel_sizes pass?  Since
> RelationGetNumberOfBlocks involves kernel calls, skipping it for removed
> rels seems worth doing.)

I did mean just obtaining the sizes, not delaying building the
RelOptInfo. I see nothing that needs RelOptInfo->pages before
set_base_rel_size apart from the code which I mentioned about moving a
couple of days ago in [1].

[1] https://www.postgresql.org/message-id/CAKJS1f_eUz0_h5_vU1rqE7wuxMcoENcWK2FTODz0pOyxp3_Uig%40mail.gma...

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-17 01:38  David Rowley <[email protected]>
  parent: Andres Freund <[email protected]>
  0 siblings, 1 reply; 991+ messages in thread

From: David Rowley @ 2018-05-17 01:38 UTC (permalink / raw)
  To: Andres Freund <[email protected]>; +Cc: Tom Lane <[email protected]>; Simon Riggs <[email protected]>; Robert Haas <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

On 17 May 2018 at 11:00, Andres Freund <[email protected]> wrote:
> Wonder if we shouldn't just cache an estimated relation size in the
> relcache entry till then. For planning purposes we don't need to be
> accurate, and usually activity that drastically expands relation size
> will trigger relcache activity before long. Currently there's plenty
> workloads where the lseeks(SEEK_END) show up pretty prominently.

While I'm in favour of speeding that up, I think we'd get complaints
if we used a stale value.  We could have uses pg_class.relpages all
along, but it would cause the planner to not work so well in face of
the relation changing size significantly between analyze runs.

FWIW the major case where that does show up is when generating a plan
for a partitioned table with many partitions then pruning all but a
few of them.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-17 02:11  Tom Lane <[email protected]>
  parent: David Rowley <[email protected]>
  0 siblings, 1 reply; 991+ messages in thread

From: Tom Lane @ 2018-05-17 02:11 UTC (permalink / raw)
  To: David Rowley <[email protected]>; +Cc: Andres Freund <[email protected]>; Simon Riggs <[email protected]>; Robert Haas <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

David Rowley <[email protected]> writes:
> On 17 May 2018 at 11:00, Andres Freund <[email protected]> wrote:
>> Wonder if we shouldn't just cache an estimated relation size in the
>> relcache entry till then. For planning purposes we don't need to be
>> accurate, and usually activity that drastically expands relation size
>> will trigger relcache activity before long. Currently there's plenty
>> workloads where the lseeks(SEEK_END) show up pretty prominently.

> While I'm in favour of speeding that up, I think we'd get complaints
> if we used a stale value.

Yeah, that scares me too.  We'd then be in a situation where (arguably)
any relation extension should force a relcache inval.  Not good.
I do not buy Andres' argument that the value is noncritical, either ---
particularly during initial population of a table, where the size could
go from zero to something-significant before autoanalyze gets around
to noticing.

I'm a bit skeptical of the idea of maintaining an accurate relation
size in shared memory, too.  AIUI, a lot of the problem we see with
lseek(SEEK_END) has to do with contention inside the kernel for access
to the single-point-of-truth where the file's size is kept.  Keeping
our own copy would eliminate kernel-call overhead, which can't hurt,
but it won't improve the contention angle.

			regards, tom lane




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-17 02:19  Andres Freund <[email protected]>
  parent: Tom Lane <[email protected]>
  0 siblings, 1 reply; 991+ messages in thread

From: Andres Freund @ 2018-05-17 02:19 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: David Rowley <[email protected]>; Simon Riggs <[email protected]>; Robert Haas <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

On 2018-05-16 22:11:22 -0400, Tom Lane wrote:
> David Rowley <[email protected]> writes:
> > On 17 May 2018 at 11:00, Andres Freund <[email protected]> wrote:
> >> Wonder if we shouldn't just cache an estimated relation size in the
> >> relcache entry till then. For planning purposes we don't need to be
> >> accurate, and usually activity that drastically expands relation size
> >> will trigger relcache activity before long. Currently there's plenty
> >> workloads where the lseeks(SEEK_END) show up pretty prominently.
> 
> > While I'm in favour of speeding that up, I think we'd get complaints
> > if we used a stale value.
> 
> Yeah, that scares me too.  We'd then be in a situation where (arguably)
> any relation extension should force a relcache inval.  Not good.
> I do not buy Andres' argument that the value is noncritical, either ---
> particularly during initial population of a table, where the size could
> go from zero to something-significant before autoanalyze gets around
> to noticing.

I don't think every extension needs to force a relcache inval. It'd
instead be perfectly reasonable to define a rule that an inval is
triggered whenever crossing a 10% relation size boundary. Which'll lead
to invalidations for the first few pages, but much less frequently
later.


> I'm a bit skeptical of the idea of maintaining an accurate relation
> size in shared memory, too.  AIUI, a lot of the problem we see with
> lseek(SEEK_END) has to do with contention inside the kernel for access
> to the single-point-of-truth where the file's size is kept.  Keeping
> our own copy would eliminate kernel-call overhead, which can't hurt,
> but it won't improve the contention angle.

A syscall is several hundred instructions. An unlocked read - which'll
be be sufficient in many cases, given that the value can quickly be out
of date anyway - is a few cycles. Even with a barrier you're talking a
few dozen cycles.  So I can't see how it'd not improve the contention.

But the main reason for keeping it in shmem is less the lseek avoidance
- although that's nice, context switches aren't great - but to make
relation extension need far less locking.

Greetings,

Andres Freund




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-17 08:15  Konstantin Knizhnik <[email protected]>
  parent: Andres Freund <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Konstantin Knizhnik @ 2018-05-17 08:15 UTC (permalink / raw)
  To: [email protected]



On 17.05.2018 05:19, Andres Freund wrote:
> On 2018-05-16 22:11:22 -0400, Tom Lane wrote:
>> David Rowley <[email protected]> writes:
>>> On 17 May 2018 at 11:00, Andres Freund <[email protected]> wrote:
>>>> Wonder if we shouldn't just cache an estimated relation size in the
>>>> relcache entry till then. For planning purposes we don't need to be
>>>> accurate, and usually activity that drastically expands relation size
>>>> will trigger relcache activity before long. Currently there's plenty
>>>> workloads where the lseeks(SEEK_END) show up pretty prominently.
>>> While I'm in favour of speeding that up, I think we'd get complaints
>>> if we used a stale value.
>> Yeah, that scares me too.  We'd then be in a situation where (arguably)
>> any relation extension should force a relcache inval.  Not good.
>> I do not buy Andres' argument that the value is noncritical, either ---
>> particularly during initial population of a table, where the size could
>> go from zero to something-significant before autoanalyze gets around
>> to noticing.
> I don't think every extension needs to force a relcache inval. It'd
> instead be perfectly reasonable to define a rule that an inval is
> triggered whenever crossing a 10% relation size boundary. Which'll lead
> to invalidations for the first few pages, but much less frequently
> later.
>
>
>> I'm a bit skeptical of the idea of maintaining an accurate relation
>> size in shared memory, too.  AIUI, a lot of the problem we see with
>> lseek(SEEK_END) has to do with contention inside the kernel for access
>> to the single-point-of-truth where the file's size is kept.  Keeping
>> our own copy would eliminate kernel-call overhead, which can't hurt,
>> but it won't improve the contention angle.
> A syscall is several hundred instructions. An unlocked read - which'll
> be be sufficient in many cases, given that the value can quickly be out
> of date anyway - is a few cycles. Even with a barrier you're talking a
> few dozen cycles.  So I can't see how it'd not improve the contention.
>
> But the main reason for keeping it in shmem is less the lseek avoidance
> - although that's nice, context switches aren't great - but to make
> relation extension need far less locking.
>
> Greetings,
>
> Andres Freund
>

I completely agree with Andreas. In my multithreaded Postgres prototype 
file description cache (shared by all threads) becomes bottleneck 
exactly because of each query execution requires
access to file system (lseek) to provide optimizer estimation of the 
relation size, despite to the fact that all database fits in memory.
Well, this is certainly specific of shared descriptor's pool in my 
prototype, but the fact the we have to perform lseek at each query 
compilation seems to be annoying in any case.

And there is really no problem that cached relation size estimation is 
not precise.  It really can be invalidated even if relation size is 
changed more than some threshold value (1Mb?) or lease time for cached 
value is expired.
May be it is reasonable to implement specific invalidation for relation 
size esimation, to avoid complete invalidation and reconstruction of 
relation description and all dependent objects.
In this case time-based invalidation seems to be the easiest choice to 
implement. Repeating lseek each 10 or 1 second seems to have no 
noticeable impact on performance and relation size can not dramatically 
changed during this time.



-- 
Konstantin Knizhnik
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company





^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-05-18 19:47  Robert Haas <[email protected]>
  parent: Tom Lane <[email protected]>
  1 sibling, 0 replies; 991+ messages in thread

From: Robert Haas @ 2018-05-18 19:47 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: David Rowley <[email protected]>; Simon Riggs <[email protected]>; Alexander Kuzmenkov <[email protected]>; pgsql-hackers

On Wed, May 16, 2018 at 6:13 PM, Tom Lane <[email protected]> wrote:
> David Rowley <[email protected]> writes:
>> On 17 May 2018 at 08:44, Simon Riggs <[email protected]> wrote:
>>> What I was advocating was an approach that varies according to the
>>> query cost, so we don't waste time trying to tune the heck out of OLTP
>>> queries, but for larger queries we might take a more considered
>>> approach.
>
>> That's tricky. If we do this, it should be done before Path
>> generation, so not much is known about the costs in those case.
>
> Yeah.  It'd have to be a very heuristic thing that doesn't account
> for much beyond the number of relations in the query, and maybe their
> sizes --- although I don't think we even know the latter at the
> point where join removal would be desirable.  (And note that one of
> the desirable benefits of join removal is not having to find out the
> sizes of removed rels ... so just swapping that around doesn't appeal.)

As I've mentioned before, the problem we're talking about here is also
highly relevant to parallel query.  We only want to bother generating
partial paths for queries that are expensive enough to justify
considering parallelism, but we don't know how expensive they are
until we finishing planning.  The only way I could think of to tackle
that problem was to drive it off the relation sizes, but the presence
or absence of expensive functions in the target list can wildly change
the point at which parallelism potentially becomes useful.  So we end
up sometimes wasting effort generating partial paths that are totally
useless, and at other times failing to generate partial paths that
would have been useful.  (Really, I'd like to generate a lot more
partial paths than we do, trying out various numbers of workers, but
that would just make the existing problem worse.)

I have wondered about doing a preliminary pass over the tree where we
try to make a crude estimate of the amount of effort involved, and
then planning for real with that number in hand.  But it seems like
there's so little information you could get at that early stage that
it would be hard to decide anything useful on that basis.  You've got
to at least have relation sizes, and really you need some estimate of
the result cardinality as well.  It seems like we currently can't
figure out cardinality without also computing paths, and I've wondered
if we could split those into two separate phases.  But every time I
think about trying to do that I realize that my pain tolerance isn't
that high.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* Re: Removing unneeded self joins
@ 2018-06-25 15:26  Alexander Kuzmenkov <[email protected]>
  parent: David Rowley <[email protected]>
  1 sibling, 0 replies; 991+ messages in thread

From: Alexander Kuzmenkov @ 2018-06-25 15:26 UTC (permalink / raw)
  To: David Rowley <[email protected]>; +Cc: pgsql-hackers

David,

I tried to implement your suggestions, here are the patches.

The first patch mostly moves some code around without changing 
functionality. It modifies innerrel_is_unique to not only cache the fact 
that the relation is unique, but also
cache the index that guarantees uniqueness.

The second patch adds the unique self join removal code. It goes along 
the lines of your plan. I didn't even have to examine join clauses 
because the constraints imposed by innerrel_is_unique are strong enough 
to guarantee that when it finds the same unique index for both 
relations, the join can be removed. Namely, it requires mergejoinable 
equality clauses for all columns of a unique index.

As a simple benchmark, I measured the duration of query_planner and 
remove_useless_self_joins with clock_gettime() on the regression tests. 
The following table shows average times in microseconds, median over 11 
runs. First row is with this patch, and the second row doesn't call 
remove_useless_self_joins and just calls clock_gettime to measure its 
overhead.

               query_planner  remove_useless_self_joins

with removal       39.61            0.61

no removal         39.45            0.38


So, on this workload, unique self join removal adds about 0.2 mcs, or 
0.6% of total time, to query_planner. I also tried a query that joins 26 
relations, remove_useless_self_joins takes about 40 mcs. Still, this 
time grows quadratically with number of relations we have to process, so 
in the final patch I limit it to join_collapse_limit, which brings the 
time down to 15 mcs. This is negligible compared to the total 
query_planner time, which for 8 relations is about 3 ms, that is, 3 
orders of magnitude higher.

These benchmarks mostly measure the path where we don't remove any 
joins. I didn't time the join removal itself, because it wins quite some 
time by allowing to plan one relation and one join less.

-- 
Alexander Kuzmenkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread

* [PATCH 5/9] document store_change somewhat more
@ 2026-03-12 15:10  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 991+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:10 UTC (permalink / raw)

---
 .../replication/pgoutput_repack/pgoutput_repack.c        | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 90f3a8975b9..79fc611b9ff 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -158,7 +158,14 @@ plugin_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 	}
 }
 
-/* Store concurrent data change. */
+/*
+ * For each change affecting the table being repacked, we store enough
+ * information about each tuple in it, so that it can be replayed in the
+ * new copy of the table.
+ *
+ * XXX for DELETE and the UPDATE OLD tuples, we could store just the
+ * replication identity instead of the full tuple.
+ */
 static void
 store_change(LogicalDecodingContext *ctx, Relation relation,
 			 ConcurrentChangeKind kind, HeapTuple tuple)
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename*0="0006-use-int-instead-of-uint32-for-the-result-of-list_len.noc";
	filename*1="fbot.txt"



^ permalink  raw  reply  [nested|flat] 991+ messages in thread