agora inbox for pgsql-hackers@postgresql.orghelp / color / mirror / Atom feed
[PATCH] Turn protective Assert() into elog(ERROR) 1+ messages / 1 participants [nested] [flat]
* [PATCH] Turn protective Assert() into elog(ERROR) @ 2026-05-01 07:23 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 1+ messages in thread From: Álvaro Herrera @ 2026-05-01 07:23 UTC (permalink / raw) --- src/backend/access/index/genam.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/backend/access/index/genam.c b/src/backend/access/index/genam.c index 97d44b84622..7d401e3f137 100644 --- a/src/backend/access/index/genam.c +++ b/src/backend/access/index/genam.c @@ -396,11 +396,13 @@ systable_beginscan(Relation heapRelation, /* * If this backend promised that it won't access shared catalogs during - * logical decoding, this it the right place to verify. + * logical decoding, this is the right place to verify. */ - Assert(!HistoricSnapshotActive() || - accessSharedCatalogsInDecoding || - !heapRelation->rd_rel->relisshared); + if (HistoricSnapshotActive() && + !accessSharedCatalogsInDecoding && + heapRelation->rd_rel->relisshared) + elog(ERROR, + "cannot access shared catalog with database-specific historic snapshot"); if (indexOK && !IgnoreSystemIndexes && -- 2.47.3 --k6vxbflu22czkb7a-- ^ permalink raw reply [nested|flat] 1+ messages in thread
only message in thread Thread overview: 1+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-05-01 07:23 [PATCH] Turn protective Assert() into elog(ERROR) Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox