agora inbox for [email protected]
help / color / mirror / Atom feedPostgreSQL Weekly News Survey
968+ messages / 2 participants
[nested] [flat]
* PostgreSQL Weekly News Survey
@ 2016-05-30 15:38 David Fetter <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: David Fetter @ 2016-05-30 15:38 UTC (permalink / raw)
To: PostgreSQL Announce <[email protected]>; +Cc: pgsql-hackers
Folks,
In lieu of the weekly news this week, I'd like to as you to help
improve the PostgreSQL Weekly News by participating in this survey.
http://goo.gl/forms/Q6FPPwzPG3Zq66pC2
Thanks in advance, and please let me know if you have any trouble
reaching or using the survey.
Cheers,
David.
--
David Fetter <[email protected]> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: [email protected]
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 968+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 968+ messages in thread
end of thread, other threads:[~2026-03-12 15:09 UTC | newest]
Thread overview: 968+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-05-30 15:38 PostgreSQL Weekly News Survey David Fetter <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox