agora inbox for [email protected]
help / color / mirror / Atom feedserver vs foreign server inconsistency
970+ messages / 3 participants
[nested] [flat]
* server vs foreign server inconsistency
@ 2014-04-14 15:45 Jaime Casanova <[email protected]>
0 siblings, 1 reply; 970+ messages in thread
From: Jaime Casanova @ 2014-04-14 15:45 UTC (permalink / raw)
To: pgsql-hackers
Hi,
A few days ago i was wondering why we use CREATE/DROP SERVER but then
when we want to GRANT/REVOKE we need to use FOREIGN SERVER.
of course options are:
1) modify both to accept both forms
2) modify one of them to accept both forms and use that way in all our
examples in docs
3) do nothing at all
IMHO i think 3 is not acceptable because it's annoying
opinions?
--
Jaime Casanova www.2ndQuadrant.com
Professional PostgreSQL: Soporte 24x7 y capacitación
Phone: +593 4 5107566 Cell: +593 987171157
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 970+ messages in thread
* Re: server vs foreign server inconsistency
@ 2014-04-14 15:54 Tom Lane <[email protected]>
parent: Jaime Casanova <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Tom Lane @ 2014-04-14 15:54 UTC (permalink / raw)
To: Jaime Casanova <[email protected]>; +Cc: pgsql-hackers
Jaime Casanova <[email protected]> writes:
> A few days ago i was wondering why we use CREATE/DROP SERVER but then
> when we want to GRANT/REVOKE we need to use FOREIGN SERVER.
Because the SQL standard says so.
regards, tom lane
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12 Álvaro Herrera <[email protected]>
0 siblings, 0 replies; 970+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 2 +-
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
uint32 t_len;
HeapTuple tup;
MemoryContext oldcxt;
- uint32 natt_ext;
+ int natt_ext;
List *attrs_ext = NIL;
oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
BufFile *file;
char kind_byte = (char) kind;
List *attrs_ext = NIL;
- uint32 natt_ext;
+ int natt_ext;
dstate = (RepackDecodingState *) ctx->output_writer_private;
file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
}
}
- natt_ext = list_length(attrs_ext);
}
- else
- natt_ext = 0;
/* Write the number of external attributes. */
+ natt_ext = list_length(attrs_ext);
BufFileWrite(file, &natt_ext, sizeof(natt_ext));
- /* ... and the attributes themselves, if there are some. */
+ /* ... and the attributes themselves, if any */
foreach_ptr(varlena, attr_val, attrs_ext)
{
varlena *ext_val;
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"
^ permalink raw reply [nested|flat] 970+ messages in thread
end of thread, other threads:[~2026-03-12 15:12 UTC | newest]
Thread overview: 970+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2014-04-14 15:45 server vs foreign server inconsistency Jaime Casanova <[email protected]>
2014-04-14 15:54 ` Tom Lane <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox