public inbox for [email protected]
help / color / mirror / Atom feedFrom: Álvaro Herrera <[email protected]>
Subject: [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
Date: Thu, 12 Mar 2026 16:14:30 +0100
---
src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
attrs = palloc_array(Datum, desc->natts);
isnull = palloc_array(bool, desc->natts);
+ /*
+ * XXX it might be better to use slot_deform_tuple here, for the case
+ * where atttributes near the end of the tuple don't need to undergo
+ * this procedure.
+ */
heap_deform_tuple(tuple, desc, attrs, isnull);
- /* First, gather and count the "external indirect" attributes. */
+ /* First, gather all the "external indirect" attributes. */
for (int i = 0; i < desc->natts; i++)
{
CompactAttribute *attr = TupleDescCompactAttr(desc, i);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"
view thread (750+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
In-Reply-To: <no-message-id-1544354@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox