agora inbox for [email protected]  

help / color / mirror / Atom feed

From: Justin Pryzby <[email protected]>
Subject: [PATCH 8/9] fix! Subscripting documentation
Date: Sun, 19 Jul 2020 13:24:42 -0500

---
 doc/src/sgml/json.sgml            | 6 +++---
 doc/src/sgml/ref/create_type.sgml | 2 +-
 doc/src/sgml/xsubscripting.sgml   | 8 ++++----
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/doc/src/sgml/json.sgml b/doc/src/sgml/json.sgml
index 3bffe8049b..5c538dca05 100644
--- a/doc/src/sgml/json.sgml
+++ b/doc/src/sgml/json.sgml
@@ -606,8 +606,8 @@ SELECT jdoc-&gt;'guid', jdoc-&gt;'name' FROM api WHERE jdoc @&gt; '{"tags": ["qu
   <title><type>jsonb</type> Subscripting</title>
   <para>
    <type>jsonb</type> data type supports array-style subscripting expressions
-   to extract or update particular element. It's possible to use multiple
-   subscripting expressions to extract nested values. In this case a chain of
+   to extract or update particular elements. It's possible to use multiple
+   subscripting expressions to extract nested values. In this case, a chain of
    subscripting expressions follows the same rules as the
    <literal>path</literal> argument in <literal>jsonb_set</literal> function,
    e.g. in case of arrays it is a 0-based operation or that negative integers
@@ -634,7 +634,7 @@ SELECT * FROM table_name WHERE jsonb_field['key'] = '"value"';
 </programlisting>
 
   There is no special indexing support for such kind of expressions, but you
-  always can create a functional index that includes it
+  can always create a functional index that includes it
 <programlisting>
 CREATE INDEX idx ON table_name ((jsonb_field['key']));
 </programlisting>
diff --git a/doc/src/sgml/ref/create_type.sgml b/doc/src/sgml/ref/create_type.sgml
index ec67761c66..a34df4d247 100644
--- a/doc/src/sgml/ref/create_type.sgml
+++ b/doc/src/sgml/ref/create_type.sgml
@@ -470,7 +470,7 @@ CREATE TYPE <replaceable class="parameter">name</replaceable>
    and jsonb
    (<replaceable class="parameter">jsonb_subscripting_handler</replaceable>)
    types in <filename>src/backend/utils/adt/arrayfuncs.c</filename> and
-   <filename>src/backend/utils/adt/jsonfuncs.c</filename> corresponding.
+   <filename>src/backend/utils/adt/jsonfuncs.c</filename>, respectively.
   </para>
   </refsect2>
 
diff --git a/doc/src/sgml/xsubscripting.sgml b/doc/src/sgml/xsubscripting.sgml
index d701631223..7224e81fa2 100644
--- a/doc/src/sgml/xsubscripting.sgml
+++ b/doc/src/sgml/xsubscripting.sgml
@@ -7,8 +7,8 @@
     <primary>custom subscripting</primary>
   </indexterm>
   <para>
-  When you define a new base type, you can also specify a custom procedures to
-  handle subscripting expressions. They must contain logic for verification and
+  When you define a new base type, you can also specify a custom procedure to
+  handle subscripting expressions. It must contain logic for verification and
   evaluation of this expression, i.e. fetching or updating some data in this
   data type. For instance:
 </para>
@@ -63,12 +63,12 @@ custom_subscript_assign(Datum containerSource, SubscriptingRefState *sbstate)
 Datum
 custom_subscript_fetch(Datum containerSource, SubscriptingRefState *sbstate)
 {
-    // Some fetch logic based on sbsdata
+    // Some fetch logic based on sbstate
 }]]>
 </programlisting>
 
 <para>
-    Then you can define a subscripting procedures and a custom data type:
+    Then you can define a subscripting procedure and a custom data type:
 </para>
 <programlisting>
 CREATE FUNCTION custom_subscripting_handler(internal)
-- 
2.17.0


--ZcSDOt7TZFizttpn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
 filename=0009-fix-Base-implementation-of-subscripting-mechanismtxt

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [PATCH 8/9] fix! Subscripting documentation
  In-Reply-To: <no-message-id-180284@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox