public inbox for [email protected]  
help / color / mirror / Atom feed
From: Bertrand Drouvot <[email protected]>
Subject: [PATCH v1] Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()
Date: Fri, 27 Feb 2026 03:27:46 +0000

Standard practice in PostgreSQL is to use "foo(void)" instead of "foo()", as the
latter looks like an "old-style" function declaration. 9b05e2ec08a did fix
all the ones reported by -Wstrict-prototypes.

af2d4ca191a4 introduced a new one, this commit fixes it.

Author: Bertrand Drouvot <[email protected]>
Reviewed-by:
Discussion: https://postgr.es/m/
---
 src/backend/utils/adt/pg_locale.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 100.0% src/backend/utils/adt/

diff --git a/src/backend/utils/adt/pg_locale.c b/src/backend/utils/adt/pg_locale.c
index ac324ecaad2..6c5c1019e1e 100644
--- a/src/backend/utils/adt/pg_locale.c
+++ b/src/backend/utils/adt/pg_locale.c
@@ -1650,7 +1650,7 @@ pg_towlower(pg_wchar wc, pg_locale_t locale)
 
 /* version of Unicode used by ICU */
 const char *
-pg_icu_unicode_version()
+pg_icu_unicode_version(void)
 {
 #ifdef USE_ICU
 	return U_UNICODE_VERSION;
-- 
2.34.1


--D6058a7DswGNtGTg--





view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [PATCH v1] Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()
  In-Reply-To: <no-message-id-1835971@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox