public inbox for [email protected]
help / color / mirror / Atom feed[PATCH v8 8/8] Update comment obsolete since 69c3936a
8+ messages / 3 participants
[nested] [flat]
* [PATCH v8 8/8] Update comment obsolete since 69c3936a
@ 2020-02-15 21:53 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 8+ messages in thread
From: Justin Pryzby @ 2020-02-15 21:53 UTC (permalink / raw)
---
src/backend/executor/nodeAgg.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/backend/executor/nodeAgg.c b/src/backend/executor/nodeAgg.c
index 4cd09e2291..68fe4d3591 100644
--- a/src/backend/executor/nodeAgg.c
+++ b/src/backend/executor/nodeAgg.c
@@ -2025,8 +2025,7 @@ lookup_hash_entry(AggState *aggstate, uint32 hash)
}
/*
- * Look up hash entries for the current tuple in all hashed grouping sets,
- * returning an array of pergroup pointers suitable for advance_aggregates.
+ * Look up hash entries for the current tuple in all hashed grouping sets.
*
* Be aware that lookup_hash_entry can reset the tmpcontext.
*
--
2.17.0
--ZljC5FVPx7rxDQQ8--
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: cfbot failures
@ 2023-02-20 01:18 Andres Freund <[email protected]>
0 siblings, 0 replies; 8+ messages in thread
From: Andres Freund @ 2023-02-20 01:18 UTC (permalink / raw)
To: Justin Pryzby <[email protected]>; Nazir Bilal Yavuz <[email protected]>; +Cc: [email protected]; Thomas Munro <[email protected]>
Hi,
On 2023-02-19 19:08:41 -0600, Justin Pryzby wrote:
> On 2023-02-11, Andres Freund wrote [email protected]:
> > The windows test failure is a transient issue independent of the patch
> > (something went wrong with image permissions).
>
> That's happening again since 3h ago.
> https://cirrus-ci.com/github/postgresql-cfbot/postgresql
Fixed manually. This is some sort of gcp issue. Bilal tried to deploy a
workaround, but that didn't yet work.
[21:39:06.006] 2023-02-19T21:39:06Z: ==> windows.googlecompute.windows-ci-vs-2019: Creating image...
[21:44:08.025] 2023-02-19T21:44:08Z: ==> windows.googlecompute.windows-ci-vs-2019: Error waiting for image: time out while waiting for image to register
...
[21:44:10.990] gcloud compute images deprecate pg-ci-${CIRRUS_TASK_NAME}-${DATE} --state=DEPRECATED
[21:44:33.834] ERROR: (gcloud.compute.images.deprecate) Could not fetch resource:
[21:44:33.834] - Required 'compute.images.deprecate' permission for 'projects/cirrus-ci-community/global/images/pg-ci-windows-ci-vs-2019-2023-02-19t21-30-43'
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 8+ messages in thread
* [PATCH v3 1/1] Add hint message for check_log_destination
@ 2023-07-07 07:48 Japin Li <[email protected]>
0 siblings, 0 replies; 8+ messages in thread
From: Japin Li @ 2023-07-07 07:48 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 5898100acb..a7545dcbd9 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2228,8 +2228,22 @@ check_log_destination(char **newval, void **extra, GucSource source)
#endif
else
{
+ StringInfoData errhint;
+
+ initStringInfo(&errhint);
+ appendStringInfoString(&errhint, "\"stderr\"");
+#ifdef HAVE_SYSLOG
+ appendStringInfoString(&errhint, ", \"syslog\"");
+#endif
+#ifdef WIN32
+ appendStringInfoString(&errhint, ", \"eventlog\"");
+#endif
+ appendStringInfoString(&errhint, ", \"csvlog\", and \"jsonlog\"");
+
GUC_check_errdetail("Unrecognized key word: \"%s\".", tok);
+ GUC_check_errhint("Valid values are combinations of %s.", errhint.data);
pfree(rawstring);
+ pfree(errhint.data);
list_free(elemlist);
return false;
}
--
2.25.1
--=-=-=
Content-Type: text/plain
--
Regrads,
Japin Li.
--=-=-=--
^ permalink raw reply [nested|flat] 8+ messages in thread
* [PATCH v2 1/1] Add hint message for check_log_destination
@ 2023-07-07 07:48 Japin Li <[email protected]>
0 siblings, 0 replies; 8+ messages in thread
From: Japin Li @ 2023-07-07 07:48 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 5898100acb..a32f9613be 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2228,8 +2228,22 @@ check_log_destination(char **newval, void **extra, GucSource source)
#endif
else
{
+ StringInfoData errhint;
+
+ initStringInfo(&errhint);
+ appendStringInfo(&errhint, "\"stderr\"");
+#ifdef HAVE_SYSLOG
+ appendStringInfo(&errhint, ", \"syslog\"");
+#endif
+#ifdef WIN32
+ appendStringInfo(&errhint, ", \"eventlog\"");
+#endif
+ appendStringInfo(&errhint, ", \"csvlog\", and \"jsonlog\"");
+
GUC_check_errdetail("Unrecognized key word: \"%s\".", tok);
+ GUC_check_errhint("Valid values are combinations of %s.", errhint.data);
pfree(rawstring);
+ pfree(errhint.data);
list_free(elemlist);
return false;
}
--
2.25.1
--=-=-=--
^ permalink raw reply [nested|flat] 8+ messages in thread
* [PATCH v3 1/1] Add hint message for check_log_destination
@ 2023-07-07 07:48 Japin Li <[email protected]>
0 siblings, 0 replies; 8+ messages in thread
From: Japin Li @ 2023-07-07 07:48 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 5898100acb..a7545dcbd9 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2228,8 +2228,22 @@ check_log_destination(char **newval, void **extra, GucSource source)
#endif
else
{
+ StringInfoData errhint;
+
+ initStringInfo(&errhint);
+ appendStringInfoString(&errhint, "\"stderr\"");
+#ifdef HAVE_SYSLOG
+ appendStringInfoString(&errhint, ", \"syslog\"");
+#endif
+#ifdef WIN32
+ appendStringInfoString(&errhint, ", \"eventlog\"");
+#endif
+ appendStringInfoString(&errhint, ", \"csvlog\", and \"jsonlog\"");
+
GUC_check_errdetail("Unrecognized key word: \"%s\".", tok);
+ GUC_check_errhint("Valid values are combinations of %s.", errhint.data);
pfree(rawstring);
+ pfree(errhint.data);
list_free(elemlist);
return false;
}
--
2.25.1
--=-=-=
Content-Type: text/plain
--
Regrads,
Japin Li.
--=-=-=--
^ permalink raw reply [nested|flat] 8+ messages in thread
* [PATCH v2 1/1] Add hint message for check_log_destination
@ 2023-07-07 07:48 Japin Li <[email protected]>
0 siblings, 0 replies; 8+ messages in thread
From: Japin Li @ 2023-07-07 07:48 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 5898100acb..a32f9613be 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2228,8 +2228,22 @@ check_log_destination(char **newval, void **extra, GucSource source)
#endif
else
{
+ StringInfoData errhint;
+
+ initStringInfo(&errhint);
+ appendStringInfo(&errhint, "\"stderr\"");
+#ifdef HAVE_SYSLOG
+ appendStringInfo(&errhint, ", \"syslog\"");
+#endif
+#ifdef WIN32
+ appendStringInfo(&errhint, ", \"eventlog\"");
+#endif
+ appendStringInfo(&errhint, ", \"csvlog\", and \"jsonlog\"");
+
GUC_check_errdetail("Unrecognized key word: \"%s\".", tok);
+ GUC_check_errhint("Valid values are combinations of %s.", errhint.data);
pfree(rawstring);
+ pfree(errhint.data);
list_free(elemlist);
return false;
}
--
2.25.1
--=-=-=--
^ permalink raw reply [nested|flat] 8+ messages in thread
* [PATCH v4 1/1] Add hint message for check_log_destination
@ 2023-07-14 01:26 Japin Li <[email protected]>
0 siblings, 0 replies; 8+ messages in thread
From: Japin Li @ 2023-07-14 01:26 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 5898100acb..dccbabf40a 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2228,8 +2228,22 @@ check_log_destination(char **newval, void **extra, GucSource source)
#endif
else
{
+ StringInfoData errhint;
+
+ initStringInfo(&errhint);
+ appendStringInfoString(&errhint, "stderr");
+#ifdef HAVE_SYSLOG
+ appendStringInfoString(&errhint, ", syslog");
+#endif
+#ifdef WIN32
+ appendStringInfoString(&errhint, ", eventlog");
+#endif
+ appendStringInfoString(&errhint, ", csvlog, and jsonlog");
+
GUC_check_errdetail("Unrecognized key word: \"%s\".", tok);
+ GUC_check_errhint("Valid values are combinations of %s.", errhint.data);
pfree(rawstring);
+ pfree(errhint.data);
list_free(elemlist);
return false;
}
--
2.41.0
--=-=-=--
^ permalink raw reply [nested|flat] 8+ messages in thread
* [PATCH v4 1/1] Add hint message for check_log_destination
@ 2023-07-14 01:26 Japin Li <[email protected]>
0 siblings, 0 replies; 8+ messages in thread
From: Japin Li @ 2023-07-14 01:26 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 5898100acb..dccbabf40a 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2228,8 +2228,22 @@ check_log_destination(char **newval, void **extra, GucSource source)
#endif
else
{
+ StringInfoData errhint;
+
+ initStringInfo(&errhint);
+ appendStringInfoString(&errhint, "stderr");
+#ifdef HAVE_SYSLOG
+ appendStringInfoString(&errhint, ", syslog");
+#endif
+#ifdef WIN32
+ appendStringInfoString(&errhint, ", eventlog");
+#endif
+ appendStringInfoString(&errhint, ", csvlog, and jsonlog");
+
GUC_check_errdetail("Unrecognized key word: \"%s\".", tok);
+ GUC_check_errhint("Valid values are combinations of %s.", errhint.data);
pfree(rawstring);
+ pfree(errhint.data);
list_free(elemlist);
return false;
}
--
2.41.0
--=-=-=--
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2023-07-14 01:26 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-02-15 21:53 [PATCH v8 8/8] Update comment obsolete since 69c3936a Justin Pryzby <[email protected]>
2023-02-20 01:18 Re: cfbot failures Andres Freund <[email protected]>
2023-07-07 07:48 [PATCH v2 1/1] Add hint message for check_log_destination Japin Li <[email protected]>
2023-07-07 07:48 [PATCH v3 1/1] Add hint message for check_log_destination Japin Li <[email protected]>
2023-07-07 07:48 [PATCH v2 1/1] Add hint message for check_log_destination Japin Li <[email protected]>
2023-07-07 07:48 [PATCH v3 1/1] Add hint message for check_log_destination Japin Li <[email protected]>
2023-07-14 01:26 [PATCH v4 1/1] Add hint message for check_log_destination Japin Li <[email protected]>
2023-07-14 01:26 [PATCH v4 1/1] Add hint message for check_log_destination Japin Li <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox