agora inbox for [email protected]  
help / color / mirror / Atom feed
From: Masahiro Ikeda <[email protected]>
Subject: [PATCH 3/3] Add docs to define custom wait events
Date: Thu, 15 Jun 2023 13:16:00 +0900

> +    <para>
> +     wait events are reserved by calling:
> +<programlisting>
> +void RequestNamedExtensionWaitEventTranche(const char *tranche_name)
> +</programlisting>
> +     from your <literal>shmem_request_hook</literal>.  This will ensure =
that
> +     wait event is available under the name <literal>tranche_name</liter=
al>,
> +     which the wait event type is <literal>Extension</literal>.
> +     Use <function>GetNamedExtensionWaitEventTranche</function>
> +     to get a wait event information.
> +    </para>
> +    <para>
> +     To avoid possible race-conditions, each backend should use the LWLo=
ck
> +     <function>AddinShmemInitLock</function> when connecting to and init=
ializing
> +     its allocation of shared memory, same as LWLocks reservations above=
.
> +    </para>

Should "wait" be capitalized in the first sentence?

"This will ensure that wait event is available" should have an "a"
before "wait".

Nice patch.

--=20
Tristan Partin
Neon (https://neon.tech)





view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [PATCH 3/3] Add docs to define custom wait events
  In-Reply-To: <no-message-id-1854515@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox