From: Justin Pryzby Date: Sun, 15 Jan 2023 17:00:06 -0600 Subject: [PATCH 02/10] comment typos --- src/backend/commands/dbcommands.c | 2 +- src/backend/executor/execMain.c | 2 +- src/backend/jit/llvm/llvmjit_inline.cpp | 2 +- src/backend/replication/logical/snapbuild.c | 2 +- src/backend/replication/walsender.c | 6 +++--- src/bin/pg_dump/pg_backup_custom.c | 2 +- src/bin/pg_dump/pg_dumpall.c | 2 +- src/include/lib/ilist.h | 2 +- src/test/regress/expected/alter_table.out | 2 +- src/test/regress/expected/create_procedure.out | 2 +- src/test/regress/sql/alter_table.sql | 2 +- src/test/regress/sql/create_procedure.sql | 2 +- src/test/subscription/t/031_column_list.pl | 2 +- 13 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/backend/commands/dbcommands.c b/src/backend/commands/dbcommands.c index 1f4ce2fb9cf..ef05633bb05 100644 --- a/src/backend/commands/dbcommands.c +++ b/src/backend/commands/dbcommands.c @@ -3090,7 +3090,7 @@ dbase_redo(XLogReaderState *record) /* * There's a case where the copy source directory is missing for the - * same reason above. Create the emtpy source directory so that + * same reason above. Create the empty source directory so that * copydir below doesn't fail. The directory will be dropped soon by * recovery. */ diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c index a5115b9c1f7..39bfb48dc22 100644 --- a/src/backend/executor/execMain.c +++ b/src/backend/executor/execMain.c @@ -134,7 +134,7 @@ ExecutorStart(QueryDesc *queryDesc, int eflags) /* * In some cases (e.g. an EXECUTE statement) a query execution will skip * parse analysis, which means that the query_id won't be reported. Note - * that it's harmless to report the query_id multiple time, as the call + * that it's harmless to report the query_id multiple times, as the call * will be ignored if the top level query_id has already been reported. */ pgstat_report_query_id(queryDesc->plannedstmt->queryId, false); diff --git a/src/backend/jit/llvm/llvmjit_inline.cpp b/src/backend/jit/llvm/llvmjit_inline.cpp index dc35e002f51..c765add8564 100644 --- a/src/backend/jit/llvm/llvmjit_inline.cpp +++ b/src/backend/jit/llvm/llvmjit_inline.cpp @@ -753,7 +753,7 @@ function_inlinable(llvm::Function &F, /* import referenced function itself */ importVars.insert(referencedFunction->getName()); - /* import referenced function and its dependants */ + /* import referenced function and its dependents */ for (auto& recImportVar : recImportVars) importVars.insert(recImportVar.first()); } diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c index 829c5681120..62542827e4b 100644 --- a/src/backend/replication/logical/snapbuild.c +++ b/src/backend/replication/logical/snapbuild.c @@ -1816,7 +1816,7 @@ SnapBuildSerialize(SnapBuild *builder, XLogRecPtr lsn) fsync_fname("pg_logical/snapshots", true); /* - * Now there's no way we can loose the dumped state anymore, remember this + * Now there's no way we can lose the dumped state anymore, remember this * as a serialization point. */ builder->last_serialized_snapshot = lsn; diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c index 4ed3747e3f9..75e8363e248 100644 --- a/src/backend/replication/walsender.c +++ b/src/backend/replication/walsender.c @@ -2050,9 +2050,9 @@ PhysicalConfirmReceivedLocation(XLogRecPtr lsn) /* * One could argue that the slot should be saved to disk now, but that'd - * be energy wasted - the worst lost information can do here is give us - * wrong information in a statistics view - we'll just potentially be more - * conservative in removing files. + * be energy wasted - the worst thing lost information could cause here is + * to give wrong information in a statistics view - we'll just potentially + * be more conservative in removing files. */ } diff --git a/src/bin/pg_dump/pg_backup_custom.c b/src/bin/pg_dump/pg_backup_custom.c index d1e54644a94..7529367a7b9 100644 --- a/src/bin/pg_dump/pg_backup_custom.c +++ b/src/bin/pg_dump/pg_backup_custom.c @@ -99,7 +99,7 @@ static size_t _CustomReadFunc(ArchiveHandle *AH, char **buf, size_t *buflen); * It's task is to create any extra archive context (using AH->formatData), * and to initialize the supported function pointers. * - * It should also prepare whatever it's input source is for reading/writing, + * It should also prepare whatever its input source is for reading/writing, * and in the case of a read mode connection, it should load the Header & TOC. */ void diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c index fbd1c6fc85b..cd421c59443 100644 --- a/src/bin/pg_dump/pg_dumpall.c +++ b/src/bin/pg_dump/pg_dumpall.c @@ -995,7 +995,7 @@ dumpRoleMembership(PGconn *conn) fprintf(OPF, "--\n-- Role memberships\n--\n\n"); /* - * We can't dump these GRANT commands in arbitary order, because a role + * We can't dump these GRANT commands in arbitrary order, because a role * that is named as a grantor must already have ADMIN OPTION on the * role for which it is granting permissions, except for the boostrap * superuser, who can always be named as the grantor. diff --git a/src/include/lib/ilist.h b/src/include/lib/ilist.h index e03aa1c683b..095107a99c4 100644 --- a/src/include/lib/ilist.h +++ b/src/include/lib/ilist.h @@ -39,7 +39,7 @@ * operations that can be done without branches (and thus faster) on lists * that use circular representation. However, it is often convenient to * initialize list headers to zeroes rather than setting them up with an - * explicit initialization function, so we also allow the NULL initalization. + * explicit initialization function, so we also allow the NULL initialization. * * EXAMPLES * diff --git a/src/test/regress/expected/alter_table.out b/src/test/regress/expected/alter_table.out index 9e5f6c1a804..97bfc3475b6 100644 --- a/src/test/regress/expected/alter_table.out +++ b/src/test/regress/expected/alter_table.out @@ -2566,7 +2566,7 @@ select * from at_view_2; drop view at_view_2; drop view at_view_1; drop table at_base_table; --- check adding a column not iself requiring a rewrite, together with +-- check adding a column not itself requiring a rewrite, together with -- a column requiring a default (bug #16038) -- ensure that rewrites aren't silently optimized away, removing the -- value of the test diff --git a/src/test/regress/expected/create_procedure.out b/src/test/regress/expected/create_procedure.out index 46c827f9791..f2a677fa552 100644 --- a/src/test/regress/expected/create_procedure.out +++ b/src/test/regress/expected/create_procedure.out @@ -100,7 +100,7 @@ SELECT * FROM cp_test ORDER BY b COLLATE "C"; 1 | xyzzy (4 rows) --- utitlity functions currently not supported here +-- utility functions currently not supported here CREATE PROCEDURE ptestx() LANGUAGE SQL BEGIN ATOMIC diff --git a/src/test/regress/sql/alter_table.sql b/src/test/regress/sql/alter_table.sql index f58b2f75d5b..b5d57a771ae 100644 --- a/src/test/regress/sql/alter_table.sql +++ b/src/test/regress/sql/alter_table.sql @@ -1635,7 +1635,7 @@ drop view at_view_2; drop view at_view_1; drop table at_base_table; --- check adding a column not iself requiring a rewrite, together with +-- check adding a column not itself requiring a rewrite, together with -- a column requiring a default (bug #16038) -- ensure that rewrites aren't silently optimized away, removing the diff --git a/src/test/regress/sql/create_procedure.sql b/src/test/regress/sql/create_procedure.sql index 75cc0fcf2a6..35b872779ef 100644 --- a/src/test/regress/sql/create_procedure.sql +++ b/src/test/regress/sql/create_procedure.sql @@ -42,7 +42,7 @@ CALL ptest1s('b'); SELECT * FROM cp_test ORDER BY b COLLATE "C"; --- utitlity functions currently not supported here +-- utility functions currently not supported here CREATE PROCEDURE ptestx() LANGUAGE SQL BEGIN ATOMIC diff --git a/src/test/subscription/t/031_column_list.pl b/src/test/subscription/t/031_column_list.pl index 7c313e26eea..fd77757352a 100644 --- a/src/test/subscription/t/031_column_list.pl +++ b/src/test/subscription/t/031_column_list.pl @@ -1034,7 +1034,7 @@ is( $node_subscriber->safe_psql('postgres', "SELECT * FROM s1.t ORDER BY a"), 4|5|6), 'two publications, publishing the same relation'); -# Now resync the subcription, but with publications in the opposite order. +# Now resync the subscription, but with publications in the opposite order. # The result should be the same. $node_subscriber->safe_psql( -- 2.25.1 --kjpMrWxdCilgNbo1 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0003-Avoid-hardcoded-reference-only-to-.gz.patch"