public inbox for [email protected]
help / color / mirror / Atom feedFrom: Alvaro Herrera <[email protected]>
Subject: [PATCH v25 3/4] Don't rely on ignore_invalid_pages at all
Date: Thu, 14 Jul 2022 23:39:08 +0200
Since a workaround with allow_in_place_tablespaces is possible,
there doesn't seem to be a need for the ignore_invalid_pages one.
Remove it.
---
src/backend/access/transam/xlogrecovery.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/backend/access/transam/xlogrecovery.c b/src/backend/access/transam/xlogrecovery.c
index e04d30cf3e..b0ae63fbac 100644
--- a/src/backend/access/transam/xlogrecovery.c
+++ b/src/backend/access/transam/xlogrecovery.c
@@ -2035,10 +2035,6 @@ is_path_tslink(const char *path)
* is reached these directories should have been removed; here we verify
* that this did indeed happen. This must be called after reached consistent
* state.
- *
- * ignore_invalid_pages=on turns into the PANIC error into WARNING so that
- * recovery can continue. XXX piggybacking on this particular GUC sounds like
- * a bad idea. Why not just advise to use allow_in_place_tablespaces?
*/
static void
CheckTablespaceDirectory(void)
@@ -2065,7 +2061,7 @@ CheckTablespaceDirectory(void)
snprintf(path, sizeof(path), "pg_tblspc/%s", de->d_name);
if (!is_path_tslink(path))
- ereport(ignore_invalid_pages ? WARNING : PANIC,
+ ereport(PANIC,
(errcode(ERRCODE_DATA_CORRUPTED),
errmsg("real directory found in pg_tblspc directory: %s", de->d_name)));
}
--
2.30.2
--hwk7mjf7k3wvtowq
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="v25-0004-do-CheckTablespaceDirectory-first.patch"
view thread (18+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [PATCH v25 3/4] Don't rely on ignore_invalid_pages at all
In-Reply-To: <no-message-id-1858754@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox