public inbox for [email protected]
help / color / mirror / Atom feedRe: fairywren is generating bogus BASE_BACKUP commands
3+ messages / 2 participants
[nested] [flat]
* Re: fairywren is generating bogus BASE_BACKUP commands
@ 2022-01-24 21:13 Andrew Dunstan <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Dunstan @ 2022-01-24 21:13 UTC (permalink / raw)
To: Robert Haas <[email protected]>; +Cc: Tom Lane <[email protected]>; Thomas Munro <[email protected]>; PostgreSQL Hackers <[email protected]>
On 1/24/22 15:17, Robert Haas wrote:
> On Mon, Jan 24, 2022 at 2:27 PM Robert Haas <[email protected]> wrote:
>> I really hate committing stuff that turns out to be broken. It's such
>> a fire drill when the build farm turns red.
> And there's a good chance it's about to break again, because I just
> committed the next patch in the series which, shockingly, also
> includes tests.
>
> I'd like to tell you I believe I got it right this time ... but I don't.
I'll just keep playing whackamole :-)
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
^ permalink raw reply [nested|flat] 3+ messages in thread
* [PATCH 06/26] avoid shadow vars: basebackup_target.c: ttype
@ 2022-08-16 23:51 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Justin Pryzby @ 2022-08-16 23:51 UTC (permalink / raw)
backpatch to v15
commit e4ba69f3f4a1b997aa493cc02e563a91c0f35b87
Author: Robert Haas <[email protected]>
Date: Tue Mar 15 13:22:04 2022 -0400
Allow extensions to add new backup targets.
---
src/backend/backup/basebackup_target.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/backup/basebackup_target.c b/src/backend/backup/basebackup_target.c
index 83928e32055..1553568a37d 100644
--- a/src/backend/backup/basebackup_target.c
+++ b/src/backend/backup/basebackup_target.c
@@ -73,9 +73,9 @@ BaseBackupAddTarget(char *name,
/* Search the target type list for an existing entry with this name. */
foreach(lc, BaseBackupTargetTypeList)
{
- BaseBackupTargetType *ttype = lfirst(lc);
+ BaseBackupTargetType *this_ttype = lfirst(lc);
- if (strcmp(ttype->name, name) == 0)
+ if (strcmp(this_ttype->name, name) == 0)
{
/*
* We found one, so update it.
@@ -84,8 +84,8 @@ BaseBackupAddTarget(char *name,
* the same name multiple times, but if it happens, this seems
* like the sanest behavior.
*/
- ttype->check_detail = check_detail;
- ttype->get_sink = get_sink;
+ this_ttype->check_detail = check_detail;
+ this_ttype->get_sink = get_sink;
return;
}
}
--
2.17.1
--wayzTnRSUXKNfBqd
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0007-avoid-shadow-vars-parse_jsontable.c-jtc.patch"
^ permalink raw reply [nested|flat] 3+ messages in thread
* [PATCH 06/17] avoid shadow vars: basebackup_target.c: ttype
@ 2022-08-16 23:51 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Justin Pryzby @ 2022-08-16 23:51 UTC (permalink / raw)
backpatch to v15
commit e4ba69f3f4a1b997aa493cc02e563a91c0f35b87
Author: Robert Haas <[email protected]>
Date: Tue Mar 15 13:22:04 2022 -0400
Allow extensions to add new backup targets.
---
src/backend/backup/basebackup_target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/backup/basebackup_target.c b/src/backend/backup/basebackup_target.c
index 83928e32055..8d10fe15530 100644
--- a/src/backend/backup/basebackup_target.c
+++ b/src/backend/backup/basebackup_target.c
@@ -73,7 +73,7 @@ BaseBackupAddTarget(char *name,
/* Search the target type list for an existing entry with this name. */
foreach(lc, BaseBackupTargetTypeList)
{
- BaseBackupTargetType *ttype = lfirst(lc);
+ ttype = lfirst(lc);
if (strcmp(ttype->name, name) == 0)
{
--
2.17.1
--uTRFFR9qmiCqR05s
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0007-avoid-shadow-vars-parse_jsontable.c-jtc.patch"
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2022-08-16 23:51 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-01-24 21:13 Re: fairywren is generating bogus BASE_BACKUP commands Andrew Dunstan <[email protected]>
2022-08-16 23:51 [PATCH 06/26] avoid shadow vars: basebackup_target.c: ttype Justin Pryzby <[email protected]>
2022-08-16 23:51 [PATCH 06/17] avoid shadow vars: basebackup_target.c: ttype Justin Pryzby <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox