public inbox for [email protected]  
help / color / mirror / Atom feed
Re: Flush SLRU counters in checkpointer process
9+ messages / 2 participants
[nested] [flat]

* Re: Flush SLRU counters in checkpointer process
@ 2023-01-11 12:05  Aleksander Alekseev <[email protected]>
  0 siblings, 0 replies; 9+ messages in thread

From: Aleksander Alekseev @ 2023-01-11 12:05 UTC (permalink / raw)
  To: pgsql-hackers; +Cc: Anthonin Bonnefoy <[email protected]>

Hi Anthonin,

> This patch adds a flush of SLRU stats to the end of checkpoints.

The patch looks good to me and passes the tests but let's see if
anyone else has any feedback.

Also I added a CF entry: https://commitfest.postgresql.org/42/4120/

-- 
Best regards,
Aleksander Alekseev






^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* [PATCH v1] psql: Fix \df tab completion for procedures
@ 2025-11-22 14:42  Erik Wienhold <[email protected]>
  0 siblings, 0 replies; 9+ messages in thread

From: Erik Wienhold @ 2025-11-22 14:42 UTC (permalink / raw)

\df also covers procedures since fb421231daa.  But the tab completion
logic was never changed to align with that.  Fix this along the lines of
05e85d35afb.
---
 src/bin/psql/tab-complete.in.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/psql/tab-complete.in.c b/src/bin/psql/tab-complete.in.c
index 072b98bea08..8f81f5bf035 100644
--- a/src/bin/psql/tab-complete.in.c
+++ b/src/bin/psql/tab-complete.in.c
@@ -5669,7 +5669,7 @@ match_previous_words(int pattern_id,
 	else if (TailMatchesCS("\\dew*"))
 		COMPLETE_WITH_QUERY(Query_for_list_of_fdws);
 	else if (TailMatchesCS("\\df*"))
-		COMPLETE_WITH_VERSIONED_SCHEMA_QUERY(Query_for_list_of_functions);
+		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_routines);
 	else if (HeadMatchesCS("\\df*"))
 		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_datatypes);
 
-- 
2.55.0


--5rsvev5qaoortkiw--





^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* [PATCH v1] psql: Fix \df tab completion for procedures
@ 2025-11-22 14:42  Erik Wienhold <[email protected]>
  0 siblings, 0 replies; 9+ messages in thread

From: Erik Wienhold @ 2025-11-22 14:42 UTC (permalink / raw)

\df also covers procedures since fb421231daa.  But the tab completion
logic was never changed to align with that.  Fix this along the lines of
05e85d35afb.
---
 src/bin/psql/tab-complete.in.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/psql/tab-complete.in.c b/src/bin/psql/tab-complete.in.c
index 072b98bea08..8f81f5bf035 100644
--- a/src/bin/psql/tab-complete.in.c
+++ b/src/bin/psql/tab-complete.in.c
@@ -5669,7 +5669,7 @@ match_previous_words(int pattern_id,
 	else if (TailMatchesCS("\\dew*"))
 		COMPLETE_WITH_QUERY(Query_for_list_of_fdws);
 	else if (TailMatchesCS("\\df*"))
-		COMPLETE_WITH_VERSIONED_SCHEMA_QUERY(Query_for_list_of_functions);
+		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_routines);
 	else if (HeadMatchesCS("\\df*"))
 		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_datatypes);
 
-- 
2.55.0


--5rsvev5qaoortkiw--





^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* [PATCH v1] psql: Fix \df tab completion for procedures
@ 2025-11-22 14:42  Erik Wienhold <[email protected]>
  0 siblings, 0 replies; 9+ messages in thread

From: Erik Wienhold @ 2025-11-22 14:42 UTC (permalink / raw)

\df also covers procedures since fb421231daa.  But the tab completion
logic was never changed to align with that.  Fix this along the lines of
05e85d35afb.
---
 src/bin/psql/tab-complete.in.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/psql/tab-complete.in.c b/src/bin/psql/tab-complete.in.c
index 072b98bea08..8f81f5bf035 100644
--- a/src/bin/psql/tab-complete.in.c
+++ b/src/bin/psql/tab-complete.in.c
@@ -5669,7 +5669,7 @@ match_previous_words(int pattern_id,
 	else if (TailMatchesCS("\\dew*"))
 		COMPLETE_WITH_QUERY(Query_for_list_of_fdws);
 	else if (TailMatchesCS("\\df*"))
-		COMPLETE_WITH_VERSIONED_SCHEMA_QUERY(Query_for_list_of_functions);
+		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_routines);
 	else if (HeadMatchesCS("\\df*"))
 		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_datatypes);
 
-- 
2.55.0


--5rsvev5qaoortkiw--





^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* [PATCH v1] psql: Fix \df tab completion for procedures
@ 2025-11-22 14:42  Erik Wienhold <[email protected]>
  0 siblings, 0 replies; 9+ messages in thread

From: Erik Wienhold @ 2025-11-22 14:42 UTC (permalink / raw)

\df also covers procedures since fb421231daa.  But the tab completion
logic was never changed to align with that.  Fix this along the lines of
05e85d35afb.
---
 src/bin/psql/tab-complete.in.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/psql/tab-complete.in.c b/src/bin/psql/tab-complete.in.c
index 072b98bea08..8f81f5bf035 100644
--- a/src/bin/psql/tab-complete.in.c
+++ b/src/bin/psql/tab-complete.in.c
@@ -5669,7 +5669,7 @@ match_previous_words(int pattern_id,
 	else if (TailMatchesCS("\\dew*"))
 		COMPLETE_WITH_QUERY(Query_for_list_of_fdws);
 	else if (TailMatchesCS("\\df*"))
-		COMPLETE_WITH_VERSIONED_SCHEMA_QUERY(Query_for_list_of_functions);
+		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_routines);
 	else if (HeadMatchesCS("\\df*"))
 		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_datatypes);
 
-- 
2.55.0


--5rsvev5qaoortkiw--





^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* [PATCH v1] psql: Fix \df tab completion for procedures
@ 2025-11-22 14:42  Erik Wienhold <[email protected]>
  0 siblings, 0 replies; 9+ messages in thread

From: Erik Wienhold @ 2025-11-22 14:42 UTC (permalink / raw)

\df also covers procedures since fb421231daa.  But the tab completion
logic was never changed to align with that.  Fix this along the lines of
05e85d35afb.
---
 src/bin/psql/tab-complete.in.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/psql/tab-complete.in.c b/src/bin/psql/tab-complete.in.c
index 072b98bea08..8f81f5bf035 100644
--- a/src/bin/psql/tab-complete.in.c
+++ b/src/bin/psql/tab-complete.in.c
@@ -5669,7 +5669,7 @@ match_previous_words(int pattern_id,
 	else if (TailMatchesCS("\\dew*"))
 		COMPLETE_WITH_QUERY(Query_for_list_of_fdws);
 	else if (TailMatchesCS("\\df*"))
-		COMPLETE_WITH_VERSIONED_SCHEMA_QUERY(Query_for_list_of_functions);
+		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_routines);
 	else if (HeadMatchesCS("\\df*"))
 		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_datatypes);
 
-- 
2.55.0


--5rsvev5qaoortkiw--





^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* [PATCH v1] psql: Fix \df tab completion for procedures
@ 2025-11-22 14:42  Erik Wienhold <[email protected]>
  0 siblings, 0 replies; 9+ messages in thread

From: Erik Wienhold @ 2025-11-22 14:42 UTC (permalink / raw)

\df also covers procedures since fb421231daa.  But the tab completion
logic was never changed to align with that.  Fix this along the lines of
05e85d35afb.
---
 src/bin/psql/tab-complete.in.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/psql/tab-complete.in.c b/src/bin/psql/tab-complete.in.c
index 072b98bea08..8f81f5bf035 100644
--- a/src/bin/psql/tab-complete.in.c
+++ b/src/bin/psql/tab-complete.in.c
@@ -5669,7 +5669,7 @@ match_previous_words(int pattern_id,
 	else if (TailMatchesCS("\\dew*"))
 		COMPLETE_WITH_QUERY(Query_for_list_of_fdws);
 	else if (TailMatchesCS("\\df*"))
-		COMPLETE_WITH_VERSIONED_SCHEMA_QUERY(Query_for_list_of_functions);
+		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_routines);
 	else if (HeadMatchesCS("\\df*"))
 		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_datatypes);
 
-- 
2.55.0


--5rsvev5qaoortkiw--





^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* [PATCH v1] psql: Fix \df tab completion for procedures
@ 2025-11-22 14:42  Erik Wienhold <[email protected]>
  0 siblings, 0 replies; 9+ messages in thread

From: Erik Wienhold @ 2025-11-22 14:42 UTC (permalink / raw)

\df also covers procedures since fb421231daa.  But the tab completion
logic was never changed to align with that.  Fix this along the lines of
05e85d35afb.
---
 src/bin/psql/tab-complete.in.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/psql/tab-complete.in.c b/src/bin/psql/tab-complete.in.c
index 072b98bea08..8f81f5bf035 100644
--- a/src/bin/psql/tab-complete.in.c
+++ b/src/bin/psql/tab-complete.in.c
@@ -5669,7 +5669,7 @@ match_previous_words(int pattern_id,
 	else if (TailMatchesCS("\\dew*"))
 		COMPLETE_WITH_QUERY(Query_for_list_of_fdws);
 	else if (TailMatchesCS("\\df*"))
-		COMPLETE_WITH_VERSIONED_SCHEMA_QUERY(Query_for_list_of_functions);
+		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_routines);
 	else if (HeadMatchesCS("\\df*"))
 		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_datatypes);
 
-- 
2.55.0


--5rsvev5qaoortkiw--





^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* [PATCH v1] psql: Fix \df tab completion for procedures
@ 2025-11-22 14:42  Erik Wienhold <[email protected]>
  0 siblings, 0 replies; 9+ messages in thread

From: Erik Wienhold @ 2025-11-22 14:42 UTC (permalink / raw)

\df also covers procedures since fb421231daa.  But the tab completion
logic was never changed to align with that.  Fix this along the lines of
05e85d35afb.
---
 src/bin/psql/tab-complete.in.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/psql/tab-complete.in.c b/src/bin/psql/tab-complete.in.c
index 072b98bea08..8f81f5bf035 100644
--- a/src/bin/psql/tab-complete.in.c
+++ b/src/bin/psql/tab-complete.in.c
@@ -5669,7 +5669,7 @@ match_previous_words(int pattern_id,
 	else if (TailMatchesCS("\\dew*"))
 		COMPLETE_WITH_QUERY(Query_for_list_of_fdws);
 	else if (TailMatchesCS("\\df*"))
-		COMPLETE_WITH_VERSIONED_SCHEMA_QUERY(Query_for_list_of_functions);
+		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_routines);
 	else if (HeadMatchesCS("\\df*"))
 		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_datatypes);
 
-- 
2.55.0


--5rsvev5qaoortkiw--





^ permalink  raw  reply  [nested|flat] 9+ messages in thread


end of thread, other threads:[~2025-11-22 14:42 UTC | newest]

Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-01-11 12:05 Re: Flush SLRU counters in checkpointer process Aleksander Alekseev <[email protected]>
2025-11-22 14:42 [PATCH v1] psql: Fix \df tab completion for procedures Erik Wienhold <[email protected]>
2025-11-22 14:42 [PATCH v1] psql: Fix \df tab completion for procedures Erik Wienhold <[email protected]>
2025-11-22 14:42 [PATCH v1] psql: Fix \df tab completion for procedures Erik Wienhold <[email protected]>
2025-11-22 14:42 [PATCH v1] psql: Fix \df tab completion for procedures Erik Wienhold <[email protected]>
2025-11-22 14:42 [PATCH v1] psql: Fix \df tab completion for procedures Erik Wienhold <[email protected]>
2025-11-22 14:42 [PATCH v1] psql: Fix \df tab completion for procedures Erik Wienhold <[email protected]>
2025-11-22 14:42 [PATCH v1] psql: Fix \df tab completion for procedures Erik Wienhold <[email protected]>
2025-11-22 14:42 [PATCH v1] psql: Fix \df tab completion for procedures Erik Wienhold <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox