agora inbox for pgsql-hackers@postgresql.orghelp / color / mirror / Atom feed
[PATCH 1/3] Return NULL rather than elog(ERROR) for sql-callable function 2+ messages / 2 participants [nested] [flat]
* [PATCH 1/3] Return NULL rather than elog(ERROR) for sql-callable function @ 2021-05-05 09:29 Justin Pryzby <pryzbyj@telsasoft.com> 0 siblings, 0 replies; 2+ messages in thread From: Justin Pryzby @ 2021-05-05 09:29 UTC (permalink / raw) --- src/backend/utils/adt/ruleutils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c index 0a4fa93d01..881e8ec03d 100644 --- a/src/backend/utils/adt/ruleutils.c +++ b/src/backend/utils/adt/ruleutils.c @@ -1759,9 +1759,9 @@ pg_get_statisticsobjdef_expressions(PG_FUNCTION_ARGS) statexttup = SearchSysCache1(STATEXTOID, ObjectIdGetDatum(statextid)); if (!HeapTupleIsValid(statexttup)) - elog(ERROR, "cache lookup failed for statistics object %u", statextid); + PG_RETURN_NULL(); - /* has the statistics expressions? */ + /* Does the stats object have expressions? */ has_exprs = !heap_attisnull(statexttup, Anum_pg_statistic_ext_stxexprs, NULL); /* no expressions? we're done */ -- 2.17.0 --aX6oBa4COn3eIhlv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0002-Comment-typos-extended-stats-a4d75c86b-and-518442c7f.patch" ^ permalink raw reply [nested|flat] 2+ messages in thread
* [PATCH v2] Allow CI to only run the compiler warnings task @ 2024-09-11 11:01 Bertrand Drouvot <bertranddrouvot.pg@gmail.com> 0 siblings, 0 replies; 2+ messages in thread From: Bertrand Drouvot @ 2024-09-11 11:01 UTC (permalink / raw) That could be useful to only run the CI compiler warnings task when addressing compiler warnings issues. Renaming ci-os-only to ci-task-only and adding filtering for the "compilerwarnings" task. --- .cirrus.tasks.yml | 20 ++++++++++---------- src/tools/ci/README | 7 ++++--- 2 files changed, 14 insertions(+), 13 deletions(-) 19.6% src/tools/ci/ diff --git a/.cirrus.tasks.yml b/.cirrus.tasks.yml index 5849cbb839a..5aac99e2666 100644 --- a/.cirrus.tasks.yml +++ b/.cirrus.tasks.yml @@ -72,7 +72,7 @@ task: # push-wait-for-ci cycle time a bit when debugging operating system specific # failures. Uses skip instead of only_if, as cirrus otherwise warns about # only_if conditions not matching. - skip: $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:.*' + skip: $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:.*' env: CPUS: 4 @@ -167,7 +167,7 @@ task: <<: *freebsd_task_template depends_on: SanityCheck - only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*freebsd.*' + only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*freebsd.*' sysinfo_script: | id @@ -257,7 +257,7 @@ task: matrix: - name: NetBSD - Meson - only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*netbsd.*' + only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*netbsd.*' env: OS_NAME: netbsd IMAGE_FAMILY: pg-ci-netbsd-postgres @@ -274,7 +274,7 @@ task: <<: *netbsd_task_template - name: OpenBSD - Meson - only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*openbsd.*' + only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*openbsd.*' env: OS_NAME: openbsd IMAGE_FAMILY: pg-ci-openbsd-postgres @@ -414,7 +414,7 @@ task: <<: *linux_task_template depends_on: SanityCheck - only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*linux.*' + only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*linux.*' ccache_cache: folder: ${CCACHE_DIR} @@ -598,7 +598,7 @@ task: <<: *macos_task_template depends_on: SanityCheck - only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*(macos|darwin|osx).*' + only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*(macos|darwin|osx).*' sysinfo_script: | id @@ -704,7 +704,7 @@ task: <<: *windows_task_template depends_on: SanityCheck - only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*windows.*' + only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*windows.*' setup_additional_packages_script: | REM choco install -y --no-progress ... @@ -742,8 +742,8 @@ task: # due to resource constraints we don't run this task by default for now trigger_type: manual # worth using only_if despite being manual, otherwise this task will show up - # when e.g. ci-os-only: linux is used. - only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*mingw.*' + # when e.g. ci-task-only: linux is used. + only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*mingw.*' # otherwise it'll be sorted before other tasks depends_on: SanityCheck @@ -802,7 +802,7 @@ task: # use always: to continue after failures. Task that did not run count as a # success, so we need to recheck SanityChecks's condition here ... depends_on: SanityCheck - only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' + only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*compilerwarnings.*' env: CPUS: 4 diff --git a/src/tools/ci/README b/src/tools/ci/README index 12c1e7c308f..264e36ca6c6 100644 --- a/src/tools/ci/README +++ b/src/tools/ci/README @@ -61,10 +61,11 @@ Controlling CI via commit messages The behavior of CI can be controlled by special content in commit messages. Currently the following controls are available: -- ci-os-only: {(freebsd|linux|macos|mingw|netbsd|openbsd|windows)} +- ci-task-only: {(freebsd|linux|macos|mingw|netbsd|openbsd|windows|compilerwarnings)} - Only runs CI on operating systems specified. This can be useful when - addressing portability issues affecting only a subset of platforms. + Only runs CI on operating systems specified or only runs compiler warnings + checks. This can be useful when addressing portability issues affecting only a + subset of platforms or when addressing compiler warnings issues. Using custom compute resources for CI -- 2.34.1 --zXIor5yQveBako6e-- ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-09-11 11:01 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-05-05 09:29 [PATCH 1/3] Return NULL rather than elog(ERROR) for sql-callable function Justin Pryzby <pryzbyj@telsasoft.com> 2024-09-11 11:01 [PATCH v2] Allow CI to only run the compiler warnings task Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox