agora inbox for [email protected]
help / color / mirror / Atom feedpg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL
32+ messages / 6 participants
[nested] [flat]
* pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL
@ 2017-07-26 10:09 tushar <[email protected]>
2017-07-26 12:05 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Michael Paquier <[email protected]>
0 siblings, 1 reply; 32+ messages in thread
From: tushar @ 2017-07-26 10:09 UTC (permalink / raw)
To: pgsql-hackers
v9.5/9.6
create these objects -
CREATE TABLE constraint_rename_test (a int CONSTRAINT con1 CHECK (a >
0), b int, c int);
CREATE TABLE constraint_rename_test2 (a int CONSTRAINT con1 CHECK (a >
0), d int) INHERITS (constraint_rename_test);
ALTER TABLE constraint_rename_test ADD CONSTRAINT con3 PRIMARY KEY (a);
v9.6/v10 - run pg_upgrade
pg_restore: creating COMMENT "SCHEMA "public""
pg_restore: creating TABLE "public.constraint_rename_test"
pg_restore: creating TABLE "public.constraint_rename_test2"
pg_restore: [archiver (db)] Error while PROCESSING TOC:
pg_restore: [archiver (db)] Error from TOC entry 351; 1259 16388 TABLE
constraint_rename_test2 edb
pg_restore: [archiver (db)] could not execute query: ERROR: column "a"
in child table must be marked NOT NULL
Command was:
-- For binary upgrade, must preserve pg_type oid
SELECT
pg_catalog.binary_upgrade_set_next_pg_type_oid('16390'::pg_catalog.oid);
manually i am able to create all these objects .
--
regards,tushar
EnterpriseDB https://www.enterprisedb.com/
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 32+ messages in thread
* Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL
2017-07-26 10:09 pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL tushar <[email protected]>
@ 2017-07-26 12:05 ` Michael Paquier <[email protected]>
2017-07-26 14:02 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Tom Lane <[email protected]>
0 siblings, 1 reply; 32+ messages in thread
From: Michael Paquier @ 2017-07-26 12:05 UTC (permalink / raw)
To: tushar <[email protected]>; +Cc: pgsql-hackers
On Wed, Jul 26, 2017 at 12:09 PM, tushar <[email protected]> wrote:
> v9.5/9.6
>
> create these objects -
> CREATE TABLE constraint_rename_test (a int CONSTRAINT con1 CHECK (a > 0), b
> int, c int);
> CREATE TABLE constraint_rename_test2 (a int CONSTRAINT con1 CHECK (a > 0), d
> int) INHERITS (constraint_rename_test);
> ALTER TABLE constraint_rename_test ADD CONSTRAINT con3 PRIMARY KEY (a);
>
> v9.6/v10 - run pg_upgrade
>
> pg_restore: creating COMMENT "SCHEMA "public""
> pg_restore: creating TABLE "public.constraint_rename_test"
> pg_restore: creating TABLE "public.constraint_rename_test2"
> pg_restore: [archiver (db)] Error while PROCESSING TOC:
> pg_restore: [archiver (db)] Error from TOC entry 351; 1259 16388 TABLE
> constraint_rename_test2 edb
> pg_restore: [archiver (db)] could not execute query: ERROR: column "a" in
> child table must be marked NOT NULL
> Command was:
> -- For binary upgrade, must preserve pg_type oid
> SELECT
> pg_catalog.binary_upgrade_set_next_pg_type_oid('16390'::pg_catalog.oid);
>
> manually i am able to create all these objects .
You can go further down to reproduce the failure of your test case. I
can see the same thing with at least 9.3, which is as far as I tested,
for any upgrade combinations up to HEAD. And I would imagine that this
is an old behavior.
The documentation says the following:
https://www.postgresql.org/docs/9.3/static/ddl-inherit.html
All check constraints and not-null constraints on a parent table are
automatically inherited by its children. Other types of constraints
(unique, primary key, and foreign key constraints) are not inherited.
When adding a primary key, the system does first SET NOT NULL on each
column under cover, but this does not get spread to the child tables
as this is a PRIMARY KEY. The question is, do we want to spread the
NOT NULL constraint created by the PRIMARY KEY command to the child
tables, or not? It is easy enough to fix your problem by switching the
second and third commands in your test case, still I think that the
current behavior is non-intuitive, and that we ought to fix this by
applying NOT NULL to the child's columns when a primary key is added
to the parent. Thoughts?
--
Michael
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 32+ messages in thread
* Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL
2017-07-26 10:09 pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL tushar <[email protected]>
2017-07-26 12:05 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Michael Paquier <[email protected]>
@ 2017-07-26 14:02 ` Tom Lane <[email protected]>
2017-07-26 14:50 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Michael Paquier <[email protected]>
0 siblings, 1 reply; 32+ messages in thread
From: Tom Lane @ 2017-07-26 14:02 UTC (permalink / raw)
To: Michael Paquier <[email protected]>; +Cc: tushar <[email protected]>; pgsql-hackers
Michael Paquier <[email protected]> writes:
> The documentation says the following:
> https://www.postgresql.org/docs/9.3/static/ddl-inherit.html
> All check constraints and not-null constraints on a parent table are
> automatically inherited by its children. Other types of constraints
> (unique, primary key, and foreign key constraints) are not inherited.
> When adding a primary key, the system does first SET NOT NULL on each
> column under cover, but this does not get spread to the child tables
> as this is a PRIMARY KEY. The question is, do we want to spread the
> NOT NULL constraint created by the PRIMARY KEY command to the child
> tables, or not?
Yeah, I think we really ought to for consistency. Quite aside from
pg_dump hazards, this allows situations where selecting from an
apparently not-null column can produce nulls (coming from unconstrained
child tables). That's exactly what the automatic inheritance rules
are intended to prevent. If we had a way to mark NOT NULL constraints
as not-inherited, it'd be legitimate for ADD PRIMARY KEY to paste on
one of those instead of a regular one ... but we lack that feature,
so it's moot.
Not sure what's involved there code-wise, though, nor whether we'd want
to back-patch.
regards, tom lane
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 32+ messages in thread
* Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL
2017-07-26 10:09 pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL tushar <[email protected]>
2017-07-26 12:05 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Michael Paquier <[email protected]>
2017-07-26 14:02 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Tom Lane <[email protected]>
@ 2017-07-26 14:50 ` Michael Paquier <[email protected]>
2017-07-27 14:58 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Michael Paquier <[email protected]>
0 siblings, 1 reply; 32+ messages in thread
From: Michael Paquier @ 2017-07-26 14:50 UTC (permalink / raw)
To: Tom Lane <[email protected]>; +Cc: tushar <[email protected]>; pgsql-hackers
On Wed, Jul 26, 2017 at 4:02 PM, Tom Lane <[email protected]> wrote:
> Not sure what's involved there code-wise, though, nor whether we'd want
> to back-patch.
I'll try to look at the code around that to come up with a clear
conclusion in the next couple of days, likely more as that's a
vacation period. Surely anything invasive would not be backpatched.
--
Michael
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 32+ messages in thread
* Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL
2017-07-26 10:09 pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL tushar <[email protected]>
2017-07-26 12:05 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Michael Paquier <[email protected]>
2017-07-26 14:02 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Tom Lane <[email protected]>
2017-07-26 14:50 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Michael Paquier <[email protected]>
@ 2017-07-27 14:58 ` Michael Paquier <[email protected]>
2017-08-04 15:50 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Tom Lane <[email protected]>
0 siblings, 1 reply; 32+ messages in thread
From: Michael Paquier @ 2017-07-27 14:58 UTC (permalink / raw)
To: Tom Lane <[email protected]>; +Cc: tushar <[email protected]>; pgsql-hackers
On Wed, Jul 26, 2017 at 4:50 PM, Michael Paquier
<[email protected]> wrote:
> On Wed, Jul 26, 2017 at 4:02 PM, Tom Lane <[email protected]> wrote:
>> Not sure what's involved there code-wise, though, nor whether we'd want
>> to back-patch.
>
> I'll try to look at the code around that to come up with a clear
> conclusion in the next couple of days, likely more as that's a
> vacation period. Surely anything invasive would not be backpatched.
So I think that the attached patch is able to do the legwork. While
looking at the code, I have bumped into index_check_primary_key() that
discarded the case of sending SET NOT NULL to child tables, as
introduced by 88452d5b. But that's clearly an oversight IMO, and the
comment is wrong to begin with because SET NOT NULL is spread to child
tables. Using is_alter_table instead of a plain true in
index_check_primary_key() for the call of AlterTableInternal() is
defensive, but I don't think that we want to impact any modules
relying on this API, so recursing only when ALTER TABLE is used is the
safest course of action to me. With this logic, we rely as well on the
fact that ADD PRIMARY KEY is not recursive in tablecmds.c. Comments
are welcome, I'll park that into the CF app so as it does not get lost
in the void.
--
Michael
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachments:
[application/octet-stream] alttab-setnotnull-v1.patch (1.9K, ../../CAB7nPqSdvhZsBbatH-1nS=pKXCorupS3_Xc+=dY9UGQeDsX8jg@mail.gmail.com/2-alttab-setnotnull-v1.patch)
download | inline diff:
diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c
index d25b39bb54..4ebac27d10 100644
--- a/src/backend/catalog/index.c
+++ b/src/backend/catalog/index.c
@@ -185,6 +185,8 @@ relationHasPrimaryKey(Relation rel)
* created NOT NULL during CREATE TABLE), do an ALTER SET NOT NULL to mark
* them so --- or fail if they are not in fact nonnull.
*
+ * For ALTER TABLE, SET NOT NULL is applied as well to child tables.
+ *
* Caller had better have at least ShareLock on the table, else the not-null
* checking isn't trustworthy.
*/
@@ -253,17 +255,13 @@ index_check_primary_key(Relation heapRel,
}
/*
- * XXX: Shouldn't the ALTER TABLE .. SET NOT NULL cascade to child tables?
- * Currently, since the PRIMARY KEY itself doesn't cascade, we don't
- * cascade the notnull constraint(s) either; but this is pretty debatable.
- *
* XXX: possible future improvement: when being called from ALTER TABLE,
* it would be more efficient to merge this with the outer ALTER TABLE, so
* as to avoid two scans. But that seems to complicate DefineIndex's API
* unduly.
*/
if (cmds)
- AlterTableInternal(RelationGetRelid(heapRel), cmds, false);
+ AlterTableInternal(RelationGetRelid(heapRel), cmds, is_alter_table);
}
/*
diff --git a/src/test/regress/expected/alter_table.out b/src/test/regress/expected/alter_table.out
index 13d6a4b747..e9fd1aacce 100644
--- a/src/test/regress/expected/alter_table.out
+++ b/src/test/regress/expected/alter_table.out
@@ -328,7 +328,7 @@ Number of child tables: 1 (Use \d+ to list them.)
Table "public.constraint_rename_test2"
Column | Type | Collation | Nullable | Default
--------+---------+-----------+----------+---------
- a | integer | | |
+ a | integer | | not null |
b | integer | | |
c | integer | | |
d | integer | | |
^ permalink raw reply [nested|flat] 32+ messages in thread
* Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL
2017-07-26 10:09 pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL tushar <[email protected]>
2017-07-26 12:05 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Michael Paquier <[email protected]>
2017-07-26 14:02 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Tom Lane <[email protected]>
2017-07-26 14:50 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Michael Paquier <[email protected]>
2017-07-27 14:58 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Michael Paquier <[email protected]>
@ 2017-08-04 15:50 ` Tom Lane <[email protected]>
2017-08-04 16:06 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Michael Paquier <[email protected]>
0 siblings, 1 reply; 32+ messages in thread
From: Tom Lane @ 2017-08-04 15:50 UTC (permalink / raw)
To: Michael Paquier <[email protected]>; +Cc: tushar <[email protected]>; pgsql-hackers
Michael Paquier <[email protected]> writes:
> So I think that the attached patch is able to do the legwork.
I've pushed this into HEAD. It seems like enough of a behavioral
change that we wouldn't want to back-patch, but IMO it's not too late
to be making this type of change in v10. If we wait for the next CF
then it will take another year for the fix to reach the field.
> While
> looking at the code, I have bumped into index_check_primary_key() that
> discarded the case of sending SET NOT NULL to child tables, as
> introduced by 88452d5b. But that's clearly an oversight IMO, and the
> comment is wrong to begin with because SET NOT NULL is spread to child
> tables. Using is_alter_table instead of a plain true in
> index_check_primary_key() for the call of AlterTableInternal() is
> defensive, but I don't think that we want to impact any modules
> relying on this API, so recursing only when ALTER TABLE is used is the
> safest course of action to me.
I didn't find that persuasive: I think passing "recurse" as just plain
"true" is safer and more readable. We shouldn't be able to get there
in a CREATE case, as per the comments; and if we did, there shouldn't
be any child tables anyway; but if somehow there were, surely the same
consistency argument would imply that we *must* recurse and fix those
child tables. So I just made it "true".
regards, tom lane
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 32+ messages in thread
* Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL
2017-07-26 10:09 pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL tushar <[email protected]>
2017-07-26 12:05 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Michael Paquier <[email protected]>
2017-07-26 14:02 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Tom Lane <[email protected]>
2017-07-26 14:50 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Michael Paquier <[email protected]>
2017-07-27 14:58 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Michael Paquier <[email protected]>
2017-08-04 15:50 ` Re: pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL Tom Lane <[email protected]>
@ 2017-08-04 16:06 ` Michael Paquier <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Michael Paquier @ 2017-08-04 16:06 UTC (permalink / raw)
To: Tom Lane <[email protected]>; +Cc: tushar <[email protected]>; pgsql-hackers
On Fri, Aug 4, 2017 at 5:50 PM, Tom Lane <[email protected]> wrote:
> Michael Paquier <[email protected]> writes:
>> So I think that the attached patch is able to do the legwork.
>
> I've pushed this into HEAD. It seems like enough of a behavioral
> change that we wouldn't want to back-patch, but IMO it's not too late
> to be making this type of change in v10. If we wait for the next CF
> then it will take another year for the fix to reach the field.
Thanks for applying the fix. My intention when adding that in a CF is
not to see things lost.
>> While
>> looking at the code, I have bumped into index_check_primary_key() that
>> discarded the case of sending SET NOT NULL to child tables, as
>> introduced by 88452d5b. But that's clearly an oversight IMO, and the
>> comment is wrong to begin with because SET NOT NULL is spread to child
>> tables. Using is_alter_table instead of a plain true in
>> index_check_primary_key() for the call of AlterTableInternal() is
>> defensive, but I don't think that we want to impact any modules
>> relying on this API, so recursing only when ALTER TABLE is used is the
>> safest course of action to me.
>
> I didn't find that persuasive: I think passing "recurse" as just plain
> "true" is safer and more readable. We shouldn't be able to get there
> in a CREATE case, as per the comments; and if we did, there shouldn't
> be any child tables anyway; but if somehow there were, surely the same
> consistency argument would imply that we *must* recurse and fix those
> child tables. So I just made it "true".
Yeah, that matches what I read as well. No complains to switch to a
plain "true" even if it is not reached yet.
--
Michael
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/21] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--jI8keyz6grp/JLjh
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* [PATCH 15/18] doc review for multiranges
@ 2021-01-24 03:02 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Justin Pryzby @ 2021-01-24 03:02 UTC (permalink / raw)
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
---
doc/src/sgml/extend.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml
index 6e3d82b85b..ec95b4eb01 100644
--- a/doc/src/sgml/extend.sgml
+++ b/doc/src/sgml/extend.sgml
@@ -448,7 +448,7 @@
of <type>anycompatible</type> and <type>anycompatiblenonarray</type>
inputs, the array element types of <type>anycompatiblearray</type>
inputs, the range subtypes of <type>anycompatiblerange</type> inputs,
- and the multirange subtypes of <type>anycompatiablemultirange</type>
+ and the multirange subtypes of <type>anycompatiblemultirange</type>
inputs. If <type>anycompatiblenonarray</type> is present then the
common type is required to be a non-array type. Once a common type is
identified, arguments in <type>anycompatible</type>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0016-doc-review-for-logical-decoding-of-prepared-xacts.patch"
^ permalink raw reply [nested|flat] 32+ messages in thread
* Re: zlib detection in Meson on Windows broken?
@ 2024-05-21 15:04 Andres Freund <[email protected]>
2024-05-21 22:09 ` Re: zlib detection in Meson on Windows broken? Tristan Partin <[email protected]>
0 siblings, 1 reply; 32+ messages in thread
From: Andres Freund @ 2024-05-21 15:04 UTC (permalink / raw)
To: Dave Page <[email protected]>; Nazir Bilal Yavuz <[email protected]>; Tristan Partin <[email protected]>; +Cc: PostgreSQL Developers <[email protected]>
Hi,
On 2024-05-20 11:58:05 +0100, Dave Page wrote:
> I have very little experience with Meson, and even less interpreting it's
> logs, but it seems to me that it's not including the extra lib and include
> directories when it runs the test compile, given the command line it's
> reporting:
>
> cl C:\Users\dpage\git\postgresql\build\meson-private\tmpg_h4xcue\testfile.c
> /nologo /showIncludes /utf-8 /EP /nologo /showIncludes /utf-8 /EP /Od /Oi-
>
> Bug, or am I doing something silly?
It's a buglet. We rely on meson's internal fallback detection of zlib, if it's
not provided via pkg-config or cmake. But it doesn't know about our
extra_include_dirs parameter. We should probably fix that...
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 32+ messages in thread
* Re: zlib detection in Meson on Windows broken?
2024-05-21 15:04 Re: zlib detection in Meson on Windows broken? Andres Freund <[email protected]>
@ 2024-05-21 22:09 ` Tristan Partin <[email protected]>
0 siblings, 0 replies; 32+ messages in thread
From: Tristan Partin @ 2024-05-21 22:09 UTC (permalink / raw)
To: Andres Freund <[email protected]>; Dave Page <[email protected]>; Nazir Bilal Yavuz <[email protected]>; +Cc: PostgreSQL Developers <[email protected]>
On Tue May 21, 2024 at 10:04 AM CDT, Andres Freund wrote:
> Hi,
>
> On 2024-05-20 11:58:05 +0100, Dave Page wrote:
> > I have very little experience with Meson, and even less interpreting it's
> > logs, but it seems to me that it's not including the extra lib and include
> > directories when it runs the test compile, given the command line it's
> > reporting:
> >
> > cl C:\Users\dpage\git\postgresql\build\meson-private\tmpg_h4xcue\testfile.c
> > /nologo /showIncludes /utf-8 /EP /nologo /showIncludes /utf-8 /EP /Od /Oi-
> >
> > Bug, or am I doing something silly?
>
> It's a buglet. We rely on meson's internal fallback detection of zlib, if it's
> not provided via pkg-config or cmake. But it doesn't know about our
> extra_include_dirs parameter. We should probably fix that...
Here is the relevant Meson code for finding zlib in the Postgres tree:
postgres_inc_d = ['src/include']
postgres_inc_d += get_option('extra_include_dirs')
...
postgres_inc = [include_directories(postgres_inc_d)]
...
zlibopt = get_option('zlib')
zlib = not_found_dep
if not zlibopt.disabled()
zlib_t = dependency('zlib', required: zlibopt)
if zlib_t.type_name() == 'internal'
# if fallback was used, we don't need to test if headers are present (they
# aren't built yet, so we can't test)
zlib = zlib_t
elif not zlib_t.found()
warning('did not find zlib')
elif not cc.has_header('zlib.h',
args: test_c_args, include_directories: postgres_inc,
dependencies: [zlib_t], required: zlibopt)
warning('zlib header not found')
elif not cc.has_type('z_streamp',
dependencies: [zlib_t], prefix: '#include <zlib.h>',
args: test_c_args, include_directories: postgres_inc)
if zlibopt.enabled()
error('zlib version is too old')
else
warning('zlib version is too old')
endif
else
zlib = zlib_t
endif
if zlib.found()
cdata.set('HAVE_LIBZ', 1)
endif
endif
You can see that we do pass the include dirs to the has_header check.
Something seems to be going wrong here since your extra_include_dirs
isn't being properly translated to include arguments.
--
Tristan Partin
https://tristan.partin.io
^ permalink raw reply [nested|flat] 32+ messages in thread
end of thread, other threads:[~2024-05-21 22:09 UTC | newest]
Thread overview: 32+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-07-26 10:09 pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL tushar <[email protected]>
2017-07-26 12:05 ` Michael Paquier <[email protected]>
2017-07-26 14:02 ` Tom Lane <[email protected]>
2017-07-26 14:50 ` Michael Paquier <[email protected]>
2017-07-27 14:58 ` Michael Paquier <[email protected]>
2017-08-04 15:50 ` Tom Lane <[email protected]>
2017-08-04 16:06 ` Michael Paquier <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/21] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2021-01-24 03:02 [PATCH 15/18] doc review for multiranges Justin Pryzby <[email protected]>
2024-05-21 15:04 Re: zlib detection in Meson on Windows broken? Andres Freund <[email protected]>
2024-05-21 22:09 ` Re: zlib detection in Meson on Windows broken? Tristan Partin <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox