public inbox for [email protected]help / color / mirror / Atom feed
[PATCH v3 14/20] Say "re-sent" not "resent".. 23+ messages / 2 participants [nested] [flat]
* [PATCH v3 14/20] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index bad3bfe620..e08ae9e2af 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index 1a90c244fb..c18618d5c8 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -159,7 +159,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index 5aa19d3f78..22fe566f48 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1373,7 +1373,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --doUn1Hmx68n+7ij2 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v3-0015-doc-2014-pg_basebackup-Add-support-for-relocating.patch" ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v8 14/14] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --0eh6TmSyL6TZE2Uz-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v6 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --C+ts3FVlLX8+P6JN-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* [PATCH v7 10/10] Say "re-sent" not "resent".. @ 2020-04-11 02:14 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Justin Pryzby @ 2020-04-11 02:14 UTC (permalink / raw) ..which means "feel bitter or indignant about" --- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/create_subscription.sgml | 2 +- src/backend/storage/lmgr/proc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index 1571d71a5b..145c36f567 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -223,7 +223,7 @@ $ pg_recvlogical -d postgres --slot=test --drop-slot A logical slot will emit each change just once in normal operation. The current position of each slot is persisted only at checkpoint, so in the case of a crash the slot may return to an earlier LSN, which will - then cause recent changes to be resent when the server restarts. + then cause recent changes to be re-sent when the server restarts. Logical decoding clients are responsible for avoiding ill effects from handling the same message more than once. Clients may wish to record the last LSN they saw when decoding and skip over any repeated data or diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index cdb22c54fe..d1d3647f31 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -160,7 +160,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl <para> It is safe to use <literal>off</literal> for logical replication: If the subscriber loses transactions because of missing - synchronization, the data will be resent from the publisher. + synchronization, the data will be re-sent from the publisher. </para> <para> diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index aa9fbd8054..fa2cac5e11 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -1369,7 +1369,7 @@ ProcSleep(LOCALLOCK *locallock, LockMethod lockMethodTable) else LWLockRelease(ProcArrayLock); - /* prevent signal from being resent more than once */ + /* prevent signal from being re-sent more than once */ allow_autovacuum_cancel = false; } -- 2.17.0 --AsxXAMtlQ5JHofzM-- ^ permalink raw reply [nested|flat] 23+ messages in thread
* RE: [PGdocs] fix description for handling pf non-ASCII characters @ 2023-06-29 07:51 Hayato Kuroda (Fujitsu) <[email protected]> 0 siblings, 0 replies; 23+ messages in thread From: Hayato Kuroda (Fujitsu) @ 2023-06-29 07:51 UTC (permalink / raw) To: 'jian he' <[email protected]>; +Cc: Postgres hackers <[email protected]> Dear Jian, Thank you for checking my patch! > > in your patch: > > printable ASCII characters will be replaced with a hex escape. > > My wording is not good. I think the result will be: ASCII characters > will be as is, non-ASCII characters will be replaced with "a hex > escape". Yeah, your point was right. I have already said: "anything other than printable ASCII characters will be replaced with a hex escape" IIUC They have same meaning. You might want to say the line was not good, so reworded like "non-ASCII characters will be replaced with hexadecimal strings." How do you think? > set application_name to 'abc漢字Abc'; > SET > test16=# show application_name; > application_name > -------------------------------- > abc\xe6\xbc\xa2\xe5\xad\x97Abc > (1 row) > > I see multi escape, so I am not sure "a hex escape". Not sure what you said, but I could not find word "hex escape" in the document. So I used "hexadecimal string" instead. Is it acceptable? > to properly render it back to 'abc漢字Abc' > here is how i do it: > select 'abc' || convert_from(decode(' e6bca2e5ad97','hex'), 'UTF8') || 'Abc'; Yeah, your approach seems right, but I'm not sure it is related with us. Just to confirm, I don't have interest the method for rendering non-ASCII characters. My motivation of the patch was to document the the incompatibility noted in [1]: > Changed the conversion rules when non-ASCII characters are specified for ASCII-only strings such as parameters application_name and cluster_name. Previously, it was converted in byte units with a question mark (?), but in PostgreSQL 16, it is converted to a hexadecimal string. > > I guess it's still painful if your application_name has non-ASCII chars. I agreed that, but no one has recommended to use non-ASCII. [1]: https://h50146.www5.hpe.com/products/software/oe/linux/mainstream/support/lcc/pdf/PostgreSQL16Beta1_... Best Regards, Hayato Kuroda FUJITSU LIMITED Attachments: [application/octet-stream] v2_doc_fix.patch (2.5K, ../../TYAPR01MB58662BC412E1290FC3348973F525A@TYAPR01MB5866.jpnprd01.prod.outlook.com/2-v2_doc_fix.patch) download | inline diff: diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index e700782d3c..a4ce99ba4d 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -7040,9 +7040,8 @@ local0.* /var/log/postgresql The name will be displayed in the <structname>pg_stat_activity</structname> view and included in CSV log entries. It can also be included in regular log entries via the <xref linkend="guc-log-line-prefix"/> parameter. - Only printable ASCII characters may be used in the - <varname>application_name</varname> value. Other characters will be - replaced with question marks (<literal>?</literal>). + Non-ASCII characters used in the <varname>application_name</varname> + will be replaced with hexadecimal strings. </para> </listitem> </varlistentry> @@ -8037,10 +8036,9 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv; <para> The name can be any string of less than <symbol>NAMEDATALEN</symbol> characters (64 characters in a standard - build). Only printable ASCII characters may be used in the - <varname>cluster_name</varname> value. Other characters will be - replaced with question marks (<literal>?</literal>). No name is shown - if this parameter is set to the empty string <literal>''</literal> (which is + build). Non-ASCII characters used in the <varname>cluster_name</varname> + will be replaced with hexadecimal strings. No name is shown if this + parameter is set to the empty string <literal>''</literal> (which is the default). This parameter can only be set at server start. </para> </listitem> diff --git a/doc/src/sgml/postgres-fdw.sgml b/doc/src/sgml/postgres-fdw.sgml index 5062d712e7..98785e87ea 100644 --- a/doc/src/sgml/postgres-fdw.sgml +++ b/doc/src/sgml/postgres-fdw.sgml @@ -1067,9 +1067,8 @@ postgres=# SELECT postgres_fdw_disconnect_all(); of any length and contain even non-ASCII characters. However when it's passed to and used as <varname>application_name</varname> in a foreign server, note that it will be truncated to less than - <symbol>NAMEDATALEN</symbol> characters and anything other than - printable ASCII characters will be replaced with question - marks (<literal>?</literal>). + <symbol>NAMEDATALEN</symbol> characters and non-ASCII characters will be + replaced with hexadecimal strings. See <xref linkend="guc-application-name"/> for details. </para> ^ permalink raw reply [nested|flat] 23+ messages in thread
end of thread, other threads:[~2023-06-29 07:51 UTC | newest] Thread overview: 23+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v7 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v8 14/14] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v3 14/20] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2020-04-11 02:14 [PATCH v6 10/10] Say "re-sent" not "resent".. Justin Pryzby <[email protected]> 2023-06-29 07:51 RE: [PGdocs] fix description for handling pf non-ASCII characters Hayato Kuroda (Fujitsu) <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox