public inbox for [email protected]help / color / mirror / Atom feed
[PATCH 07/21] function comment: get_am_name 24+ messages / 2 participants [nested] [flat]
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/21] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --jI8keyz6grp/JLjh Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* [PATCH 07/18] function comment: get_am_name @ 2020-12-30 15:39 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Justin Pryzby @ 2020-12-30 15:39 UTC (permalink / raw) --- src/backend/commands/amcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/amcmds.c b/src/backend/commands/amcmds.c index eff9535ed0..188109e474 100644 --- a/src/backend/commands/amcmds.c +++ b/src/backend/commands/amcmds.c @@ -186,7 +186,7 @@ get_am_oid(const char *amname, bool missing_ok) } /* - * get_am_name - given an access method OID name and type, look up its name. + * get_am_name - given an access method OID, look up its name. */ char * get_am_name(Oid amOid) -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0008-an-exclusive.patch" ^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: Optimize SELECT * in EXISTS @ 2026-02-24 21:07 Tom Lane <[email protected]> 0 siblings, 0 replies; 24+ messages in thread From: Tom Lane @ 2026-02-24 21:07 UTC (permalink / raw) To: Peter Eisentraut <[email protected]>; +Cc: David Rowley <[email protected]>; pgsql-hackers Peter Eisentraut <[email protected]> writes: > It appears so, but then I think we should update the documentation along > the lines I showed, because I found it misleading about this. New > docs-only patch attached. +1 for being more explicit here, but that specific wording reads a little awkwardly to me. What do you think of the attached? (The new code comments are fine, I didn't touch them.) regards, tom lane Attachments: [text/x-diff] v3-0001-doc-Document-SELECT-in-EXISTS-optimizations.patch (2.3K, ../../[email protected]/2-v3-0001-doc-Document-SELECT-in-EXISTS-optimizations.patch) download | inline diff: diff --git a/doc/src/sgml/func/func-subquery.sgml b/doc/src/sgml/func/func-subquery.sgml index a9f2b12e48c..4453ab3a6ab 100644 --- a/doc/src/sgml/func/func-subquery.sgml +++ b/doc/src/sgml/func/func-subquery.sgml @@ -70,8 +70,14 @@ EXISTS (<replaceable>subquery</replaceable>) and not on the contents of those rows, the output list of the subquery is normally unimportant. A common coding convention is to write all <literal>EXISTS</literal> tests in the form - <literal>EXISTS(SELECT 1 WHERE ...)</literal>. There are exceptions to - this rule however, such as subqueries that use <token>INTERSECT</token>. + <literal>EXISTS(SELECT * FROM ... WHERE ...)</literal>, another common + convention is to write <literal>EXISTS(SELECT 1 FROM ... WHERE + ...)</literal> or some other dummy constant. These conventions are + actually equivalent in <productname>PostgreSQL</productname>, which + will optimize away evaluation of the subquery's output list altogether + when it cannot affect the number of rows returned. (A counterexample + that cannot be optimized away is an output list containing a + set-returning function, since the function might return zero rows.) </para> <para> diff --git a/src/backend/optimizer/plan/subselect.c b/src/backend/optimizer/plan/subselect.c index e9dc9d31f05..1f18934b2a4 100644 --- a/src/backend/optimizer/plan/subselect.c +++ b/src/backend/optimizer/plan/subselect.c @@ -1643,7 +1643,13 @@ convert_EXISTS_sublink_to_join(PlannerInfo *root, SubLink *sublink, * Note: by suppressing the targetlist we could cause an observable behavioral * change, namely that any errors that might occur in evaluating the tlist * won't occur, nor will other side-effects of volatile functions. This seems - * unlikely to bother anyone in practice. + * unlikely to bother anyone in practice. Note that any column privileges are + * still checked even if the reference is removed here. + * + * The SQL standard specifies that a SELECT * immediately inside EXISTS + * expands to not all columns but an arbitrary literal. That is kind of the + * same idea, but our optimization goes further in that it throws away the + * entire targetlist, and not only if it was written as *. * * Returns true if was able to discard the targetlist, else false. */ ^ permalink raw reply [nested|flat] 24+ messages in thread
end of thread, other threads:[~2026-02-24 21:07 UTC | newest] Thread overview: 24+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/21] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2020-12-30 15:39 [PATCH 07/18] function comment: get_am_name Justin Pryzby <[email protected]> 2026-02-24 21:07 Re: Optimize SELECT * in EXISTS Tom Lane <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox