From: Tomas Vondra Date: Mon, 15 Feb 2021 16:26:32 +0100 Subject: [PATCH 2/6] 0001 review --- doc/src/sgml/monitoring.sgml | 2 +- src/backend/commands/copyfrom.c | 1 + src/backend/commands/copyto.c | 2 ++ 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml index 3c39c82f1a..c5048fefd4 100644 --- a/doc/src/sgml/monitoring.sgml +++ b/doc/src/sgml/monitoring.sgml @@ -6561,7 +6561,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid, The io target that the data is read from or written to: FILE, PROGRAM, - STDIO (for COPY FROM STDIN and COPY TO STDOUT), + STDIO (for COPY FROM STDIN and COPY TO STDOUT), or CALLBACK (used in the table synchronization background worker). diff --git a/src/backend/commands/copyfrom.c b/src/backend/commands/copyfrom.c index c3610eb67e..d98f447cf5 100644 --- a/src/backend/commands/copyfrom.c +++ b/src/backend/commands/copyfrom.c @@ -1508,6 +1508,7 @@ BeginCopyFrom(ParseState *pstate, ReceiveCopyBinaryHeader(cstate); } + /* XXX this block seems weird */ { int64 io_target; switch (cstate->copy_src) diff --git a/src/backend/commands/copyto.c b/src/backend/commands/copyto.c index 42c4a828df..4b76bf5ef6 100644 --- a/src/backend/commands/copyto.c +++ b/src/backend/commands/copyto.c @@ -772,6 +772,8 @@ BeginCopyTo(ParseState *pstate, /* initialize progress */ pgstat_progress_start_command(PROGRESS_COMMAND_COPY, cstate->rel ? RelationGetRelid(cstate->rel) : InvalidOid); + + /* XXX this too */ { const int progress_index[] = { PROGRESS_COPY_COMMAND, -- 2.26.2 --------------DA8D60BF026F7ACE69A9AEE5 Content-Type: text/x-patch; charset=UTF-8; name="v7-0003-Add-backlinks-to-progress-reporting-documentation.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="v7-0003-Add-backlinks-to-progress-reporting-documentation.pa"; filename*1="tch"