agora inbox for [email protected]
help / color / mirror / Atom feed[PATCH 17/21] *an old and "deleted [has] happened"
28+ messages / 4 participants
[nested] [flat]
* [PATCH 17/21] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--jI8keyz6grp/JLjh
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 28+ messages in thread
* Re: Catalog version access
@ 2022-01-24 03:30 Michael Paquier <[email protected]>
0 siblings, 1 reply; 28+ messages in thread
From: Michael Paquier @ 2022-01-24 03:30 UTC (permalink / raw)
To: Bossart, Nathan <[email protected]>; +Cc: Magnus Hagander <[email protected]>; Tom Lane <[email protected]>; Vik Fearing <[email protected]>; Peter Eisentraut <[email protected]>; Andres Freund <[email protected]>; PostgreSQL Hackers <[email protected]>
On Mon, Aug 16, 2021 at 06:12:54PM +0000, Bossart, Nathan wrote:
> I was looking at the --check switch for the postgres binary recently
> [0], and this sounds like something that might fit in nicely there.
> In the attached patch, --check will also check the control file if one
> exists.
This would not work on a running postmaster as CreateDataDirLockFile()
is called beforehand, but we want this capability, no?
Abusing a bootstrap option for this purpose does not look like a good
idea, to be honest, especially for something only used internally now
and undocumented, but we want to use something aimed at an external
use with some documentation. Using a separate switch would be more
adapted IMO. Also, I think that we should be careful with the read of
the control file to avoid false positives? We can rely on an atomic
read/write thanks to its maximum size of 512 bytes, but this looks
like a lot what has been done recently with postgres -C for runtime
GUCs, that *require* a read of the control file before grabbing the
values we are interested in.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../../Ye4daRe1ytSBE64%[email protected]/2-signature.asc)
download
^ permalink raw reply [nested|flat] 28+ messages in thread
* Re: Catalog version access
@ 2022-01-24 20:40 Bossart, Nathan <[email protected]>
parent: Michael Paquier <[email protected]>
0 siblings, 1 reply; 28+ messages in thread
From: Bossart, Nathan @ 2022-01-24 20:40 UTC (permalink / raw)
To: Michael Paquier <[email protected]>; +Cc: Magnus Hagander <[email protected]>; Tom Lane <[email protected]>; Vik Fearing <[email protected]>; Peter Eisentraut <[email protected]>; Andres Freund <[email protected]>; PostgreSQL Hackers <[email protected]>
Thanks for taking a look!
On 1/23/22, 7:31 PM, "Michael Paquier" <[email protected]> wrote:
> On Mon, Aug 16, 2021 at 06:12:54PM +0000, Bossart, Nathan wrote:
>> I was looking at the --check switch for the postgres binary recently
>> [0], and this sounds like something that might fit in nicely there.
>> In the attached patch, --check will also check the control file if one
>> exists.
>
> This would not work on a running postmaster as CreateDataDirLockFile()
> is called beforehand, but we want this capability, no?
I was not under the impression this was a requirement, based on the
use-case discussed upthread [0].
> Abusing a bootstrap option for this purpose does not look like a good
> idea, to be honest, especially for something only used internally now
> and undocumented, but we want to use something aimed at an external
> use with some documentation. Using a separate switch would be more
> adapted IMO.
This is the opposite of what Magnus proposed earlier [1]. Do we need
a new pg_ctl option for this? It seems like it is really only
intended for use by PostgreSQL developers, but perhaps there are other
use-cases I am not thinking of. In any case, the pg_ctl option would
probably end up using --check (or another similar mode) behind the
scenes.
> Also, I think that we should be careful with the read of
> the control file to avoid false positives? We can rely on an atomic
> read/write thanks to its maximum size of 512 bytes, but this looks
> like a lot what has been done recently with postgres -C for runtime
> GUCs, that *require* a read of the control file before grabbing the
> values we are interested in.
Sorry, I'm not following this one. In my proposed patch, the control
file (if one exists) is read after CreateDataDirLockFile(), just like
PostmasterMain().
Nathan
[0] https://postgr.es/m/20210222022407.ecaygvx2ise6uwyz%40alap3.anarazel.de
[1] https://postgr.es/m/CABUevEySovaEDci7c0DXOrV6c7JzWqYzfVwOiRUJxMao%3D9seEw%40mail.gmail.com
^ permalink raw reply [nested|flat] 28+ messages in thread
* Re: Catalog version access
@ 2022-01-25 04:12 Michael Paquier <[email protected]>
parent: Bossart, Nathan <[email protected]>
0 siblings, 1 reply; 28+ messages in thread
From: Michael Paquier @ 2022-01-25 04:12 UTC (permalink / raw)
To: Bossart, Nathan <[email protected]>; +Cc: Magnus Hagander <[email protected]>; Tom Lane <[email protected]>; Vik Fearing <[email protected]>; Peter Eisentraut <[email protected]>; Andres Freund <[email protected]>; PostgreSQL Hackers <[email protected]>
On Mon, Jan 24, 2022 at 08:40:08PM +0000, Bossart, Nathan wrote:
> On 1/23/22, 7:31 PM, "Michael Paquier" <[email protected]> wrote:
>> On Mon, Aug 16, 2021 at 06:12:54PM +0000, Bossart, Nathan wrote:
>>> I was looking at the --check switch for the postgres binary recently
>>> [0], and this sounds like something that might fit in nicely there.
>>> In the attached patch, --check will also check the control file if one
>>> exists.
>>
>> This would not work on a running postmaster as CreateDataDirLockFile()
>> is called beforehand, but we want this capability, no?
>
> I was not under the impression this was a requirement, based on the
> use-case discussed upthread [0].
Hmm. I got a different impression as of this one:
https://www.postgresql.org/message-id/[email protected]
But I can see downthread that this is not the case. Sorry for the
confusion.
>> Abusing a bootstrap option for this purpose does not look like a good
>> idea, to be honest, especially for something only used internally now
>> and undocumented, but we want to use something aimed at an external
>> use with some documentation. Using a separate switch would be more
>> adapted IMO.
>
> This is the opposite of what Magnus proposed earlier [1]. Do we need
> a new pg_ctl option for this? It seems like it is really only
> intended for use by PostgreSQL developers, but perhaps there are other
> use-cases I am not thinking of. In any case, the pg_ctl option would
> probably end up using --check (or another similar mode) behind the
> scenes.
Based on the latest state of the thread, I am understanding that we
don't want a new option for pg_ctl for this feature, and using a
bootstrap's --check for this purpose is not a good idea IMO. What I
guess from Magnus' suggestion would be to add a completely different
switch.
Once you remove the requirement of a running server, we have basically
what has been recently implemented with postgres -C for
runtime-computed GUCs, because we already go through a read of the
control file to be able to print those GUCs with their correct
values. This also means that it is already possible to check if a
data folder is compatible with a set of binaries with this facility,
as any postgres -C command with a runtime GUC would trigger this
check. Using any of the existing runtime GUCs may be confusing, but
that would work. And I am not really convinced that we have any need
to add a specific GUC for this purpose, be it a sort of
is_controlfile_valid or controlfile_checksum (CRC32 of the control
file).
>> Also, I think that we should be careful with the read of
>> the control file to avoid false positives? We can rely on an atomic
>> read/write thanks to its maximum size of 512 bytes, but this looks
>> like a lot what has been done recently with postgres -C for runtime
>> GUCs, that *require* a read of the control file before grabbing the
>> values we are interested in.
>
> Sorry, I'm not following this one. In my proposed patch, the control
> file (if one exists) is read after CreateDataDirLockFile(), just like
> PostmasterMain().
While looking at the patch, I was thinking about the fact that we may
want to support the case even if a server is running. If we don't, my
worries about the concurrent control file activities are moot.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../../[email protected]/2-signature.asc)
download
^ permalink raw reply [nested|flat] 28+ messages in thread
* Re: Catalog version access
@ 2022-01-31 07:57 Michael Paquier <[email protected]>
parent: Michael Paquier <[email protected]>
0 siblings, 1 reply; 28+ messages in thread
From: Michael Paquier @ 2022-01-31 07:57 UTC (permalink / raw)
To: Bossart, Nathan <[email protected]>; +Cc: Magnus Hagander <[email protected]>; Tom Lane <[email protected]>; Vik Fearing <[email protected]>; Peter Eisentraut <[email protected]>; Andres Freund <[email protected]>; PostgreSQL Hackers <[email protected]>
On Tue, Jan 25, 2022 at 01:12:32PM +0900, Michael Paquier wrote:
> Once you remove the requirement of a running server, we have basically
> what has been recently implemented with postgres -C for
> runtime-computed GUCs, because we already go through a read of the
> control file to be able to print those GUCs with their correct
> values. This also means that it is already possible to check if a
> data folder is compatible with a set of binaries with this facility,
> as any postgres -C command with a runtime GUC would trigger this
> check. Using any of the existing runtime GUCs may be confusing, but
> that would work. And I am not really convinced that we have any need
> to add a specific GUC for this purpose, be it a sort of
> is_controlfile_valid or controlfile_checksum (CRC32 of the control
> file).
Thinking more about this one, we can already do that, so I have
marked the patch as RwF. Perhaps we could just add a GUC, but that
feels a bit dummy.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../../[email protected]/2-signature.asc)
download
^ permalink raw reply [nested|flat] 28+ messages in thread
* Re: Catalog version access
@ 2022-01-31 18:10 Nathan Bossart <[email protected]>
parent: Michael Paquier <[email protected]>
0 siblings, 0 replies; 28+ messages in thread
From: Nathan Bossart @ 2022-01-31 18:10 UTC (permalink / raw)
To: Michael Paquier <[email protected]>; +Cc: Bossart, Nathan <[email protected]>; Magnus Hagander <[email protected]>; Tom Lane <[email protected]>; Vik Fearing <[email protected]>; Peter Eisentraut <[email protected]>; Andres Freund <[email protected]>; PostgreSQL Hackers <[email protected]>
On Mon, Jan 31, 2022 at 04:57:13PM +0900, Michael Paquier wrote:
> On Tue, Jan 25, 2022 at 01:12:32PM +0900, Michael Paquier wrote:
>> Once you remove the requirement of a running server, we have basically
>> what has been recently implemented with postgres -C for
>> runtime-computed GUCs, because we already go through a read of the
>> control file to be able to print those GUCs with their correct
>> values. This also means that it is already possible to check if a
>> data folder is compatible with a set of binaries with this facility,
>> as any postgres -C command with a runtime GUC would trigger this
>> check. Using any of the existing runtime GUCs may be confusing, but
>> that would work. And I am not really convinced that we have any need
>> to add a specific GUC for this purpose, be it a sort of
>> is_controlfile_valid or controlfile_checksum (CRC32 of the control
>> file).
>
> Thinking more about this one, we can already do that, so I have
> marked the patch as RwF. Perhaps we could just add a GUC, but that
> feels a bit dummy.
Sorry, I missed this thread earlier. You're right, we can just do
something like the following to achieve basically the same result:
postgres -D . -C data_checksums
Unless Vik has any objections, this can probably be marked as Withdrawn.
Perhaps we can look into providing a new option for "postgres" at some
point in the future, but I don't sense a ton of demand at the moment.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
^ permalink raw reply [nested|flat] 28+ messages in thread
end of thread, other threads:[~2022-01-31 18:10 UTC | newest]
Thread overview: 28+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/21] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2022-01-24 03:30 Re: Catalog version access Michael Paquier <[email protected]>
2022-01-24 20:40 ` Re: Catalog version access Bossart, Nathan <[email protected]>
2022-01-25 04:12 ` Re: Catalog version access Michael Paquier <[email protected]>
2022-01-31 07:57 ` Re: Catalog version access Michael Paquier <[email protected]>
2022-01-31 18:10 ` Re: Catalog version access Nathan Bossart <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox