agora inbox for [email protected]  

help / color / mirror / Atom feed

From: Japin Li <[email protected]>
Subject: [PATCH v1 1/1] Fix typo about WalSndPrepareWrite
Date: Thu, 14 Jan 2021 12:23:56 +0800

WalSndPrepareWrite function comment uses XLogSendPhysical to fill the
sendtime, but it actually done by WalSndWriteData.
---
 src/backend/replication/walsender.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c
index fe0d368a35..87bd647338 100644
--- a/src/backend/replication/walsender.c
+++ b/src/backend/replication/walsender.c
@@ -1243,7 +1243,7 @@ WalSndPrepareWrite(LogicalDecodingContext *ctx, XLogRecPtr lsn, TransactionId xi
 	pq_sendint64(ctx->out, lsn);	/* walEnd */
 
 	/*
-	 * Fill out the sendtime later, just as it's done in XLogSendPhysical, but
+	 * Fill out the sendtime later, just as it's done in WalSndWriteData, but
 	 * reserve space here.
 	 */
 	pq_sendint64(ctx->out, 0);	/* sendtime */
-- 
2.30.0


--=-=-=--

view thread (22+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [PATCH v1 1/1] Fix typo about WalSndPrepareWrite
  In-Reply-To: <no-message-id-1868787@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox