agora inbox for [email protected]help / color / mirror / Atom feed
[PATCH v8 05/14] doc: Add logical replication support to replicate into partitioned tables 26+ messages / 3 participants [nested] [flat]
* [PATCH v8 05/14] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..28dae9ba67 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -403,7 +403,7 @@ <listitem> <para> Replication is only supported by tables, including partitioned tables. - Attempts to replicate other types of relations such as views, materialized + Attempts to replicate other types of relations, such as views, materialized views, or foreign tables, will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --0eh6TmSyL6TZE2Uz Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v8-0006-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v9 05/15] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index c35415801f..87eac7be58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -403,7 +403,7 @@ <listitem> <para> Replication is only supported by tables, including partitioned tables. - Attempts to replicate other types of relations such as views, materialized + Attempts to replicate other types of relations, such as views, materialized views, or foreign tables, will result in an error. </para> </listitem> -- 2.17.0 --L6iaP+gRLNZHKoI4 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v9-0006-doc-backup-manifests.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..d2cdd13c58 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v7 05/10] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 3f69b71926..28dae9ba67 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -403,7 +403,7 @@ <listitem> <para> Replication is only supported by tables, including partitioned tables. - Attempts to replicate other types of relations such as views, materialized + Attempts to replicate other types of relations, such as views, materialized views, or foreign tables, will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index a60c73d74d..e1a447e097 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --AsxXAMtlQ5JHofzM Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v7-0006-is-vs-are-plural.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v3 11/20] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index eba331a72b..faf6d56bed 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> -- 2.17.0 --doUn1Hmx68n+7ij2 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v3-0012-comment-typo-Add-logical-replication-support-to-r.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* [PATCH v4 08/12] doc: Add logical replication support to replicate into partitioned tables @ 2020-04-10 15:05 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Justin Pryzby @ 2020-04-10 15:05 UTC (permalink / raw) commit f1ac27bfda6ce8a399d8001843e9aefff5814f9b Author: Peter Eisentraut <[email protected]> --- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/replication/logical/relation.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index eba331a72b..faf6d56bed 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -404,7 +404,7 @@ <para> Replication is only supported by tables, including partitioned tables. Attempts to replicate other types of relations such as views, materialized - views, or foreign tables, will result in an error. + views, or foreign tables will result in an error. </para> </listitem> diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index fec39354c0..351b0950c0 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -631,7 +631,7 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root, /* * If the partition's attributes don't match the root relation's, we'll * need to make a new attrmap which maps partition attribute numbers to - * remoterel's, instead the original which maps root relation's attribute + * remoterel's, instead of the original which maps root relation's attribute * numbers to remoterel's. * * Note that 'map' which comes from the tuple routing data structure -- 2.17.0 --DiL7RhKs8rK9YGuF Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v4-0009-doc-2014-pg_basebackup-Add-support-for-relocating.patch" ^ permalink raw reply [nested|flat] 26+ messages in thread
* Re: generic plans and "initial" pruning @ 2024-01-05 10:46 vignesh C <[email protected]> 0 siblings, 1 reply; 26+ messages in thread From: vignesh C @ 2024-01-05 10:46 UTC (permalink / raw) To: Amit Langote <[email protected]>; +Cc: Robert Haas <[email protected]>; Alvaro Herrera <[email protected]>; Andres Freund <[email protected]>; Daniel Gustafsson <[email protected]>; David Rowley <[email protected]>; Jacob Champion <[email protected]>; pgsql-hackers; Thom Brown <[email protected]>; Tom Lane <[email protected]> On Mon, 20 Nov 2023 at 10:00, Amit Langote <[email protected]> wrote: > > On Thu, Sep 28, 2023 at 5:26 PM Amit Langote <[email protected]> wrote: > > On Tue, Sep 26, 2023 at 10:06 PM Amit Langote <[email protected]> wrote: > > > After sleeping on this, I think we do need the checks after all the > > > ExecInitNode() calls too, because we have many instances of the code > > > like the following one: > > > > > > outerPlanState(gatherstate) = ExecInitNode(outerNode, estate, eflags); > > > tupDesc = ExecGetResultType(outerPlanState(gatherstate)); > > > <some code that dereferences outDesc> > > > > > > If outerNode is a SeqScan and ExecInitSeqScan() returned early because > > > ExecOpenScanRelation() detected that plan was invalidated, then > > > tupDesc would be NULL in this case, causing the code to crash. > > > > > > Now one might say that perhaps we should only add the > > > is-CachedPlan-valid test in the instances where there is an actual > > > risk of such misbehavior, but that could lead to confusion, now or > > > later. It seems better to add them after every ExecInitNode() call > > > while we're inventing the notion, because doing so relieves the > > > authors of future enhancements of the ExecInit*() routines from > > > worrying about any of this. > > > > > > Attached 0003 should show how that turned out. > > > > > > Updated 0002 as mentioned in the previous reply -- setting pointers to > > > NULL after freeing them more consistently across various ExecEnd*() > > > routines and using the `if (pointer != NULL)` style over the `if > > > (pointer)` more consistently. > > > > > > Updated 0001's commit message to remove the mention of its relation to > > > any future commits. I intend to push it tomorrow. > > > > Pushed that one. Here are the rebased patches. > > > > 0001 seems ready to me, but I'll wait a couple more days for others to > > weigh in. Just to highlight a kind of change that others may have > > differing opinions on, consider this hunk from the patch: > > > > - MemoryContextDelete(node->aggcontext); > > + if (node->aggcontext != NULL) > > + { > > + MemoryContextDelete(node->aggcontext); > > + node->aggcontext = NULL; > > + } > > ... > > + ExecEndNode(outerPlanState(node)); > > + outerPlanState(node) = NULL; > > > > So the patch wants to enhance the consistency of setting the pointer > > to NULL after freeing part. Robert mentioned his preference for doing > > it in the patch, which I agree with. > > Rebased. There is a leak reported at [1], details for the same is available at [2]: diff -U3 /tmp/cirrus-ci-build/src/test/regress/expected/select_views.out /tmp/cirrus-ci-build/build/testrun/regress-running/regress/results/select_views.out --- /tmp/cirrus-ci-build/src/test/regress/expected/select_views.out 2023-12-19 23:00:04.677385000 +0000 +++ /tmp/cirrus-ci-build/build/testrun/regress-running/regress/results/select_views.out 2023-12-19 23:06:26.870259000 +0000 @@ -1288,6 +1288,7 @@ (102, '2011-10-12', 120), (102, '2011-10-28', 200), (103, '2011-10-15', 480); +WARNING: resource was not closed: relation "customer_pkey" CREATE VIEW my_property_normal AS SELECT * FROM customer WHERE name = current_user; CREATE VIEW my_property_secure WITH (security_barrier) A [1] - https://cirrus-ci.com/task/6494009196019712 [2] - https://api.cirrus-ci.com/v1/artifact/task/6494009196019712/testrun/build/testrun/regress-running/re... Regards, Vingesh ^ permalink raw reply [nested|flat] 26+ messages in thread
* Re: generic plans and "initial" pruning @ 2024-03-31 05:03 Andrey M. Borodin <[email protected]> parent: vignesh C <[email protected]> 0 siblings, 0 replies; 26+ messages in thread From: Andrey M. Borodin @ 2024-03-31 05:03 UTC (permalink / raw) To: vignesh C <[email protected]>; +Cc: Amit Langote <[email protected]>; Robert Haas <[email protected]>; Alvaro Herrera <[email protected]>; Andres Freund <[email protected]>; Daniel Gustafsson <[email protected]>; David Rowley <[email protected]>; Jacob Champion <[email protected]>; pgsql-hackers; Thom Brown <[email protected]>; Tom Lane <[email protected]> > On 6 Dec 2023, at 23:52, Robert Haas <[email protected]> wrote: > > I hope that it's at least somewhat useful. > > On 5 Jan 2024, at 15:46, vignesh C <[email protected]> wrote: > > There is a leak reported Hi Amit, this is a kind reminder that some feedback on your patch[0] is waiting for your reply. Thank you for your work! Best regards, Andrey Borodin. [0] https://commitfest.postgresql.org/47/3478/ ^ permalink raw reply [nested|flat] 26+ messages in thread
end of thread, other threads:[~2024-03-31 05:03 UTC | newest] Thread overview: 26+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v7 05/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v9 05/15] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v3 11/20] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v4 08/12] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v8 05/14] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2020-04-10 15:05 [PATCH v6 06/10] doc: Add logical replication support to replicate into partitioned tables Justin Pryzby <[email protected]> 2024-01-05 10:46 Re: generic plans and "initial" pruning vignesh C <[email protected]> 2024-03-31 05:03 ` Re: generic plans and "initial" pruning Andrey M. Borodin <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox