Subject: Re: not null constraints, again

From: Tom Lane <[email-masked]>
Date: Fri, 08 Nov 2024 11:26:11 -0500

Alvaro Herrera <[email-masked]> writes:
> But we'll see what else the buildfarm has to say now that I pushed it ...

A lot of the buildfarm is saying

 adder         | 2024-11-08 13:04:39 | ../pgsql/src/backend/catalog/pg_constraint.c:708:37: warning: comparison is always true due to limited range of data type [-Wtype-limits]

which evidently is about this:

	Assert(colnum > 0 && colnum <= MaxAttrNumber);

The memcpy right before that doesn't seem like project style either.
Most other places that are doing similar things just cast the
ARR_DATA_PTR to the right pointer type and dereference it.

			regards, tom lane