Subject: Re: Potential ABI breakage in upcoming minor releases

From: Aleksander Alekseev <[email-masked]>
Date: Thu, 14 Nov 2024 18:53:01 +0300

Hi,

> To add to this list, Christoph Berg confirmed that timescaledb test suite crashes. [1]

Yes changing ResultRelInfo most definetely breaks TimescaleDB. The
extension uses makeNode(ResultRelInfo) and this can't end-up well:

```
static inline Node *
newNode(size_t size, NodeTag tag)
{
    Node       *result;

    Assert(size >= sizeof(Node));    /* need the tag, at least */
    result = (Node *) palloc0(size);
    result->type = tag;

    return result;
}

#define makeNode(_type_)        ((_type_ *) newNode(sizeof(_type_),T_##_type_))
```

-- 
Best regards,
Aleksander Alekseev