agora inbox for [email protected]  
help / color / mirror / Atom feed
[PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
44+ messages / 3 participants
[nested] [flat]

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch"



^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
@ 2021-01-07 01:08 Justin Pryzby <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Justin Pryzby @ 2021-01-07 01:08 UTC (permalink / raw)

---
 doc/src/sgml/monitoring.sgml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 43fe8ae383..3cdb1aff3c 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
   <para>
    Whenever <command>COPY</command> is running, the
    <structname>pg_stat_progress_copy</structname> view will contain one row
-   for each backend that is currently running <command>COPY</command> command.
-   The table bellow describes the information that will be reported and provide
-   information how to interpret it.
+   for each backend that is currently running a <command>COPY</command> command.
+   The table below describes the information that will be reported and provides
+   information about how to interpret it.
   </para>
 
   <table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
 
      <row>
       <entry role="catalog_table_entry"><para role="column_definition">
-       <structfield>datid</structfield> <type>text</type>
+       <structfield>datid</structfield> <type>oid</type>
       </para>
       <para>
        OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
       </para>
       <para>
        OID of the table on which the <command>COPY</command> command is executed.
-       It is set to 0 if <command>SELECT</command> query is provided.
+       It is set to 0 if copying from a <command>SELECT</command> query.
       </para></entry>
      </row>
 
-- 
2.17.0


--aM3YZ0Iwxop3KEKx--





^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* Re: Is *fast* 32-bit support still important?
@ 2024-07-30 07:25 Heikki Linnakangas <[email protected]>
  2024-08-05 11:46 ` Re: Is *fast* 32-bit support still important? Joel Jacobson <[email protected]>
  0 siblings, 1 reply; 44+ messages in thread

From: Heikki Linnakangas @ 2024-07-30 07:25 UTC (permalink / raw)
  To: Joel Jacobson <[email protected]>; pgsql-hackers

On 29/07/2024 23:40, Joel Jacobson wrote:
> To me, it's non-obvious whether introducing `#if SIZEOF_DATUM < 8` with
> separate 32-bit and 64-bit code paths is worthwhile to maintain performance
> for both.
> 
> Knowing more about $subject can hopefully help us reason about how much
> additional code complication is justifiable for *fast* 32-bit support.

IMO I don't think it's worth adding extra code for fast 32-bit support 
anymore. However, I'd still be wary of *regressing* performance on 
32-bit systems.

So if you're adding a new fast path to a function, it's OK to make it 
64-bit only, and fall back to the old slower code on 32-bit systems. But 
-1 on *removing* existing 32-bit fast path code, or rewriting things in 
a way that makes an existing function significantly slower than before 
on 32-bit systems.

This isn't black or white though. It depends on how big a gain or 
regression we're talking about, and how complex the extra code would be.

-- 
Heikki Linnakangas
Neon (https://neon.tech)







^ permalink  raw  reply  [nested|flat] 44+ messages in thread

* Re: Is *fast* 32-bit support still important?
  2024-07-30 07:25 Re: Is *fast* 32-bit support still important? Heikki Linnakangas <[email protected]>
@ 2024-08-05 11:46 ` Joel Jacobson <[email protected]>
  0 siblings, 0 replies; 44+ messages in thread

From: Joel Jacobson @ 2024-08-05 11:46 UTC (permalink / raw)
  To: Heikki Linnakangas <[email protected]>; pgsql-hackers

On Tue, Jul 30, 2024, at 09:25, Heikki Linnakangas wrote:
> On 29/07/2024 23:40, Joel Jacobson wrote:
>> To me, it's non-obvious whether introducing `#if SIZEOF_DATUM < 8` with
>> separate 32-bit and 64-bit code paths is worthwhile to maintain performance
>> for both.
>> 
>> Knowing more about $subject can hopefully help us reason about how much
>> additional code complication is justifiable for *fast* 32-bit support.
>
> IMO I don't think it's worth adding extra code for fast 32-bit support 
> anymore. However, I'd still be wary of *regressing* performance on 
> 32-bit systems.
>
> So if you're adding a new fast path to a function, it's OK to make it 
> 64-bit only, and fall back to the old slower code on 32-bit systems. But 
> -1 on *removing* existing 32-bit fast path code, or rewriting things in 
> a way that makes an existing function significantly slower than before 
> on 32-bit systems.
>
> This isn't black or white though. It depends on how big a gain or 
> regression we're talking about, and how complex the extra code would be.

Thanks for input.

I still haven't got any reports from real users of 32-bit PostgreSQL,
so my comments below are based on the assumption that such users exist
and have high performance needs.

I agree that it's not a black or white decision since quantifying complexity
is inherently challenging.

However, perhaps it would be possible to say something about
lower and upper bounds on 32-bit slowdown?

- Below a certain percentage slowdown,
  extra 32-bit code optimization is definitively unnecessary.

- Above a certain percentage slowdown,
  extra 32-bit code optimization is definitively necessary.

In the range between these bounds, I guess the decision should depend on
the specific added code complexity required?

It's also the question what percentage we're reasoning about here.
Is it the time spent in the function, or is it the total execution time?

/Joel






^ permalink  raw  reply  [nested|flat] 44+ messages in thread


end of thread, other threads:[~2024-08-05 11:46 UTC | newest]

Thread overview: 44+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2021-01-07 01:08 [PATCH] doc review: COPY progress: 8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f Justin Pryzby <[email protected]>
2024-07-30 07:25 Re: Is *fast* 32-bit support still important? Heikki Linnakangas <[email protected]>
2024-08-05 11:46 ` Re: Is *fast* 32-bit support still important? Joel Jacobson <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox