Subject: RE: Failed transaction statistics to measure the logical replication progress

From: "[email-masked]" <[email-masked]>
Date: Mon, 3 Jan 2022 05:46:24 +0000

On Wednesday, December 22, 2021 6:14 PM Osumi, Takamichi <[email-masked]> wrote:
> Attached the new patch v19.
Hi,

Thanks for updating the patch.

--- a/src/include/pgstat.h
+++ b/src/include/pgstat.h
@@ -15,6 +15,7 @@
 #include "portability/instr_time.h"
 #include "postmaster/pgarch.h"	/* for MAX_XFN_CHARS */
 #include "replication/logicalproto.h"
+#include "replication/worker_internal.h"

I noticed that the patch includes "worker_internal.h " in pgstat.h.
I think it might be better to only include this file in pgstat.c.

And it seems we can access MyLogicalRepWorker directly in the
following functions instead of passing a parameter.

+extern void pgstat_report_subworker_xact_end(LogicalRepWorker *repWorker,
+											 LogicalRepMsgType command,
+											 bool bforce);
+extern void pgstat_send_subworker_xact_stats(LogicalRepWorker *repWorker,
+											 bool force);

Best regards,
Hou zj