public inbox for [email protected]help / color / mirror / Atom feed
[PATCH v1 01/21] pgstat.h doesn't need hsearch.h 25+ messages / 2 participants [nested] [flat]
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* COPY FROM crash @ 2024-07-30 03:50 Zhang Mingli <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Zhang Mingli @ 2024-07-30 03:50 UTC (permalink / raw) To: PostgreSQL Hackers <[email protected]> Hi, all I got a crash when copy partition tables with mass data in Cloudberry DB[0](based on Postgres14.4, Greenplum 7). I have a test on Postgres and it has the similar issue(different places but same function). However it’s a little hard to reproduce because it happened when inserting next tuple after a previous copy multi insert buffer is flushed. To reproduce easily, change the Macros to: #define MAX_BUFFERED_TUPLES 1 #define MAX_PARTITION_BUFFERS 0 Config and make install, when initdb, a core dump will be as: #0 0x000055de617211b9 in CopyMultiInsertInfoNextFreeSlot (miinfo=0x7ffce496d360, rri=0x55de6368ba88) at copyfrom.c:592 #1 0x000055de61721ff1 in CopyFrom (cstate=0x55de63592ce8) at copyfrom.c:985 #2 0x000055de6171dd86 in DoCopy (pstate=0x55de63589e00, stmt=0x55de635347d8, stmt_location=0, stmt_len=195, processed=0x7ffce496d590) at copy.c:306 #3 0x000055de61ad7ce8 in standard_ProcessUtility (pstmt=0x55de635348a8, queryString=0x55de63533960 "COPY information_schema.sql_features (feature_id, feature_name, sub_feature_id, sub _feature_name, is_supported, comments) FROM E'/home/gpadmin/install/pg17/share/postgresql/sql_features.txt';\n", readOnlyTree=false, context=PROCESS_UTILITY_TOPLEVEL, params=0x0, queryEnv=0x0, dest=0x55de620b0ce0 <debugtupDR>, qc=0x7ffce496d910) at utility.c:735 #4 0x000055de61ad7614 in ProcessUtility (pstmt=0x55de635348a8, queryString=0x55de63533960 "COPY information_schema.sql_features (feature_id, feature_name, sub_feature_id, sub _feature_name, is_supported, comments) FROM E'/home/gpadmin/install/pg17/share/postgresql/sql_features.txt';\n", readOnlyTree=false, context=PROCESS_UTILITY_TOPLEVEL, params=0x0, queryEnv=0x0, dest=0x55de620b0ce0 <debugtupDR>, qc=0x7ffce496d910) at utility.c:523 #5 0x000055de61ad5e8f in PortalRunUtility (portal=0x55de633dd7a0, pstmt=0x55de635348a8, isTopLevel=true, setHoldSnapshot=false, dest=0x55de620b0ce0 <debugtupDR>, qc=0x7ffce496d910) at pquery.c:1158 #6 0x000055de61ad6106 in PortalRunMulti (portal=0x55de633dd7a0, isTopLevel=true, setHoldSnapshot=false, dest=0x55de620b0ce0 <debugtupDR>, altdest=0x55de620b0ce0 <debugtupDR>, qc=0x7ffce496d910) at pquery.c:1315 #7 0x000055de61ad5550 in PortalRun (portal=0x55de633dd7a0, count=9223372036854775807, isTopLevel=true, run_once=true, dest=0x55de620b0ce0 <debugtupDR>, altdest=0x55de620b0ce0 <debugtupDR>, qc=0x7ffce496d910) at pquery.c:791``` The root cause is: we may call CopyMultiInsertInfoFlush() to flush buffer during COPY tuples, ex: insert from next tuple, CopyMultiInsertInfoNextFreeSlot() will get a crash due to null pointer of buffer. To fix it: instead of call CopyMultiInsertInfoSetupBuffer() outside, I put it into CopyMultiInsertInfoNextFreeSlot() to avoid such issues. [0] https://github.com/cloudberrydb/cloudberrydb Zhang Mingli www.hashdata.xyz Attachments: [application/octet-stream] v0-0001-Fix-COPY-FROM-crash-due-to-buffer-flush.patch (1.6K, ../../f722b8fb-1962-4015-8578-e2bd77818ac9@Spark/3-v0-0001-Fix-COPY-FROM-crash-due-to-buffer-flush.patch) download | inline diff: From e5cddef8845715c55592e5f9786b524c668d83d1 Mon Sep 17 00:00:00 2001 From: Zhang Mingli <[email protected]> Date: Tue, 30 Jul 2024 11:10:32 +0800 Subject: [PATCH] Fix COPY FROM crash due to buffer flush. We may call CopyMultiInsertInfoFlush() to flush buffer during COPY tuples, ex: COPY a partitioned table with mass data. To reproduce it easily, change the Macros to: define MAX_BUFFERED_TUPLES 1 define MAX_PARTITION_BUFFERS 0 Config and make install, initdb will get a coredump. When inserting from next tuple CopyMultiInsertInfoNextFreeSlot() will get a crash due to null pointer of buffer. Instead of call CopyMultiInsertInfoSetupBuffer() outside, put it into CopyMultiInsertInfoNextFreeSlot() to avoid such issues. Authored-by: Zhang Mingli [email protected] --- src/backend/commands/copyfrom.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/backend/commands/copyfrom.c b/src/backend/commands/copyfrom.c index ce4d62e707..ef42b4d523 100644 --- a/src/backend/commands/copyfrom.c +++ b/src/backend/commands/copyfrom.c @@ -586,8 +586,15 @@ static inline TupleTableSlot * CopyMultiInsertInfoNextFreeSlot(CopyMultiInsertInfo *miinfo, ResultRelInfo *rri) { - CopyMultiInsertBuffer *buffer = rri->ri_CopyMultiInsertBuffer; - int nused = buffer->nused; + CopyMultiInsertBuffer *buffer; + int nused; + + /* Setup buffer in case it's flushed. */ + if (rri->ri_CopyMultiInsertBuffer == NULL) + CopyMultiInsertInfoSetupBuffer(miinfo, rri); + + buffer = rri->ri_CopyMultiInsertBuffer; + nused = buffer->nused; Assert(buffer != NULL); Assert(nused < MAX_BUFFERED_TUPLES); -- 2.34.1 ^ permalink raw reply [nested|flat] 25+ messages in thread
end of thread, other threads:[~2024-07-30 03:50 UTC | newest] Thread overview: 25+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2024-07-30 03:50 COPY FROM crash Zhang Mingli <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox