Subject: outdated comment in table_tuple_update definition

From: Sergei Kornilov <[email-masked]>
Date: Thu, 06 Feb 2025 22:00:17 +0300

Hello

I noticed that the comment for the table_tuple_update function (src/include/access/tableam.h) describes the update_indexes parameter as boolean:

 *  update_indexes - in success cases this is set to true if new index entries
 *		are required for this tuple
 
Although this parameter is an enum of three values.

I found that the parameter type was changed by commit 19d8e23 (Ignore BRIN indexes when checking for HOT updates), but the comment was not updated. Looks like oversight.

  *  update_indexes - in successful cases, used to determine which index types
  *      require new index entries for this tuple

Something like this?

regards, Sergei