public inbox for [email protected]help / color / mirror / Atom feed
[PATCH v1 01/21] pgstat.h doesn't need hsearch.h 25+ messages / 2 participants [nested] [flat]
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* [PATCH v1 01/21] pgstat.h doesn't need hsearch.h @ 2021-03-15 21:49 Andres Freund <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Andres Freund @ 2021-03-15 21:49 UTC (permalink / raw) --- src/include/pgstat.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/pgstat.h b/src/include/pgstat.h index be43c048028..5ce86ba9ae8 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -18,7 +18,6 @@ #include "portability/instr_time.h" #include "postmaster/pgarch.h" #include "storage/proc.h" -#include "utils/hsearch.h" #include "utils/relcache.h" -- 2.29.2.540.g3cf59784d4 --wilmz2upy33z66yr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0002-WIP-Split-wait-event-reporting-into-its-own-heade.patch" ^ permalink raw reply [nested|flat] 25+ messages in thread
* PATCH: Disallow a netmask of zero unless the IP is also all zeroes @ 2025-02-11 20:05 Greg Sabino Mullane <[email protected]> 0 siblings, 0 replies; 25+ messages in thread From: Greg Sabino Mullane @ 2025-02-11 20:05 UTC (permalink / raw) To: pgsql-hackers I ran into this alarming mistake again the other day. Luckily it was on a dev system. Someone sees an entry in a pg_hba.conf that looks like this: host all all 0.0.0.0/0 md5 They are gobsmacked when they learn this means to let everyone in. So they fix it by adding new entries that look like this: host all all 10.2.55.4/0 md5 host all all 10.2.55.5/0 md5 host all all 10.2.55.6/0 md5 It should, of course, be: host all all 10.2.55.4/32 md5 I say "of course" but few people (even tech ones) know the distinction. (Nor should they have to! But that's for a nearby thread). This patch aims to prevent this very bad footgun by only allowing a /0 if the IP consists of only zeroes. It works for ipv4 and ipv6. Cheers, Greg -- Crunchy Data - https://www.crunchydata.com Enterprise Postgres Software Products & Tech Support Attachments: [application/x-patch] 0001-Only-allow-a-CIDR-mask-of-zero-if-the-IP-contains-only-zeroes.patch (1.4K, ../../CAKAnmmLszoyvq9vPcCwjbyKV=dvTko7fWH9wu77Ngg68=_4Dmw@mail.gmail.com/3-0001-Only-allow-a-CIDR-mask-of-zero-if-the-IP-contains-only-zeroes.patch) download | inline diff: From 9ba3d75999da4c2dfe258516cefa6343851d8955 Mon Sep 17 00:00:00 2001 From: Greg Sabino Mullane <[email protected]> Date: Tue, 11 Feb 2025 11:16:11 -0500 Subject: [PATCH] Only allow a CIDR mask of zero if the IP contains only zeroes. Prevents a common error of not realizing the security implications of 1.2.3.4/0 --- src/backend/libpq/hba.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/src/backend/libpq/hba.c b/src/backend/libpq/hba.c index 510c9ffc6d7..95ff890d461 100644 --- a/src/backend/libpq/hba.c +++ b/src/backend/libpq/hba.c @@ -1600,6 +1600,26 @@ parse_hba_line(TokenizedAuthLine *tok_line, int elevel) token->string); return NULL; } + + /* + * Throw an error if we are putting a /0 on a non-zero IP + * address + */ + if (strspn(cidr_slash + 1, "0") == strlen(cidr_slash + 1) + && strcspn(token->string, "123456789abcdefABCDEF") != strlen(token->string)) + { + ereport(elevel, + (errcode(ERRCODE_CONFIG_FILE_ERROR), + errmsg("invalid CIDR mask in address \"%s\"", + token->string), + errhint("A mask of 0 will allow ALL IP addresses."), + errcontext("line %d of configuration file \"%s\"", + line_num, file_name))); + *err_msg = psprintf("invalid CIDR mask in address \"%s\"", + token->string); + return NULL; + } + parsedline->masklen = parsedline->addrlen; pfree(str); } -- 2.30.2 ^ permalink raw reply [nested|flat] 25+ messages in thread
end of thread, other threads:[~2025-02-11 20:05 UTC | newest] Thread overview: 25+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2021-03-15 21:49 [PATCH v1 01/21] pgstat.h doesn't need hsearch.h Andres Freund <[email protected]> 2025-02-11 20:05 PATCH: Disallow a netmask of zero unless the IP is also all zeroes Greg Sabino Mullane <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox