public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tomas Vondra <[email protected]>
Subject: [PATCH 2/6] 0001 review
Date: Mon, 15 Feb 2021 16:26:32 +0100
---
doc/src/sgml/monitoring.sgml | 2 +-
src/backend/commands/copyfrom.c | 1 +
src/backend/commands/copyto.c | 2 ++
3 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 3c39c82f1a..c5048fefd4 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -6561,7 +6561,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
<para>
The io target that the data is read from or written to:
<literal>FILE</literal>, <literal>PROGRAM</literal>,
- <literal>STDIO</literal> (for COPY FROM STDIN and COPY TO STDOUT),
+ <literal>STDIO</literal> (for <command>COPY FROM STDIN</command> and <command>COPY TO STDOUT</command>),
or <literal>CALLBACK</literal> (used in the table synchronization
background worker).
</para></entry>
diff --git a/src/backend/commands/copyfrom.c b/src/backend/commands/copyfrom.c
index c3610eb67e..d98f447cf5 100644
--- a/src/backend/commands/copyfrom.c
+++ b/src/backend/commands/copyfrom.c
@@ -1508,6 +1508,7 @@ BeginCopyFrom(ParseState *pstate,
ReceiveCopyBinaryHeader(cstate);
}
+ /* XXX this block seems weird */
{
int64 io_target;
switch (cstate->copy_src)
diff --git a/src/backend/commands/copyto.c b/src/backend/commands/copyto.c
index 42c4a828df..4b76bf5ef6 100644
--- a/src/backend/commands/copyto.c
+++ b/src/backend/commands/copyto.c
@@ -772,6 +772,8 @@ BeginCopyTo(ParseState *pstate,
/* initialize progress */
pgstat_progress_start_command(PROGRESS_COMMAND_COPY,
cstate->rel ? RelationGetRelid(cstate->rel) : InvalidOid);
+
+ /* XXX this too */
{
const int progress_index[] = {
PROGRESS_COPY_COMMAND,
--
2.26.2
--------------DA8D60BF026F7ACE69A9AEE5
Content-Type: text/x-patch; charset=UTF-8;
name="v7-0003-Add-backlinks-to-progress-reporting-documentation.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename*0="v7-0003-Add-backlinks-to-progress-reporting-documentation.pa";
filename*1="tch"
view thread (22+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [PATCH 2/6] 0001 review
In-Reply-To: <no-message-id-1878803@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox