public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tomas Vondra <[email protected]>
Subject: [PATCH 08/10] review
Date: Wed, 17 Mar 2021 02:36:08 +0100
---
src/backend/commands/explain.c | 1 +
src/backend/executor/nodeIndexscan.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/src/backend/commands/explain.c b/src/backend/commands/explain.c
index a160de5493..3b0b38099f 100644
--- a/src/backend/commands/explain.c
+++ b/src/backend/commands/explain.c
@@ -1110,6 +1110,7 @@ ExplainIndexSkipScanKeys(int skipPrefixSize, ExplainState *es)
{
if (skipPrefixSize > 0)
{
+ /* FIXME Why not to show this for TEXT output? */
if (es->format != EXPLAIN_FORMAT_TEXT)
ExplainPropertyInteger("Distinct Prefix", NULL, skipPrefixSize, es);
}
diff --git a/src/backend/executor/nodeIndexscan.c b/src/backend/executor/nodeIndexscan.c
index 71aac4493d..720442b731 100644
--- a/src/backend/executor/nodeIndexscan.c
+++ b/src/backend/executor/nodeIndexscan.c
@@ -124,6 +124,8 @@ IndexNext(IndexScanState *node)
node->iss_ScanDesc = scandesc;
+ /* FIXME Is the else branch necessary? */
+
/* Index skip scan assumes xs_want_itup, so set it to true */
if (indexscan->indexskipprefixsize > 0)
node->iss_ScanDesc->xs_want_itup = true;
--
2.30.2
--------------F495F6B18672582269F00FF9
Content-Type: text/x-patch; charset=UTF-8;
name="0009-Btree-implementation-of-skipping-20210317.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="0009-Btree-implementation-of-skipping-20210317.patch"
view thread (53+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [PATCH 08/10] review
In-Reply-To: <no-message-id-1880322@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox