agora inbox for [email protected]help / color / mirror / Atom feed
[PATCH v2 6/7] TupleHashTable.entrysize was unused except for instrumentation.. 8+ messages / 2 participants [nested] [flat]
* [PATCH v9 7/8] TupleHashTable.entrysize was unused except for instrumentation.. @ 2020-02-15 23:19 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 8+ messages in thread From: Justin Pryzby @ 2020-02-15 23:19 UTC (permalink / raw) --- src/backend/executor/execGrouping.c | 1 - src/include/nodes/execnodes.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/backend/executor/execGrouping.c b/src/backend/executor/execGrouping.c index 009d27b9a8..98fd4bf8bd 100644 --- a/src/backend/executor/execGrouping.c +++ b/src/backend/executor/execGrouping.c @@ -183,7 +183,6 @@ BuildTupleHashTableExt(PlanState *parent, hashtable->tab_collations = collations; hashtable->tablecxt = tablecxt; hashtable->tempcxt = tempcxt; - hashtable->entrysize = entrysize; hashtable->tableslot = NULL; /* will be made on first lookup */ hashtable->inputslot = NULL; hashtable->in_hash_funcs = NULL; diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h index 10239aea4f..bca77d52b6 100644 --- a/src/include/nodes/execnodes.h +++ b/src/include/nodes/execnodes.h @@ -730,7 +730,6 @@ typedef struct TupleHashTableData Oid *tab_collations; /* collations for hash and comparison */ MemoryContext tablecxt; /* memory context containing table */ MemoryContext tempcxt; /* context for function evaluations */ - Size entrysize; /* actual size to make each hash entry */ TupleTableSlot *tableslot; /* slot for referencing table entries */ /* The following fields are set transiently for each table search: */ TupleTableSlot *inputslot; /* current input tuple's slot */ -- 2.17.0 --wwtQuX191/I956S7 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v9-0008-Update-comment-obsolete-since-69c3936a.patch" ^ permalink raw reply [nested|flat] 8+ messages in thread
* [PATCH v6 6/7] TupleHashTable.entrysize was unused except for instrumentation.. @ 2020-02-15 23:19 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 8+ messages in thread From: Justin Pryzby @ 2020-02-15 23:19 UTC (permalink / raw) --- src/backend/executor/execGrouping.c | 1 - src/include/nodes/execnodes.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/backend/executor/execGrouping.c b/src/backend/executor/execGrouping.c index 009d27b9a8..98fd4bf8bd 100644 --- a/src/backend/executor/execGrouping.c +++ b/src/backend/executor/execGrouping.c @@ -183,7 +183,6 @@ BuildTupleHashTableExt(PlanState *parent, hashtable->tab_collations = collations; hashtable->tablecxt = tablecxt; hashtable->tempcxt = tempcxt; - hashtable->entrysize = entrysize; hashtable->tableslot = NULL; /* will be made on first lookup */ hashtable->inputslot = NULL; hashtable->in_hash_funcs = NULL; diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h index 11fe866c1c..3a335d87a0 100644 --- a/src/include/nodes/execnodes.h +++ b/src/include/nodes/execnodes.h @@ -726,7 +726,6 @@ typedef struct TupleHashTableData Oid *tab_collations; /* collations for hash and comparison */ MemoryContext tablecxt; /* memory context containing table */ MemoryContext tempcxt; /* context for function evaluations */ - Size entrysize; /* actual size to make each hash entry */ TupleTableSlot *tableslot; /* slot for referencing table entries */ /* The following fields are set transiently for each table search: */ TupleTableSlot *inputslot; /* current input tuple's slot */ -- 2.17.0 --xHbokkKX1kTiQeDC Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0007-Update-comment-obsolete-since-69c3936a.patch" ^ permalink raw reply [nested|flat] 8+ messages in thread
* [PATCH v7 6/9] TupleHashTable.entrysize was unused except for instrumentation.. @ 2020-02-15 23:19 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 8+ messages in thread From: Justin Pryzby @ 2020-02-15 23:19 UTC (permalink / raw) --- src/backend/executor/execGrouping.c | 1 - src/include/nodes/execnodes.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/backend/executor/execGrouping.c b/src/backend/executor/execGrouping.c index 009d27b9a8..98fd4bf8bd 100644 --- a/src/backend/executor/execGrouping.c +++ b/src/backend/executor/execGrouping.c @@ -183,7 +183,6 @@ BuildTupleHashTableExt(PlanState *parent, hashtable->tab_collations = collations; hashtable->tablecxt = tablecxt; hashtable->tempcxt = tempcxt; - hashtable->entrysize = entrysize; hashtable->tableslot = NULL; /* will be made on first lookup */ hashtable->inputslot = NULL; hashtable->in_hash_funcs = NULL; diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h index 11fe866c1c..3a335d87a0 100644 --- a/src/include/nodes/execnodes.h +++ b/src/include/nodes/execnodes.h @@ -726,7 +726,6 @@ typedef struct TupleHashTableData Oid *tab_collations; /* collations for hash and comparison */ MemoryContext tablecxt; /* memory context containing table */ MemoryContext tempcxt; /* context for function evaluations */ - Size entrysize; /* actual size to make each hash entry */ TupleTableSlot *tableslot; /* slot for referencing table entries */ /* The following fields are set transiently for each table search: */ TupleTableSlot *inputslot; /* current input tuple's slot */ -- 2.17.0 --UfEAyuTBtIjiZzX6 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v7-0007-Update-comment-obsolete-since-69c3936a.patch" ^ permalink raw reply [nested|flat] 8+ messages in thread
* [PATCH v2 6/7] TupleHashTable.entrysize was unused except for instrumentation.. @ 2020-02-15 23:19 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 8+ messages in thread From: Justin Pryzby @ 2020-02-15 23:19 UTC (permalink / raw) --- src/backend/executor/execGrouping.c | 1 - src/include/nodes/execnodes.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/backend/executor/execGrouping.c b/src/backend/executor/execGrouping.c index de0205f..d76a630 100644 --- a/src/backend/executor/execGrouping.c +++ b/src/backend/executor/execGrouping.c @@ -186,7 +186,6 @@ BuildTupleHashTableExt(PlanState *parent, hashtable->tab_collations = collations; hashtable->tablecxt = tablecxt; hashtable->tempcxt = tempcxt; - hashtable->entrysize = entrysize; hashtable->tableslot = NULL; /* will be made on first lookup */ hashtable->inputslot = NULL; hashtable->in_hash_funcs = NULL; diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h index f8c93dd..2bcd140 100644 --- a/src/include/nodes/execnodes.h +++ b/src/include/nodes/execnodes.h @@ -724,7 +724,6 @@ typedef struct TupleHashTableData Oid *tab_collations; /* collations for hash and comparison */ MemoryContext tablecxt; /* memory context containing table */ MemoryContext tempcxt; /* context for function evaluations */ - Size entrysize; /* actual size to make each hash entry */ TupleTableSlot *tableslot; /* slot for referencing table entries */ /* The following fields are set transiently for each table search: */ TupleTableSlot *inputslot; /* current input tuple's slot */ -- 2.7.4 --DiL7RhKs8rK9YGuF Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v2-0007-Update-comment-obsolete-since-69c3936a.patch" ^ permalink raw reply [nested|flat] 8+ messages in thread
* [PATCH v3 6/7] TupleHashTable.entrysize was unused except for instrumentation.. @ 2020-02-15 23:19 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 8+ messages in thread From: Justin Pryzby @ 2020-02-15 23:19 UTC (permalink / raw) --- src/backend/executor/execGrouping.c | 1 - src/include/nodes/execnodes.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/backend/executor/execGrouping.c b/src/backend/executor/execGrouping.c index de0205f..d76a630 100644 --- a/src/backend/executor/execGrouping.c +++ b/src/backend/executor/execGrouping.c @@ -186,7 +186,6 @@ BuildTupleHashTableExt(PlanState *parent, hashtable->tab_collations = collations; hashtable->tablecxt = tablecxt; hashtable->tempcxt = tempcxt; - hashtable->entrysize = entrysize; hashtable->tableslot = NULL; /* will be made on first lookup */ hashtable->inputslot = NULL; hashtable->in_hash_funcs = NULL; diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h index df56330..6eac7de 100644 --- a/src/include/nodes/execnodes.h +++ b/src/include/nodes/execnodes.h @@ -724,7 +724,6 @@ typedef struct TupleHashTableData Oid *tab_collations; /* collations for hash and comparison */ MemoryContext tablecxt; /* memory context containing table */ MemoryContext tempcxt; /* context for function evaluations */ - Size entrysize; /* actual size to make each hash entry */ TupleTableSlot *tableslot; /* slot for referencing table entries */ /* The following fields are set transiently for each table search: */ TupleTableSlot *inputslot; /* current input tuple's slot */ -- 2.7.4 --SNIs70sCzqvszXB4 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v3-0007-Update-comment-obsolete-since-69c3936a.patch" ^ permalink raw reply [nested|flat] 8+ messages in thread
* [PATCH v4 6/7] TupleHashTable.entrysize was unused except for instrumentation.. @ 2020-02-15 23:19 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 8+ messages in thread From: Justin Pryzby @ 2020-02-15 23:19 UTC (permalink / raw) --- src/backend/executor/execGrouping.c | 1 - src/include/nodes/execnodes.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/backend/executor/execGrouping.c b/src/backend/executor/execGrouping.c index de0205f..d76a630 100644 --- a/src/backend/executor/execGrouping.c +++ b/src/backend/executor/execGrouping.c @@ -186,7 +186,6 @@ BuildTupleHashTableExt(PlanState *parent, hashtable->tab_collations = collations; hashtable->tablecxt = tablecxt; hashtable->tempcxt = tempcxt; - hashtable->entrysize = entrysize; hashtable->tableslot = NULL; /* will be made on first lookup */ hashtable->inputslot = NULL; hashtable->in_hash_funcs = NULL; diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h index 87b1127..3f9ac5e 100644 --- a/src/include/nodes/execnodes.h +++ b/src/include/nodes/execnodes.h @@ -727,7 +727,6 @@ typedef struct TupleHashTableData Oid *tab_collations; /* collations for hash and comparison */ MemoryContext tablecxt; /* memory context containing table */ MemoryContext tempcxt; /* context for function evaluations */ - Size entrysize; /* actual size to make each hash entry */ TupleTableSlot *tableslot; /* slot for referencing table entries */ /* The following fields are set transiently for each table search: */ TupleTableSlot *inputslot; /* current input tuple's slot */ -- 2.7.4 --jI8keyz6grp/JLjh Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v4-0007-Update-comment-obsolete-since-69c3936a.patch" ^ permalink raw reply [nested|flat] 8+ messages in thread
* [PATCH v5 6/7] TupleHashTable.entrysize was unused except for instrumentation.. @ 2020-02-15 23:19 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 8+ messages in thread From: Justin Pryzby @ 2020-02-15 23:19 UTC (permalink / raw) --- src/backend/executor/execGrouping.c | 1 - src/include/nodes/execnodes.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/backend/executor/execGrouping.c b/src/backend/executor/execGrouping.c index de0205f..d76a630 100644 --- a/src/backend/executor/execGrouping.c +++ b/src/backend/executor/execGrouping.c @@ -186,7 +186,6 @@ BuildTupleHashTableExt(PlanState *parent, hashtable->tab_collations = collations; hashtable->tablecxt = tablecxt; hashtable->tempcxt = tempcxt; - hashtable->entrysize = entrysize; hashtable->tableslot = NULL; /* will be made on first lookup */ hashtable->inputslot = NULL; hashtable->in_hash_funcs = NULL; diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h index 11fe866..3a335d8 100644 --- a/src/include/nodes/execnodes.h +++ b/src/include/nodes/execnodes.h @@ -726,7 +726,6 @@ typedef struct TupleHashTableData Oid *tab_collations; /* collations for hash and comparison */ MemoryContext tablecxt; /* memory context containing table */ MemoryContext tempcxt; /* context for function evaluations */ - Size entrysize; /* actual size to make each hash entry */ TupleTableSlot *tableslot; /* slot for referencing table entries */ /* The following fields are set transiently for each table search: */ TupleTableSlot *inputslot; /* current input tuple's slot */ -- 2.7.4 --M0YLxmUXciMpOLPE Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v5-0007-Update-comment-obsolete-since-69c3936a.patch" ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Asynchronous and "direct" IO support for PostgreSQL. @ 2022-01-12 07:18 Julien Rouhaud <[email protected]> 0 siblings, 0 replies; 8+ messages in thread From: Julien Rouhaud @ 2022-01-12 07:18 UTC (permalink / raw) To: Andres Freund <[email protected]>; +Cc: pgsql-hackers; Thomas Munro <[email protected]>; David Rowley <[email protected]>; Melanie Plageman <[email protected]> Hi, On Wed, Sep 1, 2021 at 1:57 PM Andres Freund <[email protected]> wrote: > > I've attached the code for posterity, but the series is large enough that I > don't think it makes sense to do that all that often... Agreed. > The code is at > https://github.com/anarazel/postgres/tree/aio Just FYI the cfbot says that this version of the patchset doesn't apply anymore, and it seems that your branch was only rebased to 43c1c4f (Sept. 21th) which doesn't rebase cleanly: error: could not apply 8a20594f2f... lwlock, xlog: Report caller wait event for LWLockWaitForVar. Since it's still a WIP and a huge patchset I'm not sure if I should switch the cf entry to Waiting on Author or not as it's probably going to rot quite fast anyway. Just to be safe I'll go ahead and change the status. If that's unhelpful just let me know and I'll switch it back to needs review, as people motivated enough to review the patch can still work with 43c1c4f as a starting point. ^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2022-01-12 07:18 UTC | newest] Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-02-15 23:19 [PATCH v9 7/8] TupleHashTable.entrysize was unused except for instrumentation.. Justin Pryzby <[email protected]> 2020-02-15 23:19 [PATCH v6 6/7] TupleHashTable.entrysize was unused except for instrumentation.. Justin Pryzby <[email protected]> 2020-02-15 23:19 [PATCH v7 6/9] TupleHashTable.entrysize was unused except for instrumentation.. Justin Pryzby <[email protected]> 2020-02-15 23:19 [PATCH v2 6/7] TupleHashTable.entrysize was unused except for instrumentation.. Justin Pryzby <[email protected]> 2020-02-15 23:19 [PATCH v3 6/7] TupleHashTable.entrysize was unused except for instrumentation.. Justin Pryzby <[email protected]> 2020-02-15 23:19 [PATCH v4 6/7] TupleHashTable.entrysize was unused except for instrumentation.. Justin Pryzby <[email protected]> 2020-02-15 23:19 [PATCH v5 6/7] TupleHashTable.entrysize was unused except for instrumentation.. Justin Pryzby <[email protected]> 2022-01-12 07:18 Re: Asynchronous and "direct" IO support for PostgreSQL. Julien Rouhaud <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox