agora inbox for [email protected]  
help / color / mirror / Atom feed
From: Justin Pryzby <[email protected]>
Subject: [PATCH v1] Indent and repeat name of library failing to load
Date: Wed, 2 Oct 2019 12:08:37 -0500

---
 src/bin/pg_upgrade/function.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/bin/pg_upgrade/function.c b/src/bin/pg_upgrade/function.c
index 0c66d1c..68d3634 100644
--- a/src/bin/pg_upgrade/function.c
+++ b/src/bin/pg_upgrade/function.c
@@ -255,9 +255,16 @@ check_loadable_libraries(void)
 			PQclear(res);
 		}
 
-		if (was_load_failure)
-			fprintf(script, _("Database: %s\n"),
+		if (was_load_failure) {
+			/*
+			 * Having probed that the library failed to load once,
+			 * assume that it won't load in any DB and output each
+			 * DB which would try to load it.
+			 */
+			fprintf(script, _(" - database loading %s: %s\n"),
+					lib,
 					old_cluster.dbarr.dbs[os_info.libraries[libnum].dbnum].db_name);
+		}
 	}
 
 	PQfinish(conn);
-- 
2.7.4


--EVF5PPMfhYS0aIcm--





view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [PATCH v1] Indent and repeat name of library failing to load
  In-Reply-To: <no-message-id-1882280@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox