Subject: Re: Add missing PGDLLIMPORT markings

From: Daniel Gustafsson <[email-masked]>
Date: Wed, 9 Apr 2025 13:48:06 +0200

> On 9 Apr 2025, at 12:02, Peter Eisentraut <[email-masked]> wrote:

-extern const pg_be_sasl_mech pg_be_oauth_mech;
+extern PGDLLIMPORT const pg_be_sasl_mech pg_be_oauth_mech;
+1 on this.

> Btw., this new variable in memutils.h
> 
>    extern dsa_area *area;
> 
> could probably do with a less generic name?

Good point, unless objected to I'll apply the attached renaming which then also
contain the PGDLLIMPORT addition.

--
Daniel Gustafsson

---

From: Jacob Champion <[email-masked]>
Date: Wed, 9 Apr 2025 05:30:40 -0700

> +extern PGDLLIMPORT const pg_be_sasl_mech pg_be_oauth_mech;

LGTM, too.

Thanks!
--Jacob

---

From: Daniel Gustafsson <[email-masked]>
Date: Fri, 11 Apr 2025 00:38:02 +0200

> On 9 Apr 2025, at 13:48, Daniel Gustafsson <[email-masked]> wrote:

> contain the PGDLLIMPORT addition.

Done.

--
Daniel Gustafsson