agora inbox for pgsql-hackers@postgresql.orghelp / color / mirror / Atom feed
[PATCH 2/9] Silence compiler warning 7+ messages / 3 participants [nested] [flat]
* [PATCH 2/9] Silence compiler warning @ 2019-09-26 20:39 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 7+ messages in thread From: Alvaro Herrera @ 2019-09-26 20:39 UTC (permalink / raw) --- src/backend/parser/parse_coerce.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/backend/parser/parse_coerce.c b/src/backend/parser/parse_coerce.c index f0b1f6f831..aab2348952 100644 --- a/src/backend/parser/parse_coerce.c +++ b/src/backend/parser/parse_coerce.c @@ -1919,6 +1919,8 @@ enforce_generic_type_consistency(const Oid *actual_arg_types, format_type_be(elem_typeid)))); } } + else + range_typelem = InvalidOid; /* Get the range type based on the multirange type, if we have one */ if (OidIsValid(multirange_typeid)) -- 2.17.1 --G4iJoqBmSsgzjUCe Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0003-Silence-mixed-declarations-and-code-compiler-warning.patch" ^ permalink raw reply [nested|flat] 7+ messages in thread
* [PATCH v11 2/4] silence compiler warning @ 2019-11-28 22:08 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 7+ messages in thread From: Alvaro Herrera @ 2019-11-28 22:08 UTC (permalink / raw) --- src/backend/parser/parse_coerce.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/backend/parser/parse_coerce.c b/src/backend/parser/parse_coerce.c index 47d17f43a4..ff1310c8f4 100644 --- a/src/backend/parser/parse_coerce.c +++ b/src/backend/parser/parse_coerce.c @@ -1593,6 +1593,8 @@ check_generic_type_consistency(const Oid *actual_arg_types, else range_typelem = InvalidOid; /* keep compiler quiet */ } + else + range_typelem = InvalidOid; /* keep compiler quiet */ /* Get the element type based on the multirange type, if we have one */ if (OidIsValid(multirange_typeid)) -- 2.20.1 --wRRV7LY7NUeQGEoC Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v11-0003-whitespace-tweaks.patch" ^ permalink raw reply [nested|flat] 7+ messages in thread
* [PATCH v7 06/13] silence compiler warning @ 2019-11-28 22:08 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 7+ messages in thread From: Alvaro Herrera @ 2019-11-28 22:08 UTC (permalink / raw) --- src/backend/parser/parse_coerce.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/backend/parser/parse_coerce.c b/src/backend/parser/parse_coerce.c index 49c75dc12d..b43b2dc612 100644 --- a/src/backend/parser/parse_coerce.c +++ b/src/backend/parser/parse_coerce.c @@ -1592,6 +1592,8 @@ check_generic_type_consistency(const Oid *actual_arg_types, return false; } } + else + range_typelem = InvalidOid; /* keep compiler quiet */ /* Get the element type based on the multirange type, if we have one */ if (OidIsValid(multirange_typeid)) -- 2.20.1 --ZPt4rx8FFjLCG7dd Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v7-0007-Be-less-verbose-on-variable-names.patch" ^ permalink raw reply [nested|flat] 7+ messages in thread
* [PATCH 2/6] silence compiler warning @ 2019-11-28 22:08 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 7+ messages in thread From: Alvaro Herrera @ 2019-11-28 22:08 UTC (permalink / raw) --- src/backend/parser/parse_coerce.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/backend/parser/parse_coerce.c b/src/backend/parser/parse_coerce.c index 49c75dc12d..b43b2dc612 100644 --- a/src/backend/parser/parse_coerce.c +++ b/src/backend/parser/parse_coerce.c @@ -1592,6 +1592,8 @@ check_generic_type_consistency(const Oid *actual_arg_types, return false; } } + else + range_typelem = InvalidOid; /* keep compiler quiet */ /* Get the element type based on the multirange type, if we have one */ if (OidIsValid(multirange_typeid)) -- 2.20.1 --+QahgC5+KEYLbs62 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0003-Be-less-verbose-on-variable-names.patch" ^ permalink raw reply [nested|flat] 7+ messages in thread
* [PATCH 4/5] silence compiler warning @ 2020-03-23 21:50 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 7+ messages in thread From: Alvaro Herrera @ 2020-03-23 21:50 UTC (permalink / raw) --- src/backend/utils/fmgr/funcapi.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/backend/utils/fmgr/funcapi.c b/src/backend/utils/fmgr/funcapi.c index ab24359981..3bfefcf48a 100644 --- a/src/backend/utils/fmgr/funcapi.c +++ b/src/backend/utils/fmgr/funcapi.c @@ -508,10 +508,13 @@ resolve_anyelement_from_others(polymorphic_actuals *actuals) else if (OidIsValid(actuals->anymultirange_type)) { /* Use the element type based on the multirange type */ - Oid multirange_base_type = getBaseType(actuals->anymultirange_type); - Oid multirange_typelem = - get_range_multirange_subtype(multirange_base_type); + Oid multirange_base_type; + Oid multirange_typelem; + Oid range_base_type; + Oid range_typelem; + multirange_base_type = getBaseType(actuals->anymultirange_type); + multirange_typelem = get_range_multirange_subtype(multirange_base_type); if (!OidIsValid(multirange_typelem)) ereport(ERROR, (errcode(ERRCODE_DATATYPE_MISMATCH), @@ -519,8 +522,8 @@ resolve_anyelement_from_others(polymorphic_actuals *actuals) "anymultirange", format_type_be(multirange_base_type)))); - Oid range_base_type = getBaseType(multirange_typelem); - Oid range_typelem = get_range_subtype(range_base_type); + range_base_type = getBaseType(multirange_typelem); + range_typelem = get_range_subtype(range_base_type); if (!OidIsValid(range_typelem)) ereport(ERROR, -- 2.20.1 --CE+1k2dSO48ffgeK Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0005-rename-get_range_multirange_subtype-to-get_multirang.patch" ^ permalink raw reply [nested|flat] 7+ messages in thread
* [PATCH v1 1/1] silence compiler warning @ 2022-03-14 23:00 Nathan Bossart <nathandbossart@gmail.com> 0 siblings, 0 replies; 7+ messages in thread From: Nathan Bossart @ 2022-03-14 23:00 UTC (permalink / raw) --- src/backend/replication/logical/worker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/replication/logical/worker.c b/src/backend/replication/logical/worker.c index a1fe81b34f..03e069c7cd 100644 --- a/src/backend/replication/logical/worker.c +++ b/src/backend/replication/logical/worker.c @@ -3387,7 +3387,7 @@ TwoPhaseTransactionGid(Oid subid, TransactionId xid, char *gid, int szgid) static void start_table_sync(XLogRecPtr *origin_startpos, char **myslotname) { - char *syncslotname; + char *syncslotname = NULL; Assert(am_tablesync_worker()); -- 2.25.1 --ibTvN161/egqYuK8-- ^ permalink raw reply [nested|flat] 7+ messages in thread
* [PATCH v9 3/7] Row pattern recognition patch (planner). @ 2023-10-04 05:51 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Tatsuo Ishii @ 2023-10-04 05:51 UTC (permalink / raw) --- src/backend/optimizer/plan/createplan.c | 23 ++++++++++++++++++----- src/backend/optimizer/plan/setrefs.c | 23 +++++++++++++++++++++++ src/include/nodes/plannodes.h | 15 +++++++++++++++ 3 files changed, 56 insertions(+), 5 deletions(-) diff --git a/src/backend/optimizer/plan/createplan.c b/src/backend/optimizer/plan/createplan.c index 34ca6d4ac2..469fcd156b 100644 --- a/src/backend/optimizer/plan/createplan.c +++ b/src/backend/optimizer/plan/createplan.c @@ -286,9 +286,10 @@ static WindowAgg *make_windowagg(List *tlist, Index winref, int ordNumCols, AttrNumber *ordColIdx, Oid *ordOperators, Oid *ordCollations, int frameOptions, Node *startOffset, Node *endOffset, Oid startInRangeFunc, Oid endInRangeFunc, - Oid inRangeColl, bool inRangeAsc, bool inRangeNullsFirst, - List *runCondition, List *qual, bool topWindow, - Plan *lefttree); + Oid inRangeColl, bool inRangeAsc, bool inRangeNullsFirst, List *runCondition, + RPSkipTo rpSkipTo, List *patternVariable, List *patternRegexp, List *defineClause, + List *defineInitial, + List *qual, bool topWindow, Plan *lefttree); static Group *make_group(List *tlist, List *qual, int numGroupCols, AttrNumber *grpColIdx, Oid *grpOperators, Oid *grpCollations, Plan *lefttree); @@ -2698,6 +2699,11 @@ create_windowagg_plan(PlannerInfo *root, WindowAggPath *best_path) wc->inRangeAsc, wc->inRangeNullsFirst, wc->runCondition, + wc->rpSkipTo, + wc->patternVariable, + wc->patternRegexp, + wc->defineClause, + wc->defineInitial, best_path->qual, best_path->topwindow, subplan); @@ -6601,8 +6607,10 @@ make_windowagg(List *tlist, Index winref, int ordNumCols, AttrNumber *ordColIdx, Oid *ordOperators, Oid *ordCollations, int frameOptions, Node *startOffset, Node *endOffset, Oid startInRangeFunc, Oid endInRangeFunc, - Oid inRangeColl, bool inRangeAsc, bool inRangeNullsFirst, - List *runCondition, List *qual, bool topWindow, Plan *lefttree) + Oid inRangeColl, bool inRangeAsc, bool inRangeNullsFirst, List *runCondition, + RPSkipTo rpSkipTo, List *patternVariable, List *patternRegexp, List *defineClause, + List *defineInitial, + List *qual, bool topWindow, Plan *lefttree) { WindowAgg *node = makeNode(WindowAgg); Plan *plan = &node->plan; @@ -6628,6 +6636,11 @@ make_windowagg(List *tlist, Index winref, node->inRangeAsc = inRangeAsc; node->inRangeNullsFirst = inRangeNullsFirst; node->topWindow = topWindow; + node->rpSkipTo = rpSkipTo, + node->patternVariable = patternVariable; + node->patternRegexp = patternRegexp; + node->defineClause = defineClause; + node->defineInitial = defineInitial; plan->targetlist = tlist; plan->lefttree = lefttree; diff --git a/src/backend/optimizer/plan/setrefs.c b/src/backend/optimizer/plan/setrefs.c index 7962200885..20ce399763 100644 --- a/src/backend/optimizer/plan/setrefs.c +++ b/src/backend/optimizer/plan/setrefs.c @@ -2456,6 +2456,29 @@ set_upper_references(PlannerInfo *root, Plan *plan, int rtoffset) NRM_EQUAL, NUM_EXEC_QUAL(plan)); + /* + * Modifies an expression tree in each DEFINE clause so that all Var + * nodes reference outputs of a subplan. + */ + if (IsA(plan, WindowAgg)) + { + WindowAgg *wplan = (WindowAgg *) plan; + + foreach(l, wplan->defineClause) + { + TargetEntry *tle = (TargetEntry *) lfirst(l); + + tle->expr = (Expr *) + fix_upper_expr(root, + (Node *) tle->expr, + subplan_itlist, + OUTER_VAR, + rtoffset, + NRM_EQUAL, + NUM_EXEC_QUAL(plan)); + } + } + pfree(subplan_itlist); } diff --git a/src/include/nodes/plannodes.h b/src/include/nodes/plannodes.h index 8cafbf3f8a..e48b59517d 100644 --- a/src/include/nodes/plannodes.h +++ b/src/include/nodes/plannodes.h @@ -1096,6 +1096,21 @@ typedef struct WindowAgg /* nulls sort first for in_range tests? */ bool inRangeNullsFirst; + /* Row Pattern Recognition AFTER MACH SKIP clause */ + RPSkipTo rpSkipTo; /* Row Pattern Skip To type */ + + /* Row Pattern PATTERN variable name (list of String) */ + List *patternVariable; + + /* Row Pattern RPATTERN regular expression quantifier ('+' or ''. list of String) */ + List *patternRegexp; + + /* Row Pattern DEFINE clause (list of TargetEntry) */ + List *defineClause; + + /* Row Pattern DEFINE variable initial names (list of String) */ + List *defineInitial; + /* * false for all apart from the WindowAgg that's closest to the root of * the plan -- 2.25.1 ----Next_Part(Wed_Oct__4_15_03_28_2023_821)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="v9-0004-Row-pattern-recognition-patch-executor.patch" ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2023-10-04 05:51 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-09-26 20:39 [PATCH 2/9] Silence compiler warning Alvaro Herrera <alvherre@alvh.no-ip.org> 2019-11-28 22:08 [PATCH v11 2/4] silence compiler warning Alvaro Herrera <alvherre@alvh.no-ip.org> 2019-11-28 22:08 [PATCH v7 06/13] silence compiler warning Alvaro Herrera <alvherre@alvh.no-ip.org> 2019-11-28 22:08 [PATCH 2/6] silence compiler warning Alvaro Herrera <alvherre@alvh.no-ip.org> 2020-03-23 21:50 [PATCH 4/5] silence compiler warning Alvaro Herrera <alvherre@alvh.no-ip.org> 2022-03-14 23:00 [PATCH v1 1/1] silence compiler warning Nathan Bossart <nathandbossart@gmail.com> 2023-10-04 05:51 [PATCH v9 3/7] Row pattern recognition patch (planner). Tatsuo Ishii <ishii@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox