Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDI9k-0004x1-Eb for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Apr 2019 00:29:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hDI9i-0008BS-NX for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Apr 2019 00:28:58 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDI9i-0008BK-5C for pgsql-hackers@lists.postgresql.org; Mon, 08 Apr 2019 00:28:58 +0000 Received: from mail-it1-x135.google.com ([2607:f8b0:4864:20::135]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDI9a-0005Hy-J6 for pgsql-hackers@lists.postgresql.org; Mon, 08 Apr 2019 00:28:56 +0000 Received: by mail-it1-x135.google.com with SMTP id s3so18078648itk.1 for ; Sun, 07 Apr 2019 17:28:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=XMsgeVE0AIK6Wt1GsFtn6w/GBv4IRfNuFcbFJTpgUnY=; b=FjPGYXsLaVQk6XOmz9Blup+LHlFH06RVvPGqA1RtePa+p7cYHge74xSGCS9ou8fhMl EpvYECwz+oQAzmFc4uekYMPOPH40m76RtTyqqRmXfRe2VWn553cW2FbhcURPwNf2uCm7 UdMQl0eiKjX+MKqeuWf05YCHJAIMY0iWGhpIS1W0iN+nVL610Q4U6CEfijXtnG72TZvm mUe7KZLzYwznefLa5t0vb54hFIUP8vtgJW3EbMn37/2vk2JjyKlJDrTOEToZztmmKTz5 +lG/47r8hAkUXZisV+CVdBjJeQnUdMWEf+bGka8DDGs6mH2r7xOjm4aOZNJdf/QOmC5y JJXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=XMsgeVE0AIK6Wt1GsFtn6w/GBv4IRfNuFcbFJTpgUnY=; b=fbcvKqOzNtQ3gM6cxFqlL/S8rY/BHhjxIdakE4Je+z0pshKJhr1gSsm8igB4Xe+6S4 XAckhDgykO/fhlWQIFjYxKxR/jEExmubGLfSIKtQhdl07fkySnvTX2sUDMlHwW6RI6aa XYVMvBJgYkeJ1xi2A/sGbg9hf/WLt/bgi7y/jo5zRMqtIOeLX0Mwtx30opA0mnKRuVjG U0cQ1FavL54Ihq0CkktLTwoegImCyrGzFMFG4LcWkkfJ4AgDokljy/DnbuG5p/japHXY niZ5MEmiJJD3w++HfDTb8AyxSzYaRSF8lAVpfyoQvMVL/nvNqpcdZ/cz/6Kuaet/4RKt eYBQ== X-Gm-Message-State: APjAAAXrkUh18AE04zPsB4dB5QJ1JLLoefu6m3aj/tsKT/Ah4BvPNs0O VOLFGjsqMXNekDI2LNOMZqN92jTS7gA= X-Google-Smtp-Source: APXvYqy1zUuQ1pHiJL2lc1+ex0n1P9jsN8e4jTULq1JqFGgjoOtaXVadebhm2VVadcwnwi+S5fWjGw== X-Received: by 2002:a24:1052:: with SMTP id 79mr19255268ity.158.1554683329151; Sun, 07 Apr 2019 17:28:49 -0700 (PDT) Received: from pryzbyj (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id e11sm10605436iog.79.2019.04.07.17.28.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 Apr 2019 17:28:48 -0700 (PDT) Received: by pryzbyj (Postfix, from userid 1000) id 33986801065; Sun, 7 Apr 2019 19:28:47 -0500 (CDT) Date: Sun, 7 Apr 2019 19:28:47 -0500 From: Justin Pryzby To: pgsql-hackers@lists.postgresql.org Subject: Cleanup/remove/update references to OID column Message-ID: <20190408002847.GA904@telsasoft.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="fUYQa+Pmc3FrFX/N" Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Cleanup/remove/update references to OID column... ..in wake of 578b229718e8f. See also 93507e67c9ca54026019ebec3026de35d30370f9 1464755fc490a9911214817fe83077a3689250ab --- doc/src/sgml/ddl.sgml | 9 ++++----- doc/src/sgml/ref/insert.sgml | 12 +++++------- doc/src/sgml/ref/psql-ref.sgml | 3 +++ 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/doc/src/sgml/ddl.sgml b/doc/src/sgml/ddl.sgml index 9e761db..db044c5 100644 --- a/doc/src/sgml/ddl.sgml +++ b/doc/src/sgml/ddl.sgml @@ -3672,11 +3672,10 @@ VALUES ('Albany', NULL, NULL, 'NY'); Partitions cannot have columns that are not present in the parent. It is not possible to specify columns when creating partitions with - CREATE TABLE, nor is it possible to add columns to - partitions after-the-fact using ALTER TABLE. Tables may be - added as a partition with ALTER TABLE ... ATTACH PARTITION - only if their columns exactly match the parent, including any - oid column. + CREATE TABLE, to add columns to + partitions after-the-fact using ALTER TABLE, nor to + add a partition with ALTER TABLE ... ATTACH PARTITION + if its columns would not exactly match those of the parent. diff --git a/doc/src/sgml/ref/insert.sgml b/doc/src/sgml/ref/insert.sgml index 62e142f..3e1be4c 100644 --- a/doc/src/sgml/ref/insert.sgml +++ b/doc/src/sgml/ref/insert.sgml @@ -552,13 +552,11 @@ INSERT INTO table_name [ AS oid count The count is the - number of rows inserted or updated. If count is exactly one, and the - target table has OIDs, then oid is the OID - assigned to the inserted row. The single row must have been - inserted rather than updated. Otherwise oid is zero. + number of rows inserted or updated. + oid used to be the object ID of the inserted row + if rows was 1 and the target table had OIDs, but + OIDs system columns are not supported anymore; therefore + oid is always 0. diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml index 08f4bab..0e6e792 100644 --- a/doc/src/sgml/ref/psql-ref.sgml +++ b/doc/src/sgml/ref/psql-ref.sgml @@ -3794,6 +3794,9 @@ bar command. This variable is only guaranteed to be valid until after the result of the next SQL command has been displayed. + PostgreSQL servers since version 12 do not + support OID system columns in user tables, and LASTOID will always be 0 + following INSERT. -- 2.1.4 --fUYQa+Pmc3FrFX/N Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0001-Cleanup-remove-update-references-to-OID-column.patch" From b471a3e4d0713a157f53dd64bb26e2da1fc57c6f Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Tue, 2 Apr 2019 19:13:55 -0500 Subject: [PATCH v1] Cleanup/remove/update references to OID column... To: pgsql-hackers@lists.postgresql.org ..in wake of 578b229718e8f. See also 93507e67c9ca54026019ebec3026de35d30370f9 1464755fc490a9911214817fe83077a3689250ab --- doc/src/sgml/ddl.sgml | 9 ++++----- doc/src/sgml/ref/insert.sgml | 12 +++++------- doc/src/sgml/ref/psql-ref.sgml | 3 +++ 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/doc/src/sgml/ddl.sgml b/doc/src/sgml/ddl.sgml index 9e761db..db044c5 100644 --- a/doc/src/sgml/ddl.sgml +++ b/doc/src/sgml/ddl.sgml @@ -3672,11 +3672,10 @@ VALUES ('Albany', NULL, NULL, 'NY'); Partitions cannot have columns that are not present in the parent. It is not possible to specify columns when creating partitions with - CREATE TABLE, nor is it possible to add columns to - partitions after-the-fact using ALTER TABLE. Tables may be - added as a partition with ALTER TABLE ... ATTACH PARTITION - only if their columns exactly match the parent, including any - oid column. + CREATE TABLE, to add columns to + partitions after-the-fact using ALTER TABLE, nor to + add a partition with ALTER TABLE ... ATTACH PARTITION + if its columns would not exactly match those of the parent. diff --git a/doc/src/sgml/ref/insert.sgml b/doc/src/sgml/ref/insert.sgml index 62e142f..3e1be4c 100644 --- a/doc/src/sgml/ref/insert.sgml +++ b/doc/src/sgml/ref/insert.sgml @@ -552,13 +552,11 @@ INSERT INTO table_name [ AS oid count The count is the - number of rows inserted or updated. If count is exactly one, and the - target table has OIDs, then oid is the OID - assigned to the inserted row. The single row must have been - inserted rather than updated. Otherwise oid is zero. + number of rows inserted or updated. + oid used to be the object ID of the inserted row + if rows was 1 and the target table had OIDs, but + OIDs system columns are not supported anymore; therefore + oid is always 0. diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml index 08f4bab..0e6e792 100644 --- a/doc/src/sgml/ref/psql-ref.sgml +++ b/doc/src/sgml/ref/psql-ref.sgml @@ -3794,6 +3794,9 @@ bar command. This variable is only guaranteed to be valid until after the result of the next SQL command has been displayed. + PostgreSQL servers since version 12 do not + support OID system columns in user tables, and LASTOID will always be 0 + following INSERT. -- 2.1.4 --fUYQa+Pmc3FrFX/N--