agora inbox for [email protected]
help / color / mirror / Atom feed[PATCH] Remove stray comma from heap_page_item_attrs() docs
4+ messages / 4 participants
[nested] [flat]
* [PATCH] Remove stray comma from heap_page_item_attrs() docs
@ 2019-03-13 12:24 Christoph Berg <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Berg @ 2019-03-13 12:24 UTC (permalink / raw)
---
doc/src/sgml/pageinspect.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/pageinspect.sgml b/doc/src/sgml/pageinspect.sgml
index cdd2419479..8d81f8894e 100644
--- a/doc/src/sgml/pageinspect.sgml
+++ b/doc/src/sgml/pageinspect.sgml
@@ -181,7 +181,7 @@ test=# SELECT tuple_data_split('pg_class'::regclass, t_data, t_infomask, t_infom
<varlistentry>
<term>
- <function>heap_page_item_attrs(page bytea, rel_oid regclass, [, do_detoast bool]) returns setof record</function>
+ <function>heap_page_item_attrs(page bytea, rel_oid regclass [, do_detoast bool]) returns setof record</function>
<indexterm>
<primary>heap_page_item_attrs</primary>
</indexterm>
--
2.20.1
--dDRMvlgZJXvWKvBx--
^ permalink raw reply [nested|flat] 4+ messages in thread
* [PATCH] Remove stray comma from heap_page_item_attrs() docs
@ 2019-03-13 12:26 Christoph Berg <[email protected]>
2019-03-13 12:44 ` Re: [PATCH] Remove stray comma from heap_page_item_attrs() docs Magnus Hagander <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Berg @ 2019-03-13 12:26 UTC (permalink / raw)
To: pgsql-hackers
(This seems to be the only occurrence of this error, after about 2
minutes of git-grep-ing.)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [PATCH] Remove stray comma from heap_page_item_attrs() docs
2019-03-13 12:26 [PATCH] Remove stray comma from heap_page_item_attrs() docs Christoph Berg <[email protected]>
@ 2019-03-13 12:44 ` Magnus Hagander <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Magnus Hagander @ 2019-03-13 12:44 UTC (permalink / raw)
To: Christoph Berg <[email protected]>; pgsql-hackers
On Wed, Mar 13, 2019 at 1:26 PM Christoph Berg <[email protected]> wrote:
> (This seems to be the only occurrence of this error, after about 2
> minutes of git-grep-ing.)
>
Thanks, pushed!
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/;
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;
^ permalink raw reply [nested|flat] 4+ messages in thread
* [PATCH] Do not check the REPLICATION attribute when running REPACK.
@ 2026-04-20 07:20 Antonin Houska <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Antonin Houska @ 2026-04-20 07:20 UTC (permalink / raw)
Although REPACK (CONCURRENTLY) uses replication slots, there is no concern
that the slot will leak data of other users because the MAINTAIN privilege on
the table is required anyway. The REPLICATION attribute is also not needed to
prevent REPACK from stealing slots from logical replication, since commit
e76d8c749c introduces a limit on the maximum number of slots used by REPACK.
---
src/backend/commands/repack_worker.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/backend/commands/repack_worker.c b/src/backend/commands/repack_worker.c
index b17edd771e2..e4a4860805b 100644
--- a/src/backend/commands/repack_worker.c
+++ b/src/backend/commands/repack_worker.c
@@ -214,7 +214,6 @@ repack_setup_logical_decoding(Oid relid)
/*
* Make sure we can use logical decoding.
*/
- CheckSlotPermissions();
CheckLogicalDecodingRequirements(true);
/*
--
2.47.3
--=-=-=--
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2026-04-20 07:20 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-03-13 12:24 [PATCH] Remove stray comma from heap_page_item_attrs() docs Christoph Berg <[email protected]>
2019-03-13 12:26 [PATCH] Remove stray comma from heap_page_item_attrs() docs Christoph Berg <[email protected]>
2019-03-13 12:44 ` Magnus Hagander <[email protected]>
2026-04-20 07:20 [PATCH] Do not check the REPLICATION attribute when running REPACK. Antonin Houska <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox