agora inbox for [email protected]  

help / color / mirror / Atom feed

[PATCH v1] Add more debugging information when dropping twice pgstats entry
966+ messages / 2 participants
[nested] [flat]

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58 Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread

* [PATCH 2/9] rename setup_logical_decoding to repack_setup_logical_decoding
@ 2026-03-12 15:05 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 966+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:05 UTC (permalink / raw)

---
 src/backend/commands/cluster.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index da4919e497a..db3980b84f5 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -274,7 +274,7 @@ static List *get_tables_to_repack_partitioned(RepackCommand cmd,
 static bool repack_is_permitted_for_relation(RepackCommand cmd,
 											 Oid relid, Oid userid);
 
-static LogicalDecodingContext *setup_logical_decoding(Oid relid);
+static LogicalDecodingContext *repack_setup_logical_decoding(Oid relid);
 static bool decode_concurrent_changes(LogicalDecodingContext *ctx,
 									  DecodingWorkerShared *shared);
 static void apply_concurrent_changes(BufFile *file, ChangeDest *dest);
@@ -612,7 +612,7 @@ cluster_rel(RepackCommand cmd, Relation OldHeap, Oid indexOid,
 	{
 		/*
 		 * Make sure we have no XID assigned, otherwise call of
-		 * setup_logical_decoding() can cause a deadlock.
+		 * repack_setup_logical_decoding() can cause a deadlock.
 		 *
 		 * The existence of transaction block actually does not imply that XID
 		 * was already assigned, but it very likely is. We might want to check
@@ -2620,7 +2620,7 @@ change_useless_for_repack(XLogRecordBuffer *buf)
  * crash by restarting all the work from scratch).
  */
 static LogicalDecodingContext *
-setup_logical_decoding(Oid relid)
+repack_setup_logical_decoding(Oid relid)
 {
 	Relation	rel;
 	Oid			toastrelid;
@@ -4044,7 +4044,7 @@ repack_worker_internal(dsm_segment *seg)
 	/*
 	 * Prepare to capture the concurrent data changes ourselves.
 	 */
-	decoding_ctx = setup_logical_decoding(shared->relid);
+	decoding_ctx = repack_setup_logical_decoding(shared->relid);
 
 	/* Announce that we're ready. */
 	SpinLockAcquire(&shared->mutex);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0003-remove-excess-parens-around-ereport.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 966+ messages in thread