agora inbox for [email protected]help / color / mirror / Atom feed
[PATCH] Partitioned tables support tablesample 20+ messages / 2 participants [nested] [flat]
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH] Partitioned tables support tablesample @ 2017-02-22 07:27 amit <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: amit @ 2017-02-22 07:27 UTC (permalink / raw) --- src/backend/parser/parse_clause.c | 3 ++- src/test/regress/expected/tablesample.out | 18 ++++++++++++++++++ src/test/regress/sql/tablesample.sql | 8 ++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c index fecc1d6598..b5eae56006 100644 --- a/src/backend/parser/parse_clause.c +++ b/src/backend/parser/parse_clause.c @@ -907,7 +907,8 @@ transformFromClauseItem(ParseState *pstate, Node *n, rte = rt_fetch(rtr->rtindex, pstate->p_rtable); /* We only support this on plain relations and matviews */ if (rte->relkind != RELKIND_RELATION && - rte->relkind != RELKIND_MATVIEW) + rte->relkind != RELKIND_MATVIEW && + rte->relkind != RELKIND_PARTITIONED_TABLE) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("TABLESAMPLE clause can only be applied to tables and materialized views"), diff --git a/src/test/regress/expected/tablesample.out b/src/test/regress/expected/tablesample.out index 7e91b958ae..b18e420e9b 100644 --- a/src/test/regress/expected/tablesample.out +++ b/src/test/regress/expected/tablesample.out @@ -313,3 +313,21 @@ SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); ERROR: syntax error at or near "TABLESAMPLE" LINE 1: ...CT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPL... ^ +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); + QUERY PLAN +------------------------------------------- + Append + -> Sample Scan on parted_sample + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_1 + Sampling: bernoulli ('100'::real) + -> Sample Scan on parted_sample_2 + Sampling: bernoulli ('100'::real) +(7 rows) + +drop table parted_sample, parted_sample_1, parted_sample_2; diff --git a/src/test/regress/sql/tablesample.sql b/src/test/regress/sql/tablesample.sql index eec9793496..c39fe4b750 100644 --- a/src/test/regress/sql/tablesample.sql +++ b/src/test/regress/sql/tablesample.sql @@ -100,3 +100,11 @@ WITH query_select AS (SELECT * FROM test_tablesample) SELECT * FROM query_select TABLESAMPLE BERNOULLI (5.5) REPEATABLE (1); SELECT q.* FROM (SELECT * FROM test_tablesample) as q TABLESAMPLE BERNOULLI (5); + +-- check partitioned tables support tablesample +create table parted_sample (a int) partition by list (a); +create table parted_sample_1 partition of parted_sample for values in (1); +create table parted_sample_2 partition of parted_sample for values in (2); +explain (costs off) + select * from parted_sample tablesample bernoulli (100); +drop table parted_sample, parted_sample_1, parted_sample_2; -- 2.11.0 --------------095C853F38AC271E54EDC332 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------095C853F38AC271E54EDC332-- ^ permalink raw reply [nested|flat] 20+ messages in thread
* [PATCH v12 3/7] Row pattern recognition patch (planner). @ 2023-12-04 11:23 Tatsuo Ishii <[email protected]> 0 siblings, 0 replies; 20+ messages in thread From: Tatsuo Ishii @ 2023-12-04 11:23 UTC (permalink / raw) --- src/backend/optimizer/plan/createplan.c | 23 ++++++++++++++----- src/backend/optimizer/plan/planner.c | 3 +++ src/backend/optimizer/plan/setrefs.c | 27 ++++++++++++++++++++++- src/backend/optimizer/prep/prepjointree.c | 4 ++++ src/include/nodes/plannodes.h | 16 ++++++++++++++ 5 files changed, 67 insertions(+), 6 deletions(-) diff --git a/src/backend/optimizer/plan/createplan.c b/src/backend/optimizer/plan/createplan.c index 34ca6d4ac2..469fcd156b 100644 --- a/src/backend/optimizer/plan/createplan.c +++ b/src/backend/optimizer/plan/createplan.c @@ -286,9 +286,10 @@ static WindowAgg *make_windowagg(List *tlist, Index winref, int ordNumCols, AttrNumber *ordColIdx, Oid *ordOperators, Oid *ordCollations, int frameOptions, Node *startOffset, Node *endOffset, Oid startInRangeFunc, Oid endInRangeFunc, - Oid inRangeColl, bool inRangeAsc, bool inRangeNullsFirst, - List *runCondition, List *qual, bool topWindow, - Plan *lefttree); + Oid inRangeColl, bool inRangeAsc, bool inRangeNullsFirst, List *runCondition, + RPSkipTo rpSkipTo, List *patternVariable, List *patternRegexp, List *defineClause, + List *defineInitial, + List *qual, bool topWindow, Plan *lefttree); static Group *make_group(List *tlist, List *qual, int numGroupCols, AttrNumber *grpColIdx, Oid *grpOperators, Oid *grpCollations, Plan *lefttree); @@ -2698,6 +2699,11 @@ create_windowagg_plan(PlannerInfo *root, WindowAggPath *best_path) wc->inRangeAsc, wc->inRangeNullsFirst, wc->runCondition, + wc->rpSkipTo, + wc->patternVariable, + wc->patternRegexp, + wc->defineClause, + wc->defineInitial, best_path->qual, best_path->topwindow, subplan); @@ -6601,8 +6607,10 @@ make_windowagg(List *tlist, Index winref, int ordNumCols, AttrNumber *ordColIdx, Oid *ordOperators, Oid *ordCollations, int frameOptions, Node *startOffset, Node *endOffset, Oid startInRangeFunc, Oid endInRangeFunc, - Oid inRangeColl, bool inRangeAsc, bool inRangeNullsFirst, - List *runCondition, List *qual, bool topWindow, Plan *lefttree) + Oid inRangeColl, bool inRangeAsc, bool inRangeNullsFirst, List *runCondition, + RPSkipTo rpSkipTo, List *patternVariable, List *patternRegexp, List *defineClause, + List *defineInitial, + List *qual, bool topWindow, Plan *lefttree) { WindowAgg *node = makeNode(WindowAgg); Plan *plan = &node->plan; @@ -6628,6 +6636,11 @@ make_windowagg(List *tlist, Index winref, node->inRangeAsc = inRangeAsc; node->inRangeNullsFirst = inRangeNullsFirst; node->topWindow = topWindow; + node->rpSkipTo = rpSkipTo, + node->patternVariable = patternVariable; + node->patternRegexp = patternRegexp; + node->defineClause = defineClause; + node->defineInitial = defineInitial; plan->targetlist = tlist; plan->lefttree = lefttree; diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c index a8cea5efe1..7d4324e5e3 100644 --- a/src/backend/optimizer/plan/planner.c +++ b/src/backend/optimizer/plan/planner.c @@ -868,6 +868,9 @@ subquery_planner(PlannerGlobal *glob, Query *parse, wc->runCondition = (List *) preprocess_expression(root, (Node *) wc->runCondition, EXPRKIND_TARGET); + wc->defineClause = (List *) preprocess_expression(root, + (Node *) wc->defineClause, + EXPRKIND_TARGET); } parse->limitOffset = preprocess_expression(root, parse->limitOffset, diff --git a/src/backend/optimizer/plan/setrefs.c b/src/backend/optimizer/plan/setrefs.c index 4bb68ac90e..aa781494d3 100644 --- a/src/backend/optimizer/plan/setrefs.c +++ b/src/backend/optimizer/plan/setrefs.c @@ -211,7 +211,6 @@ static List *set_windowagg_runcondition_references(PlannerInfo *root, List *runcondition, Plan *plan); - /***************************************************************************** * * SUBPLAN REFERENCES @@ -2456,6 +2455,32 @@ set_upper_references(PlannerInfo *root, Plan *plan, int rtoffset) NRM_EQUAL, NUM_EXEC_QUAL(plan)); + /* + * Modifies an expression tree in each DEFINE clause so that all Var + * nodes's varno refers to OUTER_VAR. + */ + if (IsA(plan, WindowAgg)) + { + WindowAgg *wplan = (WindowAgg *) plan; + + if (wplan->defineClause != NIL) + { + foreach(l, wplan->defineClause) + { + TargetEntry *tle = (TargetEntry *) lfirst(l); + + tle->expr = (Expr *) + fix_upper_expr(root, + (Node *) tle->expr, + subplan_itlist, + OUTER_VAR, + rtoffset, + NRM_EQUAL, + NUM_EXEC_QUAL(plan)); + } + } + } + pfree(subplan_itlist); } diff --git a/src/backend/optimizer/prep/prepjointree.c b/src/backend/optimizer/prep/prepjointree.c index 73ff40721c..378644b2c4 100644 --- a/src/backend/optimizer/prep/prepjointree.c +++ b/src/backend/optimizer/prep/prepjointree.c @@ -2129,6 +2129,10 @@ perform_pullup_replace_vars(PlannerInfo *root, if (wc->runCondition != NIL) wc->runCondition = (List *) pullup_replace_vars((Node *) wc->runCondition, rvcontext); + + if (wc->defineClause != NIL) + wc->defineClause = (List *) + pullup_replace_vars((Node *) wc->defineClause, rvcontext); } if (parse->onConflict) { diff --git a/src/include/nodes/plannodes.h b/src/include/nodes/plannodes.h index d40af8e59f..827b86fea9 100644 --- a/src/include/nodes/plannodes.h +++ b/src/include/nodes/plannodes.h @@ -20,6 +20,7 @@ #include "lib/stringinfo.h" #include "nodes/bitmapset.h" #include "nodes/lockoptions.h" +#include "nodes/parsenodes.h" #include "nodes/primnodes.h" @@ -1096,6 +1097,21 @@ typedef struct WindowAgg /* nulls sort first for in_range tests? */ bool inRangeNullsFirst; + /* Row Pattern Recognition AFTER MACH SKIP clause */ + RPSkipTo rpSkipTo; /* Row Pattern Skip To type */ + + /* Row Pattern PATTERN variable name (list of String) */ + List *patternVariable; + + /* Row Pattern RPATTERN regular expression quantifier ('+' or ''. list of String) */ + List *patternRegexp; + + /* Row Pattern DEFINE clause (list of TargetEntry) */ + List *defineClause; + + /* Row Pattern DEFINE variable initial names (list of String) */ + List *defineInitial; + /* * false for all apart from the WindowAgg that's closest to the root of * the plan -- 2.25.1 ----Next_Part(Fri_Dec__8_10_16_13_2023_489)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="v12-0004-Row-pattern-recognition-patch-executor.patch" ^ permalink raw reply [nested|flat] 20+ messages in thread
end of thread, other threads:[~2023-12-04 11:23 UTC | newest] Thread overview: 20+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2017-02-22 07:27 [PATCH] Partitioned tables support tablesample amit <[email protected]> 2023-12-04 11:23 [PATCH v12 3/7] Row pattern recognition patch (planner). Tatsuo Ishii <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox