agora inbox for [email protected]help / color / mirror / Atom feed
[PATCH v25 07/11] pg_ls_logdir to ignore error if initial/top dir is missing.. 3+ messages / 2 participants [nested] [flat]
* [PATCH v25 07/11] pg_ls_logdir to ignore error if initial/top dir is missing.. @ 2020-03-06 23:23 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Justin Pryzby @ 2020-03-06 23:23 UTC (permalink / raw) ..since ./log is created dynamically and not by initdb --- src/backend/utils/adt/genfile.c | 2 +- src/test/regress/input/tablespace.source | 4 ++++ src/test/regress/output/tablespace.source | 7 +++++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/backend/utils/adt/genfile.c b/src/backend/utils/adt/genfile.c index d21a95aebe..07fce2a9bc 100644 --- a/src/backend/utils/adt/genfile.c +++ b/src/backend/utils/adt/genfile.c @@ -677,7 +677,7 @@ pg_ls_dir_files(FunctionCallInfo fcinfo, const char *dir, int flags) Datum pg_ls_logdir(PG_FUNCTION_ARGS) { - return pg_ls_dir_files(fcinfo, Log_directory, LS_DIR_COMMON); + return pg_ls_dir_files(fcinfo, Log_directory, LS_DIR_COMMON | LS_DIR_MISSING_OK); } /* Function to return the list of files in the WAL directory */ diff --git a/src/test/regress/input/tablespace.source b/src/test/regress/input/tablespace.source index 0b9cfe615e..2a1268e17c 100644 --- a/src/test/regress/input/tablespace.source +++ b/src/test/regress/input/tablespace.source @@ -16,6 +16,10 @@ CREATE TABLESPACE regress_tblspace LOCATION '@testtablespace@'; -- The query is written to ERROR if the tablespace doesn't exist, rather than silently failing to call pg_ls_tmpdir() SELECT c.* FROM (SELECT oid FROM pg_tablespace b WHERE b.spcname='regress_tblspace' UNION SELECT 0 ORDER BY 1 DESC LIMIT 1) AS b , pg_ls_tmpdir(oid) AS c WHERE c.name='Does not exist'; +-- This tests the missing_ok parameter. If that's not functioning, this would ERROR if the logdir doesn't exist yet. +-- The name='' condition is never true, so the function runs to completion but returns zero rows. +SELECT * FROM pg_ls_logdir() WHERE name='Does not exist'; + -- try setting and resetting some properties for the new tablespace ALTER TABLESPACE regress_tblspace SET (random_page_cost = 1.0, seq_page_cost = 1.1); ALTER TABLESPACE regress_tblspace SET (some_nonexistent_parameter = true); -- fail diff --git a/src/test/regress/output/tablespace.source b/src/test/regress/output/tablespace.source index 1c88e914e3..ba9a3fe29a 100644 --- a/src/test/regress/output/tablespace.source +++ b/src/test/regress/output/tablespace.source @@ -21,6 +21,13 @@ SELECT c.* FROM (SELECT oid FROM pg_tablespace b WHERE b.spcname='regress_tblspa ------+------+--------------+------- (0 rows) +-- This tests the missing_ok parameter. If that's not functioning, this would ERROR if the logdir doesn't exist yet. +-- The name='' condition is never true, so the function runs to completion but returns zero rows. +SELECT * FROM pg_ls_logdir() WHERE name='Does not exist'; + name | size | modification | isdir +------+------+--------------+------- +(0 rows) + -- try setting and resetting some properties for the new tablespace ALTER TABLESPACE regress_tblspace SET (random_page_cost = 1.0, seq_page_cost = 1.1); ALTER TABLESPACE regress_tblspace SET (some_nonexistent_parameter = true); -- fail -- 2.17.0 --SBikYMzjhZGK9d4p Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v25-0008-pg_ls_-dir-to-return-all-the-metadata-from-pg_st.patch" ^ permalink raw reply [nested|flat] 3+ messages in thread
* [PATCH v1 3/3] WIP: tests: Expand temp table tests to some pin related matters @ 2025-02-25 16:32 Andres Freund <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Andres Freund @ 2025-02-25 16:32 UTC (permalink / raw) Author: Reviewed-By: Discussion: https://postgr.es/m/ Backpatch: --- src/test/regress/expected/temp.out | 156 +++++++++++++++++++++++++++++ src/test/regress/parallel_schedule | 2 +- src/test/regress/sql/temp.sql | 107 ++++++++++++++++++++ 3 files changed, 264 insertions(+), 1 deletion(-) diff --git a/src/test/regress/expected/temp.out b/src/test/regress/expected/temp.out index 2a246a7e123..1ffbf77969f 100644 --- a/src/test/regress/expected/temp.out +++ b/src/test/regress/expected/temp.out @@ -410,3 +410,159 @@ SELECT current_schema() ~ 'pg_temp' AS is_temp_schema; PREPARE TRANSACTION 'twophase_search'; ERROR: cannot PREPARE a transaction that has operated on temporary objects +-- Tests to verify we recover correctly from exhausting buffer pins and +-- related matters. +-- use lower possible buffer limit to make the test cheaper +\c +SET temp_buffers = 100; +CREATE TEMPORARY TABLE test_temp(a int not null unique, b TEXT not null, cnt int not null); +INSERT INTO test_temp SELECT generate_series(1, 10000) as id, repeat('a', 120), 0; +-- should be at least 2x as large than temp_buffers +SELECT pg_relation_size('test_temp') / current_setting('block_size')::int8 > 200; + ?column? +---------- + t +(1 row) + +-- Don't want cursor names and plpgsql function lines in the error messages +\set VERBOSITY terse +/* helper function to create cursors for each page in [p_start, p_end] */ +CREATE FUNCTION test_temp_pin(p_start int, p_end int) +RETURNS void +LANGUAGE plpgsql +AS $f$ + DECLARE + cursorname text; + query text; + BEGIN + FOR i IN p_start..p_end LOOP + cursorname = 'c_'||i; + query = format($q$DECLARE %I CURSOR FOR SELECT ctid FROM test_temp WHERE ctid >= '( %s, 1)'::tid $q$, cursorname, i); + EXECUTE query; + EXECUTE 'FETCH NEXT FROM '||cursorname; + -- for test development + -- RAISE NOTICE '%: %', cursorname, query; + END LOOP; + END; +$f$; +-- Test overflow of temp table buffers is handled correctly +BEGIN; +-- should work, below max +SELECT test_temp_pin(0, 9); + test_temp_pin +--------------- + +(1 row) + +-- should fail, too many buffers pinned +SELECT test_temp_pin(10, 105); +ERROR: no empty local buffer available +ROLLBACK; +BEGIN; +-- have some working cursors to test after errors +SELECT test_temp_pin(0, 9); + test_temp_pin +--------------- + +(1 row) + +FETCH NEXT FROM c_3; + ctid +------- + (3,2) +(1 row) + +-- exhaust buffer pins in subtrans, check things work after +SAVEPOINT rescue_me; +SELECT test_temp_pin(10, 105); +ERROR: no empty local buffer available +ROLLBACK TO SAVEPOINT rescue_me; +-- pre-subtrans cursors continue to work +FETCH NEXT FROM c_3; + ctid +------- + (3,3) +(1 row) + +-- new cursors with pins can be created after subtrans rollback +SELECT test_temp_pin(10, 95); + test_temp_pin +--------------- + +(1 row) + +-- Check that read streams deal with lower number of pins available +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + count | max_a | min_a | max_cnt +-------+-------+-------+--------- + 10000 | 10000 | 1 | 0 +(1 row) + +ROLLBACK; +-- Check that temp tables with existing cursors can't be dropped. +BEGIN; +SELECT test_temp_pin(0, 1); + test_temp_pin +--------------- + +(1 row) + +DROP TABLE test_temp; +ERROR: cannot DROP TABLE "test_temp" because it is being used by active queries in this session +COMMIT; +-- Check that temp tables with existing cursors can't be dropped. +BEGIN; +SELECT test_temp_pin(0, 1); + test_temp_pin +--------------- + +(1 row) + +TRUNCATE test_temp; +ERROR: cannot TRUNCATE "test_temp" because it is being used by active queries in this session +COMMIT; +-- Check that temp tables that are dropped in transaction that's rolled back +-- preserve buffer contents +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + count | max_a | min_a | max_cnt +-------+-------+-------+--------- + 10000 | 10000 | 1 | 0 +(1 row) + +INSERT INTO test_temp(a, b, cnt) VALUES (-1, '', 0); +BEGIN; +INSERT INTO test_temp(a, b, cnt) VALUES (-2, '', 0); +DROP TABLE test_temp; +ROLLBACK; +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + count | max_a | min_a | max_cnt +-------+-------+-------+--------- + 10001 | 10000 | -1 | 0 +(1 row) + +-- Check that temp table drop is transactional and preserves dirty +-- buffer contents +UPDATE test_temp SET cnt = cnt + 1 WHERE a = -1; +BEGIN; +DROP TABLE test_temp; +ROLLBACK; +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + count | max_a | min_a | max_cnt +-------+-------+-------+--------- + 10001 | 10000 | -1 | 1 +(1 row) + +-- Check that temp table truncation is transactional and preserves dirty +-- buffer contents +UPDATE test_temp SET cnt = cnt + 1 WHERE a = -1; +BEGIN; +TRUNCATE test_temp; +ROLLBACK; +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + count | max_a | min_a | max_cnt +-------+-------+-------+--------- + 10001 | 10000 | -1 | 2 +(1 row) + +-- cleanup +DROP FUNCTION test_temp_pin(int, int); diff --git a/src/test/regress/parallel_schedule b/src/test/regress/parallel_schedule index 37b6d21e1f9..0a35f2f8f6a 100644 --- a/src/test/regress/parallel_schedule +++ b/src/test/regress/parallel_schedule @@ -108,7 +108,7 @@ test: json jsonb json_encoding jsonpath jsonpath_encoding jsonb_jsonpath sqljson # ---------- # Another group of parallel tests # with depends on create_misc -# NB: temp.sql does a reconnect which transiently uses 2 connections, +# NB: temp.sql does reconnects which transiently use 2 connections, # so keep this parallel group to at most 19 tests # ---------- test: plancache limit plpgsql copy2 temp domain rangefuncs prepare conversion truncate alter_table sequence polymorphism rowtypes returning largeobject with xml diff --git a/src/test/regress/sql/temp.sql b/src/test/regress/sql/temp.sql index 2a487a1ef7f..a37f7777dc0 100644 --- a/src/test/regress/sql/temp.sql +++ b/src/test/regress/sql/temp.sql @@ -311,3 +311,110 @@ SET search_path TO 'pg_temp'; BEGIN; SELECT current_schema() ~ 'pg_temp' AS is_temp_schema; PREPARE TRANSACTION 'twophase_search'; + + +-- Tests to verify we recover correctly from exhausting buffer pins and +-- related matters. + +-- use lower possible buffer limit to make the test cheaper +\c +SET temp_buffers = 100; + +CREATE TEMPORARY TABLE test_temp(a int not null unique, b TEXT not null, cnt int not null); +INSERT INTO test_temp SELECT generate_series(1, 10000) as id, repeat('a', 120), 0; +-- should be at least 2x as large than temp_buffers +SELECT pg_relation_size('test_temp') / current_setting('block_size')::int8 > 200; + +-- Don't want cursor names and plpgsql function lines in the error messages +\set VERBOSITY terse + +/* helper function to create cursors for each page in [p_start, p_end] */ +CREATE FUNCTION test_temp_pin(p_start int, p_end int) +RETURNS void +LANGUAGE plpgsql +AS $f$ + DECLARE + cursorname text; + query text; + BEGIN + FOR i IN p_start..p_end LOOP + cursorname = 'c_'||i; + query = format($q$DECLARE %I CURSOR FOR SELECT ctid FROM test_temp WHERE ctid >= '( %s, 1)'::tid $q$, cursorname, i); + EXECUTE query; + EXECUTE 'FETCH NEXT FROM '||cursorname; + -- for test development + -- RAISE NOTICE '%: %', cursorname, query; + END LOOP; + END; +$f$; + + +-- Test overflow of temp table buffers is handled correctly +BEGIN; +-- should work, below max +SELECT test_temp_pin(0, 9); +-- should fail, too many buffers pinned +SELECT test_temp_pin(10, 105); +ROLLBACK; + +BEGIN; +-- have some working cursors to test after errors +SELECT test_temp_pin(0, 9); +FETCH NEXT FROM c_3; +-- exhaust buffer pins in subtrans, check things work after +SAVEPOINT rescue_me; +SELECT test_temp_pin(10, 105); +ROLLBACK TO SAVEPOINT rescue_me; +-- pre-subtrans cursors continue to work +FETCH NEXT FROM c_3; + +-- new cursors with pins can be created after subtrans rollback +SELECT test_temp_pin(10, 95); + +-- Check that read streams deal with lower number of pins available +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + +ROLLBACK; + + +-- Check that temp tables with existing cursors can't be dropped. +BEGIN; +SELECT test_temp_pin(0, 1); +DROP TABLE test_temp; +COMMIT; + +-- Check that temp tables with existing cursors can't be dropped. +BEGIN; +SELECT test_temp_pin(0, 1); +TRUNCATE test_temp; +COMMIT; + +-- Check that temp tables that are dropped in transaction that's rolled back +-- preserve buffer contents +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; +INSERT INTO test_temp(a, b, cnt) VALUES (-1, '', 0); +BEGIN; +INSERT INTO test_temp(a, b, cnt) VALUES (-2, '', 0); +DROP TABLE test_temp; +ROLLBACK; +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + +-- Check that temp table drop is transactional and preserves dirty +-- buffer contents +UPDATE test_temp SET cnt = cnt + 1 WHERE a = -1; +BEGIN; +DROP TABLE test_temp; +ROLLBACK; +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + +-- Check that temp table truncation is transactional and preserves dirty +-- buffer contents +UPDATE test_temp SET cnt = cnt + 1 WHERE a = -1; +BEGIN; +TRUNCATE test_temp; +ROLLBACK; +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + + +-- cleanup +DROP FUNCTION test_temp_pin(int, int); -- 2.46.0.519.g2e7b89e038 --ce5rd5vqldbhirzk-- ^ permalink raw reply [nested|flat] 3+ messages in thread
* [PATCH v2.5 15/30] WIP: tests: Expand temp table tests to some pin related matters @ 2025-03-04 16:07 Andres Freund <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Andres Freund @ 2025-03-04 16:07 UTC (permalink / raw) Author: Reviewed-By: Discussion: https://postgr.es/m/ Backpatch: --- src/test/regress/expected/temp.out | 156 +++++++++++++++++++++++++++++ src/test/regress/parallel_schedule | 2 +- src/test/regress/sql/temp.sql | 107 ++++++++++++++++++++ 3 files changed, 264 insertions(+), 1 deletion(-) diff --git a/src/test/regress/expected/temp.out b/src/test/regress/expected/temp.out index 2a246a7e123..91fe519b1cc 100644 --- a/src/test/regress/expected/temp.out +++ b/src/test/regress/expected/temp.out @@ -410,3 +410,159 @@ SELECT current_schema() ~ 'pg_temp' AS is_temp_schema; PREPARE TRANSACTION 'twophase_search'; ERROR: cannot PREPARE a transaction that has operated on temporary objects +-- Tests to verify we recover correctly from exhausting buffer pins and +-- related matters. +-- use lower possible buffer limit to make the test cheaper +\c +SET temp_buffers = 100; +CREATE TEMPORARY TABLE test_temp(a int not null unique, b TEXT not null, cnt int not null); +INSERT INTO test_temp SELECT generate_series(1, 10000) as id, repeat('a', 200), 0; +-- should be at least 2x as large than temp_buffers +SELECT pg_relation_size('test_temp') / current_setting('block_size')::int8 > 200; + ?column? +---------- + t +(1 row) + +-- Don't want cursor names and plpgsql function lines in the error messages +\set VERBOSITY terse +/* helper function to create cursors for each page in [p_start, p_end] */ +CREATE FUNCTION test_temp_pin(p_start int, p_end int) +RETURNS void +LANGUAGE plpgsql +AS $f$ + DECLARE + cursorname text; + query text; + BEGIN + FOR i IN p_start..p_end LOOP + cursorname = 'c_'||i; + query = format($q$DECLARE %I CURSOR FOR SELECT ctid FROM test_temp WHERE ctid >= '( %s, 1)'::tid $q$, cursorname, i); + EXECUTE query; + EXECUTE 'FETCH NEXT FROM '||cursorname; + -- for test development + -- RAISE NOTICE '%: %', cursorname, query; + END LOOP; + END; +$f$; +-- Test overflow of temp table buffers is handled correctly +BEGIN; +-- should work, below max +SELECT test_temp_pin(0, 9); + test_temp_pin +--------------- + +(1 row) + +-- should fail, too many buffers pinned +SELECT test_temp_pin(10, 105); +ERROR: no empty local buffer available +ROLLBACK; +BEGIN; +-- have some working cursors to test after errors +SELECT test_temp_pin(0, 9); + test_temp_pin +--------------- + +(1 row) + +FETCH NEXT FROM c_3; + ctid +------- + (3,2) +(1 row) + +-- exhaust buffer pins in subtrans, check things work after +SAVEPOINT rescue_me; +SELECT test_temp_pin(10, 105); +ERROR: no empty local buffer available +ROLLBACK TO SAVEPOINT rescue_me; +-- pre-subtrans cursors continue to work +FETCH NEXT FROM c_3; + ctid +------- + (3,3) +(1 row) + +-- new cursors with pins can be created after subtrans rollback +SELECT test_temp_pin(10, 95); + test_temp_pin +--------------- + +(1 row) + +-- Check that read streams deal with lower number of pins available +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + count | max_a | min_a | max_cnt +-------+-------+-------+--------- + 10000 | 10000 | 1 | 0 +(1 row) + +ROLLBACK; +-- Check that temp tables with existing cursors can't be dropped. +BEGIN; +SELECT test_temp_pin(0, 1); + test_temp_pin +--------------- + +(1 row) + +DROP TABLE test_temp; +ERROR: cannot DROP TABLE "test_temp" because it is being used by active queries in this session +COMMIT; +-- Check that temp tables with existing cursors can't be dropped. +BEGIN; +SELECT test_temp_pin(0, 1); + test_temp_pin +--------------- + +(1 row) + +TRUNCATE test_temp; +ERROR: cannot TRUNCATE "test_temp" because it is being used by active queries in this session +COMMIT; +-- Check that temp tables that are dropped in transaction that's rolled back +-- preserve buffer contents +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + count | max_a | min_a | max_cnt +-------+-------+-------+--------- + 10000 | 10000 | 1 | 0 +(1 row) + +INSERT INTO test_temp(a, b, cnt) VALUES (-1, '', 0); +BEGIN; +INSERT INTO test_temp(a, b, cnt) VALUES (-2, '', 0); +DROP TABLE test_temp; +ROLLBACK; +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + count | max_a | min_a | max_cnt +-------+-------+-------+--------- + 10001 | 10000 | -1 | 0 +(1 row) + +-- Check that temp table drop is transactional and preserves dirty +-- buffer contents +UPDATE test_temp SET cnt = cnt + 1 WHERE a = -1; +BEGIN; +DROP TABLE test_temp; +ROLLBACK; +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + count | max_a | min_a | max_cnt +-------+-------+-------+--------- + 10001 | 10000 | -1 | 1 +(1 row) + +-- Check that temp table truncation is transactional and preserves dirty +-- buffer contents +UPDATE test_temp SET cnt = cnt + 1 WHERE a = -1; +BEGIN; +TRUNCATE test_temp; +ROLLBACK; +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + count | max_a | min_a | max_cnt +-------+-------+-------+--------- + 10001 | 10000 | -1 | 2 +(1 row) + +-- cleanup +DROP FUNCTION test_temp_pin(int, int); diff --git a/src/test/regress/parallel_schedule b/src/test/regress/parallel_schedule index 37b6d21e1f9..0a35f2f8f6a 100644 --- a/src/test/regress/parallel_schedule +++ b/src/test/regress/parallel_schedule @@ -108,7 +108,7 @@ test: json jsonb json_encoding jsonpath jsonpath_encoding jsonb_jsonpath sqljson # ---------- # Another group of parallel tests # with depends on create_misc -# NB: temp.sql does a reconnect which transiently uses 2 connections, +# NB: temp.sql does reconnects which transiently use 2 connections, # so keep this parallel group to at most 19 tests # ---------- test: plancache limit plpgsql copy2 temp domain rangefuncs prepare conversion truncate alter_table sequence polymorphism rowtypes returning largeobject with xml diff --git a/src/test/regress/sql/temp.sql b/src/test/regress/sql/temp.sql index 2a487a1ef7f..12091f968de 100644 --- a/src/test/regress/sql/temp.sql +++ b/src/test/regress/sql/temp.sql @@ -311,3 +311,110 @@ SET search_path TO 'pg_temp'; BEGIN; SELECT current_schema() ~ 'pg_temp' AS is_temp_schema; PREPARE TRANSACTION 'twophase_search'; + + +-- Tests to verify we recover correctly from exhausting buffer pins and +-- related matters. + +-- use lower possible buffer limit to make the test cheaper +\c +SET temp_buffers = 100; + +CREATE TEMPORARY TABLE test_temp(a int not null unique, b TEXT not null, cnt int not null); +INSERT INTO test_temp SELECT generate_series(1, 10000) as id, repeat('a', 200), 0; +-- should be at least 2x as large than temp_buffers +SELECT pg_relation_size('test_temp') / current_setting('block_size')::int8 > 200; + +-- Don't want cursor names and plpgsql function lines in the error messages +\set VERBOSITY terse + +/* helper function to create cursors for each page in [p_start, p_end] */ +CREATE FUNCTION test_temp_pin(p_start int, p_end int) +RETURNS void +LANGUAGE plpgsql +AS $f$ + DECLARE + cursorname text; + query text; + BEGIN + FOR i IN p_start..p_end LOOP + cursorname = 'c_'||i; + query = format($q$DECLARE %I CURSOR FOR SELECT ctid FROM test_temp WHERE ctid >= '( %s, 1)'::tid $q$, cursorname, i); + EXECUTE query; + EXECUTE 'FETCH NEXT FROM '||cursorname; + -- for test development + -- RAISE NOTICE '%: %', cursorname, query; + END LOOP; + END; +$f$; + + +-- Test overflow of temp table buffers is handled correctly +BEGIN; +-- should work, below max +SELECT test_temp_pin(0, 9); +-- should fail, too many buffers pinned +SELECT test_temp_pin(10, 105); +ROLLBACK; + +BEGIN; +-- have some working cursors to test after errors +SELECT test_temp_pin(0, 9); +FETCH NEXT FROM c_3; +-- exhaust buffer pins in subtrans, check things work after +SAVEPOINT rescue_me; +SELECT test_temp_pin(10, 105); +ROLLBACK TO SAVEPOINT rescue_me; +-- pre-subtrans cursors continue to work +FETCH NEXT FROM c_3; + +-- new cursors with pins can be created after subtrans rollback +SELECT test_temp_pin(10, 95); + +-- Check that read streams deal with lower number of pins available +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + +ROLLBACK; + + +-- Check that temp tables with existing cursors can't be dropped. +BEGIN; +SELECT test_temp_pin(0, 1); +DROP TABLE test_temp; +COMMIT; + +-- Check that temp tables with existing cursors can't be dropped. +BEGIN; +SELECT test_temp_pin(0, 1); +TRUNCATE test_temp; +COMMIT; + +-- Check that temp tables that are dropped in transaction that's rolled back +-- preserve buffer contents +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; +INSERT INTO test_temp(a, b, cnt) VALUES (-1, '', 0); +BEGIN; +INSERT INTO test_temp(a, b, cnt) VALUES (-2, '', 0); +DROP TABLE test_temp; +ROLLBACK; +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + +-- Check that temp table drop is transactional and preserves dirty +-- buffer contents +UPDATE test_temp SET cnt = cnt + 1 WHERE a = -1; +BEGIN; +DROP TABLE test_temp; +ROLLBACK; +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + +-- Check that temp table truncation is transactional and preserves dirty +-- buffer contents +UPDATE test_temp SET cnt = cnt + 1 WHERE a = -1; +BEGIN; +TRUNCATE test_temp; +ROLLBACK; +SELECT count(*), max(a) max_a, min(a) min_a, max(cnt) max_cnt FROM test_temp; + + +-- cleanup +DROP FUNCTION test_temp_pin(int, int); -- 2.48.1.76.g4e746b1a31.dirty --abvteypvk35ocehs Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v2.5-0016-WIP-localbuf-Track-pincount-in-BufferDesc-as-we.patch" ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-03-04 16:07 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-03-06 23:23 [PATCH v25 07/11] pg_ls_logdir to ignore error if initial/top dir is missing.. Justin Pryzby <[email protected]> 2025-02-25 16:32 [PATCH v1 3/3] WIP: tests: Expand temp table tests to some pin related matters Andres Freund <[email protected]> 2025-03-04 16:07 [PATCH v2.5 15/30] WIP: tests: Expand temp table tests to some pin related matters Andres Freund <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox