public inbox for [email protected]  

help / color / mirror / Atom feed

[PATCH 4/4] Add a note about DROP NOT NULL and partitions
53+ messages / 2 participants
[nested] [flat]

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 077c00373d..b6be3a0dcb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,14 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  Even if there is no <literal>NOT NULL</> constraint on the
+      parent, such a constraint can still be added to individual partitions,
+      if desired; that is, the children can disallow nulls even if the parent
+      allows them, but not the other way around. 
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------19C79A137EF2D0DB3BE72F79
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 077c00373d..b6be3a0dcb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,14 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  Even if there is no <literal>NOT NULL</> constraint on the
+      parent, such a constraint can still be added to individual partitions,
+      if desired; that is, the children can disallow nulls even if the parent
+      allows them, but not the other way around. 
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------19C79A137EF2D0DB3BE72F79
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 077c00373d..b6be3a0dcb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,14 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  Even if there is no <literal>NOT NULL</> constraint on the
+      parent, such a constraint can still be added to individual partitions,
+      if desired; that is, the children can disallow nulls even if the parent
+      allows them, but not the other way around. 
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------19C79A137EF2D0DB3BE72F79
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 077c00373d..b6be3a0dcb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,14 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  Even if there is no <literal>NOT NULL</> constraint on the
+      parent, such a constraint can still be added to individual partitions,
+      if desired; that is, the children can disallow nulls even if the parent
+      allows them, but not the other way around. 
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------19C79A137EF2D0DB3BE72F79
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 077c00373d..b6be3a0dcb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,14 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  Even if there is no <literal>NOT NULL</> constraint on the
+      parent, such a constraint can still be added to individual partitions,
+      if desired; that is, the children can disallow nulls even if the parent
+      allows them, but not the other way around. 
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------19C79A137EF2D0DB3BE72F79
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 077c00373d..b6be3a0dcb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,14 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  Even if there is no <literal>NOT NULL</> constraint on the
+      parent, such a constraint can still be added to individual partitions,
+      if desired; that is, the children can disallow nulls even if the parent
+      allows them, but not the other way around. 
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------19C79A137EF2D0DB3BE72F79
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 077c00373d..b6be3a0dcb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,14 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  Even if there is no <literal>NOT NULL</> constraint on the
+      parent, such a constraint can still be added to individual partitions,
+      if desired; that is, the children can disallow nulls even if the parent
+      allows them, but not the other way around. 
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------19C79A137EF2D0DB3BE72F79
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 077c00373d..b6be3a0dcb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,14 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  Even if there is no <literal>NOT NULL</> constraint on the
+      parent, such a constraint can still be added to individual partitions,
+      if desired; that is, the children can disallow nulls even if the parent
+      allows them, but not the other way around. 
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------19C79A137EF2D0DB3BE72F79
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 077c00373d..b6be3a0dcb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,14 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  Even if there is no <literal>NOT NULL</> constraint on the
+      parent, such a constraint can still be added to individual partitions,
+      if desired; that is, the children can disallow nulls even if the parent
+      allows them, but not the other way around. 
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------19C79A137EF2D0DB3BE72F79
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 077c00373d..b6be3a0dcb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,14 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  Even if there is no <literal>NOT NULL</> constraint on the
+      parent, such a constraint can still be added to individual partitions,
+      if desired; that is, the children can disallow nulls even if the parent
+      allows them, but not the other way around. 
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------19C79A137EF2D0DB3BE72F79
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 077c00373d..b6be3a0dcb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,14 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  Even if there is no <literal>NOT NULL</> constraint on the
+      parent, such a constraint can still be added to individual partitions,
+      if desired; that is, the children can disallow nulls even if the parent
+      allows them, but not the other way around. 
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------19C79A137EF2D0DB3BE72F79
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 077c00373d..b6be3a0dcb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,14 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  Even if there is no <literal>NOT NULL</> constraint on the
+      parent, such a constraint can still be added to individual partitions,
+      if desired; that is, the children can disallow nulls even if the parent
+      allows them, but not the other way around. 
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------19C79A137EF2D0DB3BE72F79
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 077c00373d..b6be3a0dcb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,14 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  Even if there is no <literal>NOT NULL</> constraint on the
+      parent, such a constraint can still be added to individual partitions,
+      if desired; that is, the children can disallow nulls even if the parent
+      allows them, but not the other way around. 
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------19C79A137EF2D0DB3BE72F79
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 077c00373d..b6be3a0dcb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,14 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  Even if there is no <literal>NOT NULL</> constraint on the
+      parent, such a constraint can still be added to individual partitions,
+      if desired; that is, the children can disallow nulls even if the parent
+      allows them, but not the other way around. 
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------19C79A137EF2D0DB3BE72F79
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 077c00373d..b6be3a0dcb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,14 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  Even if there is no <literal>NOT NULL</> constraint on the
+      parent, such a constraint can still be added to individual partitions,
+      if desired; that is, the children can disallow nulls even if the parent
+      allows them, but not the other way around. 
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------19C79A137EF2D0DB3BE72F79
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 077c00373d..b6be3a0dcb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,14 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  Even if there is no <literal>NOT NULL</> constraint on the
+      parent, such a constraint can still be added to individual partitions,
+      if desired; that is, the children can disallow nulls even if the parent
+      allows them, but not the other way around. 
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------19C79A137EF2D0DB3BE72F79
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 4/4] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------89FC639615756AE2477DE3D6
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--------------89FC639615756AE2477DE3D6--






^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH 2/3] Add a note about DROP NOT NULL and partitions
@ 2017-02-10 06:03 amit <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: amit @ 2017-02-10 06:03 UTC (permalink / raw)

On the ALTER TABLE refpage, it seems better to mention how to drop
drop the not null constraint of a partition's column.  Per suggestion
from Corey Huinker.
---
 doc/src/sgml/ref/alter_table.sgml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index da431f8369..be857882bb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -172,9 +172,13 @@ ALTER TABLE [ IF EXISTS ] <replaceable class="PARAMETER">name</replaceable>
      </para>
 
      <para>
-      If this table is a partition, one cannot perform <literal>DROP NOT NULL</>
+      If this table is a partition, one cannot perform <literal>DROP NOT NULL</literal>
       on a column if it is marked <literal>NOT NULL</literal> in the parent
-      table.
+      table.  To drop the <literal>NOT NULL</literal> constraint from all the
+      partitions, perform <literal>DROP NOT NULL</literal> on the parent
+      table.  One might however want to set it for only some partitions,
+      which is possible by doing <literal>SET NOT NULL</literal> on individual
+      partitions.
      </para>
     </listitem>
    </varlistentry>
-- 
2.11.0


--------------434C61868FD2E7C005F82712
Content-Type: text/x-diff;
 name="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0003-Listify-a-note-on-the-CREATE-TABLE-page.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

* [PATCH v46 3/7] Use BulkInsertState when copying data to the new heap.
@ 2026-03-11 14:20 Antonin Houska <[email protected]>
  0 siblings, 0 replies; 53+ messages in thread

From: Antonin Houska @ 2026-03-11 14:20 UTC (permalink / raw)

It should make the copying more efficient. Besides that, buffer access
strategy is involved this way.

This diff reverts the changes done in previous parts of the series to
reform_and_rewrite_tuple() and introduces a separate function
heap_insert_for_repack().
---
 src/backend/access/heap/heapam_handler.c | 110 +++++++++++++++--------
 1 file changed, 72 insertions(+), 38 deletions(-)

diff --git a/src/backend/access/heap/heapam_handler.c b/src/backend/access/heap/heapam_handler.c
index 0ba7c0df1fc..fa95deb46ea 100644
--- a/src/backend/access/heap/heapam_handler.c
+++ b/src/backend/access/heap/heapam_handler.c
@@ -51,6 +51,11 @@
 static void reform_and_rewrite_tuple(HeapTuple tuple,
 									 Relation OldHeap, Relation NewHeap,
 									 Datum *values, bool *isnull, RewriteState rwstate);
+static void heap_insert_for_repack(HeapTuple tuple, Relation OldHeap,
+								   Relation NewHeap, Datum *values, bool *isnull,
+								   BulkInsertState bistate);
+static HeapTuple reform_tuple(HeapTuple tuple, Relation OldHeap,
+							  Relation NewHeap, Datum *values, bool *isnull);
 
 static bool SampleHeapTupleVisible(TableScanDesc scan, Buffer buffer,
 								   HeapTuple tuple,
@@ -703,6 +708,7 @@ heapam_relation_copy_for_cluster(Relation OldHeap, Relation NewHeap,
 								 double *tups_recently_dead)
 {
 	RewriteState rwstate = NULL;
+	BulkInsertState	bistate = NULL;
 	IndexScanDesc indexScan;
 	TableScanDesc tableScan;
 	HeapScanDesc heapScan;
@@ -738,6 +744,8 @@ heapam_relation_copy_for_cluster(Relation OldHeap, Relation NewHeap,
 	if (!concurrent)
 		rwstate = begin_heap_rewrite(OldHeap, NewHeap, OldestXmin,
 									 *xid_cutoff, *multi_cutoff);
+	else
+		bistate = GetBulkInsertState();
 
 
 	/* Set up sorting if wanted */
@@ -967,8 +975,12 @@ heapam_relation_copy_for_cluster(Relation OldHeap, Relation NewHeap,
 			};
 			int64		ct_val[2];
 
-			reform_and_rewrite_tuple(tuple, OldHeap, NewHeap,
-									 values, isnull, rwstate);
+			if (!concurrent)
+				reform_and_rewrite_tuple(tuple, OldHeap, NewHeap,
+										 values, isnull, rwstate);
+			else
+				heap_insert_for_repack(tuple, OldHeap, NewHeap,
+									   values, isnull, bistate);
 
 			/*
 			 * In indexscan mode and also VACUUM FULL, report increase in
@@ -1016,10 +1028,15 @@ heapam_relation_copy_for_cluster(Relation OldHeap, Relation NewHeap,
 				break;
 
 			n_tuples += 1;
-			reform_and_rewrite_tuple(tuple,
-									 OldHeap, NewHeap,
-									 values, isnull,
-									 rwstate);
+			if (!concurrent)
+				reform_and_rewrite_tuple(tuple,
+										 OldHeap, NewHeap,
+										 values, isnull,
+										 rwstate);
+			else
+				heap_insert_for_repack(tuple, OldHeap, NewHeap,
+									   values, isnull, bistate);
+
 			/* Report n_tuples */
 			pgstat_progress_update_param(PROGRESS_REPACK_HEAP_TUPLES_INSERTED,
 										 n_tuples);
@@ -1031,6 +1048,8 @@ heapam_relation_copy_for_cluster(Relation OldHeap, Relation NewHeap,
 	/* Write out any remaining tuples, and fsync if needed */
 	if (rwstate)
 		end_heap_rewrite(rwstate);
+	if (bistate)
+		FreeBulkInsertState(bistate);
 
 	/* Clean up */
 	pfree(values);
@@ -2423,56 +2442,71 @@ heapam_scan_sample_next_tuple(TableScanDesc scan, SampleScanState *scanstate,
  * SET WITHOUT OIDS.
  *
  * So, we must reconstruct the tuple from component Datums.
- *
- * If rwstate=NULL, use simple_heap_insert() instead of rewriting - in that
- * case we still need to deform/form the tuple. TODO Shouldn't we rename the
- * function, as might not do any rewrite?
  */
 static void
 reform_and_rewrite_tuple(HeapTuple tuple,
 						 Relation OldHeap, Relation NewHeap,
 						 Datum *values, bool *isnull, RewriteState rwstate)
+{
+	HeapTuple       copiedTuple;
+
+	copiedTuple = reform_tuple(tuple, OldHeap, NewHeap, values, isnull);
+
+	/* The heap rewrite module does the rest */
+	rewrite_heap_tuple(rwstate, tuple, copiedTuple);
+
+	heap_freetuple(copiedTuple);
+}
+
+/*
+ * Insert tuple when processing REPACK CONCURRENTLY.
+ *
+ * rewriteheap.c is not used in the CONCURRENTLY case because it'd be
+ * difficult to do the same in the catch-up phase (as the logical
+ * decoding does not provide us with sufficient visibility
+ * information). Thus we must use heap_insert() both during the
+ * catch-up and here.
+ *
+ * We pass the NO_LOGICAL flag to heap_insert() in order to skip logical
+ * decoding: as soon as REPACK CONCURRENTLY swaps the relation files, it drops
+ * this relation, so no logical replication subscription should need the data.
+ *
+ * BulkInsertState is used because many tuples are inserted in the typical
+ * case.
+ */
+static void
+heap_insert_for_repack(HeapTuple tuple, Relation OldHeap, Relation NewHeap,
+					   Datum *values, bool *isnull, BulkInsertState bistate)
+{
+	tuple = reform_tuple(tuple, OldHeap, NewHeap, values, isnull);
+
+	heap_insert(NewHeap, tuple, GetCurrentCommandId(true),
+				HEAP_INSERT_NO_LOGICAL, bistate);
+
+	heap_freetuple(tuple);
+}
+
+/*
+ * Deform tuple, set values of dropped columns to NULL, form a new tuple and
+ * return it.
+ */
+static HeapTuple
+reform_tuple(HeapTuple tuple, Relation OldHeap, Relation NewHeap,
+			 Datum *values, bool *isnull)
 {
 	TupleDesc	oldTupDesc = RelationGetDescr(OldHeap);
 	TupleDesc	newTupDesc = RelationGetDescr(NewHeap);
-	HeapTuple	copiedTuple;
 	int			i;
 
 	heap_deform_tuple(tuple, oldTupDesc, values, isnull);
 
-	/* Be sure to null out any dropped columns */
 	for (i = 0; i < newTupDesc->natts; i++)
 	{
 		if (TupleDescCompactAttr(newTupDesc, i)->attisdropped)
 			isnull[i] = true;
 	}
 
-	copiedTuple = heap_form_tuple(newTupDesc, values, isnull);
-
-	if (rwstate)
-		/* The heap rewrite module does the rest */
-		rewrite_heap_tuple(rwstate, tuple, copiedTuple);
-	else
-	{
-		/*
-		 * Insert tuple when processing REPACK CONCURRENTLY.
-		 *
-		 * rewriteheap.c is not used in the CONCURRENTLY case because it'd be
-		 * difficult to do the same in the catch-up phase (as the logical
-		 * decoding does not provide us with sufficient visibility
-		 * information). Thus we must use heap_insert() both during the
-		 * catch-up and here.
-		 *
-		 * The following is like simple_heap_insert() except that we pass the
-		 * flag to skip logical decoding: as soon as REPACK CONCURRENTLY swaps
-		 * the relation files, it drops this relation, so no logical
-		 * replication subscription should need the data.
-		 */
-		heap_insert(NewHeap, copiedTuple, GetCurrentCommandId(true),
-					HEAP_INSERT_NO_LOGICAL, NULL);
-	}
-
-	heap_freetuple(copiedTuple);
+	return heap_form_tuple(newTupDesc, values, isnull);
 }
 
 /*
-- 
2.47.3


--mdsv5bdgfjjj6d77
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="v46-0004-rename-cluster.c-h-to-repack.c-h.patch"



^ permalink  raw  reply  [nested|flat] 53+ messages in thread

end of thread, other threads:[~2026-03-11 14:20 UTC | newest]

Thread overview: 53+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 4/4] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2017-02-10 06:03 [PATCH 2/3] Add a note about DROP NOT NULL and partitions amit <[email protected]>
2026-03-11 14:20 [PATCH v46 3/7] Use BulkInsertState when copying data to the new heap. Antonin Houska <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox