agora inbox for [email protected]  
help / color / mirror / Atom feed
[PATCH v36 1/7] Use standard crash handler in archiver.
9+ messages / 5 participants
[nested] [flat]

* [PATCH v36 1/7] Use standard crash handler in archiver.
@ 2020-03-16 08:15  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 9+ messages in thread

From: Kyotaro Horiguchi @ 2020-03-16 08:15 UTC (permalink / raw)

The commit 8e19a82640 changed SIGQUIT handler of almost all processes
not to run atexit callbacks for safety. Archiver process should behave
the same way for the same reason. Exit status changes 1 to 2 but that
doesn't make any behavioral change.
---
 src/backend/postmaster/pgarch.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/src/backend/postmaster/pgarch.c b/src/backend/postmaster/pgarch.c
index 01ffd6513c..37be0e2bbb 100644
--- a/src/backend/postmaster/pgarch.c
+++ b/src/backend/postmaster/pgarch.c
@@ -96,7 +96,6 @@ static pid_t pgarch_forkexec(void);
 #endif
 
 NON_EXEC_STATIC void PgArchiverMain(int argc, char *argv[]) pg_attribute_noreturn();
-static void pgarch_exit(SIGNAL_ARGS);
 static void pgarch_waken(SIGNAL_ARGS);
 static void pgarch_waken_stop(SIGNAL_ARGS);
 static void pgarch_MainLoop(void);
@@ -229,7 +228,7 @@ PgArchiverMain(int argc, char *argv[])
 	pqsignal(SIGHUP, SignalHandlerForConfigReload);
 	pqsignal(SIGINT, SIG_IGN);
 	pqsignal(SIGTERM, SignalHandlerForShutdownRequest);
-	pqsignal(SIGQUIT, pgarch_exit);
+	pqsignal(SIGQUIT, SignalHandlerForCrashExit);
 	pqsignal(SIGALRM, SIG_IGN);
 	pqsignal(SIGPIPE, SIG_IGN);
 	pqsignal(SIGUSR1, pgarch_waken);
@@ -246,14 +245,6 @@ PgArchiverMain(int argc, char *argv[])
 	exit(0);
 }
 
-/* SIGQUIT signal handler for archiver process */
-static void
-pgarch_exit(SIGNAL_ARGS)
-{
-	/* SIGQUIT means curl up and die ... */
-	exit(1);
-}
-
 /* SIGUSR1 signal handler for archiver process */
 static void
 pgarch_waken(SIGNAL_ARGS)
-- 
2.18.4


----Next_Part(Tue_Sep__8_17_55_57_2020_197)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="v36-0002-sequential-scan-for-dshash.patch"



^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* [PATCH v2] Allow CI to only run the compiler warnings task
@ 2024-09-11 11:01  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 9+ messages in thread

From: Bertrand Drouvot @ 2024-09-11 11:01 UTC (permalink / raw)

That could be useful to only run the CI compiler warnings task when addressing
compiler warnings issues.

Renaming ci-os-only to ci-task-only and adding filtering for the "compilerwarnings"
task.
---
 .cirrus.tasks.yml   | 20 ++++++++++----------
 src/tools/ci/README |  7 ++++---
 2 files changed, 14 insertions(+), 13 deletions(-)
  19.6% src/tools/ci/

diff --git a/.cirrus.tasks.yml b/.cirrus.tasks.yml
index 5849cbb839a..5aac99e2666 100644
--- a/.cirrus.tasks.yml
+++ b/.cirrus.tasks.yml
@@ -72,7 +72,7 @@ task:
   # push-wait-for-ci cycle time a bit when debugging operating system specific
   # failures. Uses skip instead of only_if, as cirrus otherwise warns about
   # only_if conditions not matching.
-  skip: $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:.*'
+  skip: $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:.*'
 
   env:
     CPUS: 4
@@ -167,7 +167,7 @@ task:
   <<: *freebsd_task_template
 
   depends_on: SanityCheck
-  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*freebsd.*'
+  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*freebsd.*'
 
   sysinfo_script: |
     id
@@ -257,7 +257,7 @@ task:
 
   matrix:
     - name: NetBSD - Meson
-      only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*netbsd.*'
+      only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*netbsd.*'
       env:
         OS_NAME: netbsd
         IMAGE_FAMILY: pg-ci-netbsd-postgres
@@ -274,7 +274,7 @@ task:
       <<: *netbsd_task_template
 
     - name: OpenBSD - Meson
-      only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*openbsd.*'
+      only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*openbsd.*'
       env:
         OS_NAME: openbsd
         IMAGE_FAMILY: pg-ci-openbsd-postgres
@@ -414,7 +414,7 @@ task:
   <<: *linux_task_template
 
   depends_on: SanityCheck
-  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*linux.*'
+  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*linux.*'
 
   ccache_cache:
     folder: ${CCACHE_DIR}
@@ -598,7 +598,7 @@ task:
   <<: *macos_task_template
 
   depends_on: SanityCheck
-  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*(macos|darwin|osx).*'
+  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*(macos|darwin|osx).*'
 
   sysinfo_script: |
     id
@@ -704,7 +704,7 @@ task:
   <<: *windows_task_template
 
   depends_on: SanityCheck
-  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*windows.*'
+  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*windows.*'
 
   setup_additional_packages_script: |
     REM choco install -y --no-progress ...
@@ -742,8 +742,8 @@ task:
   # due to resource constraints we don't run this task by default for now
   trigger_type: manual
   # worth using only_if despite being manual, otherwise this task will show up
-  # when e.g. ci-os-only: linux is used.
-  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*mingw.*'
+  # when e.g. ci-task-only: linux is used.
+  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*mingw.*'
   # otherwise it'll be sorted before other tasks
   depends_on: SanityCheck
 
@@ -802,7 +802,7 @@ task:
   # use always: to continue after failures. Task that did not run count as a
   # success, so we need to recheck SanityChecks's condition here ...
   depends_on: SanityCheck
-  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*'
+  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*compilerwarnings.*'
 
   env:
     CPUS: 4
diff --git a/src/tools/ci/README b/src/tools/ci/README
index 12c1e7c308f..264e36ca6c6 100644
--- a/src/tools/ci/README
+++ b/src/tools/ci/README
@@ -61,10 +61,11 @@ Controlling CI via commit messages
 The behavior of CI can be controlled by special content in commit
 messages. Currently the following controls are available:
 
-- ci-os-only: {(freebsd|linux|macos|mingw|netbsd|openbsd|windows)}
+- ci-task-only: {(freebsd|linux|macos|mingw|netbsd|openbsd|windows|compilerwarnings)}
 
-  Only runs CI on operating systems specified. This can be useful when
-  addressing portability issues affecting only a subset of platforms.
+  Only runs CI on operating systems specified or only runs compiler warnings
+  checks. This can be useful when addressing portability issues affecting only a
+  subset of platforms or when addressing compiler warnings issues.
 
 
 Using custom compute resources for CI
-- 
2.34.1


--zXIor5yQveBako6e--





^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* [PATCH v1] Allow CI to only run the compiler warnings task
@ 2024-09-11 11:01  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 9+ messages in thread

From: Bertrand Drouvot @ 2024-09-11 11:01 UTC (permalink / raw)

That could be useful to only run the CI compiler warnings task when addressing
compiler warnings issues.

Renaming ci-os-only to ci-task-only and adding filtering for the "compilerwarnings"
task.
---
 .cirrus.tasks.yml   | 16 ++++++++--------
 src/tools/ci/README |  7 ++++---
 2 files changed, 12 insertions(+), 11 deletions(-)
  22.5% src/tools/ci/

diff --git a/.cirrus.tasks.yml b/.cirrus.tasks.yml
index 90cb95c868..a4e3b51045 100644
--- a/.cirrus.tasks.yml
+++ b/.cirrus.tasks.yml
@@ -59,7 +59,7 @@ task:
   # push-wait-for-ci cycle time a bit when debugging operating system specific
   # failures. Uses skip instead of only_if, as cirrus otherwise warns about
   # only_if conditions not matching.
-  skip: $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:.*'
+  skip: $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:.*'
 
   env:
     CPUS: 4
@@ -142,7 +142,7 @@ task:
   <<: *freebsd_task_template
 
   depends_on: SanityCheck
-  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*freebsd.*'
+  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*freebsd.*'
 
   sysinfo_script: |
     id
@@ -282,7 +282,7 @@ task:
   <<: *linux_task_template
 
   depends_on: SanityCheck
-  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*linux.*'
+  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*linux.*'
 
   ccache_cache:
     folder: ${CCACHE_DIR}
@@ -441,7 +441,7 @@ task:
   <<: *macos_task_template
 
   depends_on: SanityCheck
-  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*(macos|darwin|osx).*'
+  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*(macos|darwin|osx).*'
 
   sysinfo_script: |
     id
@@ -560,7 +560,7 @@ task:
   <<: *windows_task_template
 
   depends_on: SanityCheck
-  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*windows.*'
+  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*windows.*'
 
   setup_additional_packages_script: |
     REM choco install -y --no-progress ...
@@ -598,8 +598,8 @@ task:
   # due to resource constraints we don't run this task by default for now
   trigger_type: manual
   # worth using only_if despite being manual, otherwise this task will show up
-  # when e.g. ci-os-only: linux is used.
-  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*mingw.*'
+  # when e.g. ci-task-only: linux is used.
+  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*mingw.*'
   # otherwise it'll be sorted before other tasks
   depends_on: SanityCheck
 
@@ -658,7 +658,7 @@ task:
   # use always: to continue after failures. Task that did not run count as a
   # success, so we need to recheck SanityChecks's condition here ...
   depends_on: SanityCheck
-  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*'
+  only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-task-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-task-only:[^\n]*compilerwarnings.*'
 
   env:
     CPUS: 4
diff --git a/src/tools/ci/README b/src/tools/ci/README
index 30ddd200c9..da4125defa 100644
--- a/src/tools/ci/README
+++ b/src/tools/ci/README
@@ -61,10 +61,11 @@ Controlling CI via commit messages
 The behavior of CI can be controlled by special content in commit
 messages. Currently the following controls are available:
 
-- ci-os-only: {(freebsd|linux|macos|windows|mingw)}
+- ci-task-only: {(freebsd|linux|macos|windows|mingw|compilerwarnings)}
 
-  Only runs CI on operating systems specified. This can be useful when
-  addressing portability issues affecting only a subset of platforms.
+  Only runs CI compiler warnings or on operating systems specified. This can be
+  useful when addressing portability issues affecting only a subset of platforms
+  or when addressing compiler warnings issues.
 
 
 Using custom compute resources for CI
-- 
2.34.1


--XFPBEz4cb5xNaK0I--





^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Allow CI to only run the compiler warnings task
@ 2024-09-11 12:36  Bertrand Drouvot <[email protected]>
  0 siblings, 1 reply; 9+ messages in thread

From: Bertrand Drouvot @ 2024-09-11 12:36 UTC (permalink / raw)
  To: [email protected]

Hi hackers,

While working on a new pg_logicalinspect module ([1]), I reached a point where
all the CI tests were green except the compiler warnings one. Then, to save time
addressing the issue, I modified the .cirrus.tasks.yml file to $SUBJECT.

I think this could be useful for others too, so please find attached this tiny
patch.

Note that the patch does not add an extra "ci-task-only", but for simplicity it
it renames ci-os-only to ci-task-only.


[1]: https://www.postgresql.org/message-id/ZuF2Okt7aBR//bxu%40ip-10-97-1-34.eu-west-3.compute.internal

Looking forward to your feedback,

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com


^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Re: Allow CI to only run the compiler warnings task
@ 2024-09-11 13:39  Nazir Bilal Yavuz <[email protected]>
  parent: Bertrand Drouvot <[email protected]>
  0 siblings, 1 reply; 9+ messages in thread

From: Nazir Bilal Yavuz @ 2024-09-11 13:39 UTC (permalink / raw)
  To: Bertrand Drouvot <[email protected]>; +Cc: [email protected]

Hi,

On Wed, 11 Sept 2024 at 15:36, Bertrand Drouvot
<[email protected]> wrote:
>
> Hi hackers,
>
> While working on a new pg_logicalinspect module ([1]), I reached a point where
> all the CI tests were green except the compiler warnings one. Then, to save time
> addressing the issue, I modified the .cirrus.tasks.yml file to $SUBJECT.
>
> I think this could be useful for others too, so please find attached this tiny
> patch.

+1 for this. I encountered the same issue before.

> Note that the patch does not add an extra "ci-task-only", but for simplicity it
> it renames ci-os-only to ci-task-only.

I think this change makes sense. I gave a quick try to your patch with
ci-task-only: ["", "linux", "compilerwarnings"] and it worked as
expected.

--
Regards,
Nazir Bilal Yavuz
Microsoft





^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Re: Allow CI to only run the compiler warnings task
@ 2024-09-12 05:21  Bertrand Drouvot <[email protected]>
  parent: Nazir Bilal Yavuz <[email protected]>
  0 siblings, 1 reply; 9+ messages in thread

From: Bertrand Drouvot @ 2024-09-12 05:21 UTC (permalink / raw)
  To: Nazir Bilal Yavuz <[email protected]>; +Cc: [email protected]

Hi,

On Wed, Sep 11, 2024 at 04:39:57PM +0300, Nazir Bilal Yavuz wrote:
> Hi,
> 
> On Wed, 11 Sept 2024 at 15:36, Bertrand Drouvot
> <[email protected]> wrote:
> >
> > Hi hackers,
> >
> > While working on a new pg_logicalinspect module ([1]), I reached a point where
> > all the CI tests were green except the compiler warnings one. Then, to save time
> > addressing the issue, I modified the .cirrus.tasks.yml file to $SUBJECT.
> >
> > I think this could be useful for others too, so please find attached this tiny
> > patch.
> 
> +1 for this. I encountered the same issue before.

Thanks for the feedback!

> 
> > Note that the patch does not add an extra "ci-task-only", but for simplicity it
> > it renames ci-os-only to ci-task-only.
> 
> I think this change makes sense. I gave a quick try to your patch with
> ci-task-only: ["", "linux", "compilerwarnings"] and it worked as
> expected.

And for the testing.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com





^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Re: Allow CI to only run the compiler warnings task
@ 2025-03-11 07:25  Bertrand Drouvot <[email protected]>
  parent: Bertrand Drouvot <[email protected]>
  0 siblings, 1 reply; 9+ messages in thread

From: Bertrand Drouvot @ 2025-03-11 07:25 UTC (permalink / raw)
  To: Nazir Bilal Yavuz <[email protected]>; +Cc: [email protected]

Hi,

On Thu, Sep 12, 2024 at 05:21:43AM +0000, Bertrand Drouvot wrote:
> Hi,
> 
> On Wed, Sep 11, 2024 at 04:39:57PM +0300, Nazir Bilal Yavuz wrote:
> > Hi,
> > 
> > On Wed, 11 Sept 2024 at 15:36, Bertrand Drouvot
> > <[email protected]> wrote:
> > >
> > > Hi hackers,
> > >
> > > While working on a new pg_logicalinspect module ([1]), I reached a point where
> > > all the CI tests were green except the compiler warnings one. Then, to save time
> > > addressing the issue, I modified the .cirrus.tasks.yml file to $SUBJECT.
> > >
> > > I think this could be useful for others too, so please find attached this tiny
> > > patch.
> > 
> > +1 for this. I encountered the same issue before.
> 
> Thanks for the feedback!
> 
> > 
> > > Note that the patch does not add an extra "ci-task-only", but for simplicity it
> > > it renames ci-os-only to ci-task-only.
> > 
> > I think this change makes sense. I gave a quick try to your patch with
> > ci-task-only: ["", "linux", "compilerwarnings"] and it worked as
> > expected.
> 
> And for the testing.

Mandatory rebase attached.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com


^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Re: Allow CI to only run the compiler warnings task
@ 2025-05-21 17:31  Rustam ALLAKOV <[email protected]>
  parent: Bertrand Drouvot <[email protected]>
  0 siblings, 1 reply; 9+ messages in thread

From: Rustam ALLAKOV @ 2025-05-21 17:31 UTC (permalink / raw)
  To: [email protected]; +Cc: Bertrand Drouvot <[email protected]>

The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       not tested
Spec compliant:           tested, failed
Documentation:            tested, failed

Hi Hackers,

it might be better to list tasks in alphabetical order, and if I understand correctly
initially they were alphabetically sorted. 

> ci-task-only: {(compilerwarnings|freebsd|linux|macos|mingw|netbsd|openbsd|windows)} 

also it may increase readability if you sort tasks alphabetically within the .cirrust.tasks.yml 

Kindest regards. 
Rustam

The new status of this patch is: Waiting on Author


^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Re: Allow CI to only run the compiler warnings task
@ 2025-06-04 18:08  David G. Johnston <[email protected]>
  parent: Rustam ALLAKOV <[email protected]>
  0 siblings, 0 replies; 9+ messages in thread

From: David G. Johnston @ 2025-06-04 18:08 UTC (permalink / raw)
  To: Rustam ALLAKOV <[email protected]>; +Cc: [email protected]; Bertrand Drouvot <[email protected]>

On Wed, May 21, 2025 at 10:32 AM Rustam ALLAKOV <[email protected]>
wrote:

> The following review has been posted through the commitfest application:
> make installcheck-world:  not tested
> Implements feature:       not tested
> Spec compliant:           tested, failed
> Documentation:            tested, failed
>
> Hi Hackers,
>
> it might be better to list tasks in alphabetical order, and if I
> understand correctly
> initially they were alphabetically sorted.
>
> > ci-task-only:
> {(compilerwarnings|freebsd|linux|macos|mingw|netbsd|openbsd|windows)}


Appending the option and matching the yml file is proper for this patch
given its goal.

I do feel like there is something a bit off.  Specifically:

I'd keep ci-os-only as a deprecated alias for a while - let it accept the
new compilerwarnings task name.  I'd rather not break people's muscle
memory and the fact they are unlikely to realize this change until they run
one through and see everything running despite their directive.  The "mess"
is quite minimal for the benefit.
(this is the only one I'd say is a - soft - patch blocker for me)

I'd like to communicate the always-runs versus the manual runs here in some
way.
Keeping the flavors together would seem to have merit.
I feel like the yml file itself should put these in a comment block.


> also it may increase readability if you sort tasks alphabetically within
> the .cirrust.tasks.yml
>
>
That should be done as a dedicated refactoring patch.  I wouldn't consider
it high priority though.  I'd love to find something that makes my outliner
display the task names as maximum collapse though (VS Code).

I'm apt to propose a refactoring patch here at some point to address these
things - but this patch to extend the yml file in an obvious way need not
take on such responsibilities.

David J.


^ permalink  raw  reply  [nested|flat] 9+ messages in thread


end of thread, other threads:[~2025-06-04 18:08 UTC | newest]

Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-03-16 08:15 [PATCH v36 1/7] Use standard crash handler in archiver. Kyotaro Horiguchi <[email protected]>
2024-09-11 11:01 [PATCH v2] Allow CI to only run the compiler warnings task Bertrand Drouvot <[email protected]>
2024-09-11 11:01 [PATCH v1] Allow CI to only run the compiler warnings task Bertrand Drouvot <[email protected]>
2024-09-11 12:36 Allow CI to only run the compiler warnings task Bertrand Drouvot <[email protected]>
2024-09-11 13:39 ` Re: Allow CI to only run the compiler warnings task Nazir Bilal Yavuz <[email protected]>
2024-09-12 05:21   ` Re: Allow CI to only run the compiler warnings task Bertrand Drouvot <[email protected]>
2025-03-11 07:25     ` Re: Allow CI to only run the compiler warnings task Bertrand Drouvot <[email protected]>
2025-05-21 17:31       ` Re: Allow CI to only run the compiler warnings task Rustam ALLAKOV <[email protected]>
2025-06-04 18:08         ` Re: Allow CI to only run the compiler warnings task David G. Johnston <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox